| Message ID | 20240827181717.187245-1-robdclark@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | io-pgtable-arm + drm/msm: Extend iova fault debugging | expand |
Hi Rob, On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > From: Rob Clark <robdclark@chromium.org> > > This series extends io-pgtable-arm with a method to retrieve the page > table entries traversed in the process of address translation, and then > beefs up drm/msm gpu devcore dump to include this (and additional info) > in the devcore dump. > > This is a respin of https://patchwork.freedesktop.org/series/94968/ > (minus a patch that was already merged) > > v2: Fix an armv7/32b build error in the last patch > v3: Incorperate Will Deacon's suggestion to make the interface > callback based. > v4: Actually wire up the callback > v5: Drop the callback approach > v6: Make walk-data struct pgtable specific and rename > io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data > v7: Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty() > v8: Pass pte pointer to callback so it can modify the actual pte > v9: Fix selftests_running case > > Rob Clark (4): > iommu/io-pgtable-arm: Make pgtable walker more generic > iommu/io-pgtable-arm: Re-use the pgtable walk for iova_to_phys > iommu/io-pgtable-arm: Add way to debug pgtable walk > drm/msm: Extend gpu devcore dumps with pgtbl info Do you have plans to post another version of this series, as I am working on some patches, that would use some of the common page walk logic, so it would be more convenient to have them upstream. Otherwise, I can have your series as a dependency. Thanks, Mostafa > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ > drivers/gpu/drm/msm/msm_gpu.c | 9 ++ > drivers/gpu/drm/msm/msm_gpu.h | 8 ++ > drivers/gpu/drm/msm/msm_iommu.c | 22 ++++ > drivers/gpu/drm/msm/msm_mmu.h | 3 +- > drivers/iommu/io-pgtable-arm.c | 149 +++++++++++++++--------- > include/linux/io-pgtable.h | 15 +++ > 7 files changed, 160 insertions(+), 56 deletions(-) > > -- > 2.46.0 >
On Mon, Oct 28, 2024 at 4:53 AM Mostafa Saleh <smostafa@google.com> wrote: > > Hi Rob, > > On Tue, Aug 27, 2024 at 11:17:08AM -0700, Rob Clark wrote: > > From: Rob Clark <robdclark@chromium.org> > > > > This series extends io-pgtable-arm with a method to retrieve the page > > table entries traversed in the process of address translation, and then > > beefs up drm/msm gpu devcore dump to include this (and additional info) > > in the devcore dump. > > > > This is a respin of https://patchwork.freedesktop.org/series/94968/ > > (minus a patch that was already merged) > > > > v2: Fix an armv7/32b build error in the last patch > > v3: Incorperate Will Deacon's suggestion to make the interface > > callback based. > > v4: Actually wire up the callback > > v5: Drop the callback approach > > v6: Make walk-data struct pgtable specific and rename > > io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data > > v7: Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty() > > v8: Pass pte pointer to callback so it can modify the actual pte > > v9: Fix selftests_running case > > > > Rob Clark (4): > > iommu/io-pgtable-arm: Make pgtable walker more generic > > iommu/io-pgtable-arm: Re-use the pgtable walk for iova_to_phys > > iommu/io-pgtable-arm: Add way to debug pgtable walk > > drm/msm: Extend gpu devcore dumps with pgtbl info > > Do you have plans to post another version of this series, as I am > working on some patches, that would use some of the common page walk > logic, so it would be more convenient to have them upstream. > Otherwise, I can have your series as a dependency. Sorry, this had dropped off my radar, I'll post an updated iteration in a couple minutes. BR, -R > Thanks, > Mostafa > > > > > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ > > drivers/gpu/drm/msm/msm_gpu.c | 9 ++ > > drivers/gpu/drm/msm/msm_gpu.h | 8 ++ > > drivers/gpu/drm/msm/msm_iommu.c | 22 ++++ > > drivers/gpu/drm/msm/msm_mmu.h | 3 +- > > drivers/iommu/io-pgtable-arm.c | 149 +++++++++++++++--------- > > include/linux/io-pgtable.h | 15 +++ > > 7 files changed, 160 insertions(+), 56 deletions(-) > > > > -- > > 2.46.0 > >
From: Rob Clark <robdclark@chromium.org> This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedesktop.org/series/94968/ (minus a patch that was already merged) v2: Fix an armv7/32b build error in the last patch v3: Incorperate Will Deacon's suggestion to make the interface callback based. v4: Actually wire up the callback v5: Drop the callback approach v6: Make walk-data struct pgtable specific and rename io_pgtable_walk_data to arm_lpae_io_pgtable_walk_data v7: Re-use the pgtable walker added for arm_lpae_read_and_clear_dirty() v8: Pass pte pointer to callback so it can modify the actual pte v9: Fix selftests_running case Rob Clark (4): iommu/io-pgtable-arm: Make pgtable walker more generic iommu/io-pgtable-arm: Re-use the pgtable walk for iova_to_phys iommu/io-pgtable-arm: Add way to debug pgtable walk drm/msm: Extend gpu devcore dumps with pgtbl info drivers/gpu/drm/msm/adreno/adreno_gpu.c | 10 ++ drivers/gpu/drm/msm/msm_gpu.c | 9 ++ drivers/gpu/drm/msm/msm_gpu.h | 8 ++ drivers/gpu/drm/msm/msm_iommu.c | 22 ++++ drivers/gpu/drm/msm/msm_mmu.h | 3 +- drivers/iommu/io-pgtable-arm.c | 149 +++++++++++++++--------- include/linux/io-pgtable.h | 15 +++ 7 files changed, 160 insertions(+), 56 deletions(-)