[v16,0/5] iommu/arm-smmu: introduction of ACTLR implementation for Qualcomm SoCs

Message

Bibek Kumar Patro Oct. 8, 2024, 12:54 p.m. UTC

This patch series consist of six parts and covers the following:

1. Re-enable context caching for Qualcomm SoCs to retain prefetcher
   settings during reset and runtime suspend.

2. Remove cfg inside qcom_smmu structure and replace it with single
   pointer to qcom_smmu_match_data avoiding replication of multiple
   members from same.

3. Add support for ACTLR PRR bit setup via adreno-smmu-priv interface.

4. Introduce intital set of driver changes to implement ACTLR register
   for custom prefetcher settings in Qualcomm SoCs.

5. Add ACTLR data and support for qcom_smmu_500.

Changes in v16 from v15:
 - Incorporate Dimitry's suggestion on patch 4/5 to use dev_dbg instead of dev_notice.
 - Fix kernel test robot warning [1] coming for 32bit architecture configuration.
 - Updatingthe tags
 [1]: https://lore.kernel.org/all/[e-mail]/
 Link to v15:
 https://lore.kernel.org/all/[e-mail]/

Changes in v15 from v14:
 - As discussed with Robin and Dmitry modify the actlr table and logic to use
   compatible string instead of sid, mask for device matching which is
   similar to qcom_smmu_client_of_match mechanism.
 - Expand the comment in qcom_smmu500_reset to document reason why CPRE bit is re-enabled again
   after arm_mmu500_reset resets the bit.
 - Rearrange the series in order to keep prefetch setting patches in the end.
 Link to v14:
 https://lore.kernel.org/all/[e-mail]/

Changes in v14 from v13:
 Patch 6/6:
 - As discussed incorprate changes to carry out PRR implementation only for
   targets based on MMU-500 by using compat string based SMMU version detection.
 - Split the set_actlr interface into two separate interface namely set_prr_bit
   and set_prr_addr to set the prr enable bit and prr page address resepectively.
 Patch 3/6:
  - Fix a bug in gfx actlr_config which is uncovered while testing the gfx actlr setting in sc7280
    during PRR experiment which prevented clients on certain sids of gfx smmmu to be skipped during
    setting up of the ACTLR values : Fix involves swapping the arguments passed in smr_is_subset to make
     device smr <from devicetree> a subset of actlr_config table entries < defined in the driver>.
 Patch 4/6, 5/6:
  - Sort the actlr table values in increasing order of the SIDs.
 Link to v13:
 https://lore.kernel.org/all/[e-mail]/

Changes in v13 from v12:
 - Fix the compilation issues reported by kernel test robot [1].
 [1]: https://lore.kernel.org/all/[e-mail]/#t
 Link to v12:
 https://lore.kernel.org/all/[e-mail]/

Changes in v12 from v11:
 Changes to incorporate suggestion from Rob:
 - Fix the set and reset logic for prr bit as pointed out in v11-6/6.
 - Rename set_actlr_bit function name to set_prr.
 - Add extension for PRR name as Partially-Resident-Region in comments
   for set_prr function.
 - Add few missing sids for sc7280 in patch-5/6.
 Link to v11:
 https://lore.kernel.org/all/[e-mail]/

Changes in v11 from v10:
 - Include a new patch 6/6 to add support for ACTLR PRR bit
   through adreno-smmu-priv interface as suggested by Rob and Dmitry.
 Link to v10:
 https://lore.kernel.org/all/[e-mail]/

Changes in v10 from v9:
 - Added reviewed-by tags 1/5,2/5,3/5.
 Changes incorporated:
 - Remove redundant PRR bit setting from gfx actlr table(patch 4/5,5/5)
   as this bit needs special handling in the gfx driver along with
   the associated register settings.
 Link to discussion on PRR bit:
 https://lore.kernel.org/all/[e-mail]/
 Link to v9:
 https://lore.kernel.org/all/[e-mail]/

Changes in v9 from v8:
 Changes to incorporate suggestions from Konrad as follows:
 - Re-wrap struct members of actlr_variant in patch 4/5,5/5
   in a cleaner way.
 - Move actlr_config members to the header.
 Link to v8:
 https://lore.kernel.org/all/[e-mail]/

Changes in v8 from v7:
 - Added reviewed-by tags on patch 1/5, 2/5.
 Changes to incorporate suggestions from Pavan and Konrad:
 - Remove non necessary extra lines.
 - Use num_smmu and num_actlrcfg to store the array size and use the
   same to traverse the table and save on sentinel space along with
   indentation levels.
 - Refactor blocks containing qcom_smmu_set_actlr to remove block
   repetition in patch 3/5.
 - Change copyright year from 2023 to 2022-2023 in patch 3/5.
 - Modify qcom_smmu_match_data.actlrvar and actlr_variant.actlrcfg to
   const pointer to a const resource.
 - use C99 designated initializers and put the address first.
 Link to v7:
 https://lore.kernel.org/all/[e-mail]/

Changes in v7 from v6:
 Changes to incorporate suggestions from Dmitry as follows:
 - Use io_start address instead of compatible string to identify the
   correct instance by comparing with smmu start address and check for
   which smmu the corresponding actlr table is to be picked.
Link to v6:
https://lore.kernel.org/all/[e-mail]/

Changes in v6 from v5:
 - Remove extra Suggested-by tags.
 - Add return check for arm_mmu500_reset in 1/5 as discussed.
Link to v5:
https://lore.kernel.org/all/[e-mail]/

Changes in v5 from v4:
 New addition:
 - Modify copyright year in arm-smmu-qcom.h to 2023 from 2022.
 Changes to incorporate suggestions from Dmitry as follows:
 - Modify the defines for prefetch in (foo << bar) format
   as suggested.(FIELD_PREP could not be used in defines
   is not inside any block/function)
 Changes to incorporate suggestions from Konrad as follows:
 - Shift context caching enablement patch as 1/5 instead of 5/5 to
   be picked up as independent patch.
 - Fix the codestyle to orient variables in reverse xmas tree format
   for patch 1/5.
 - Fix variable name in patch 1/5 as suggested.
 Link to v4:
https://lore.kernel.org/all/[e-mail]/

Changes in v4 from v3:
 New addition:
 - Remove actlrcfg_size and use NULL end element instead to traverse
   the actlr table, as this would be a cleaner approach by removing
   redundancy of actlrcfg_size.
 - Renaming of actlr set function to arm_smmu_qcom based proprietary
   convention.
 - break from loop once sid is found and ACTLR value is initialized
   in qcom_smmu_set_actlr.
 - Modify the GFX prefetch value separating into 2 sensible defines.
 - Modify comments for prefetch defines as per SMMU-500 TRM.
 Changes to incorporate suggestions from Konrad as follows:
 - Use Reverse-Christmas-tree sorting wherever applicable.
 - Pass arguments directly to arm_smmu_set_actlr instead of creating
   duplicate variables.
 - Use array indexing instead of direct pointer addressed by new
   addition of eliminating actlrcfg_size.
 - Switch the HEX value's case from upper to lower case in SC7280
   actlrcfg table.
 Changes to incorporate suggestions from Dmitry as follows:
 - Separate changes not related to ACTLR support to different commit
   with patch 5/5.
 - Using pointer to struct for arguments in smr_is_subset().
 Changes to incorporate suggestions from Bjorn as follows:
 - fix the commit message for patch 2/5 to properly document the
   value space to avoid confusion.
 Fixed build issues reported by kernel test robot [1] for
 arm64-allyesconfig [2].
 [1]: https://lore.kernel.org/all/[e-mail]/
 [2]:
https://download.01.org/0day-ci/archive/20231201/[e-mail]/config
 Link to v3:
https://lore.kernel.org/all/[e-mail]/

Changes in v3 from v2:
 New addition:
 - Include patch 3/4 for adding ACTLR support and data for SC7280.
 - Add driver changes for actlr support in gpu smmu.
 - Add target wise actlr data and implementation ops for gpu smmu.
 Changes to incorporate suggestions from Robin as follows:
 - Match the ACTLR values with individual corresponding SID instead
   of assuming that any SMR will be programmed to match a superset of
   the data.
 - Instead of replicating each elements from qcom_smmu_match_data to
   qcom_smmu structre during smmu device creation, replace the
   replicated members with qcom_smmu_match_data structure inside
   qcom_smmu structre and handle the dereference in places that
   requires them.
 Changes to incorporate suggestions from Dmitry and Konrad as follows:
 - Maintain actlr table inside a single structure instead of
   nested structure.
 - Rename prefetch defines to more appropriately describe their
   behavior.
 - Remove SM8550 specific implementation ops and roll back to default
   qcom_smmu_500_impl implementation ops.
 - Add back the removed comments which are NAK.
 - Fix commit description for patch 4/4.
 Link to v2:
https://lore.kernel.org/all/[e-mail]/

Changes in v2 from v1:
 - Incorporated suggestions on v1 from Dmitry,Konrad,Pratyush.
 - Added defines for ACTLR values.
 - Linked sm8550 implementation structure to corresponding
   compatible string.
 - Repackaged actlr value set implementation to separate function.
 - Fixed indentation errors.
 - Link to v1:
https://lore.kernel.org/all/[e-mail]/

Changes in v1 from RFC:
 - Incorporated suggestion form Robin on RFC
 - Moved the actlr data table into driver, instead of maintaining
   it inside soc specific DT and piggybacking on exisiting iommus
   property (iommu = <SID, MASK, ACTLR>) to set this value during
   smmu probe.
 - Link to RFC:
https://lore.kernel.org/all/[e-mail]/

Bibek Kumar Patro (5):
  iommu/arm-smmu: re-enable context caching in smmu reset operation
  iommu/arm-smmu: refactor qcom_smmu structure to include single pointer
  iommu/arm-smmu: add support for PRR bit setup
  iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings
  iommu/arm-smmu: add ACTLR data and support for qcom_smmu_500

 .../iommu/arm/arm-smmu/arm-smmu-qcom-debug.c  |   2 +-
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c    | 134 +++++++++++++++++-
 drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h    |   3 +-
 drivers/iommu/arm/arm-smmu/arm-smmu.h         |   2 +
 include/linux/adreno-smmu-priv.h              |  10 +-
 5 files changed, 144 insertions(+), 7 deletions(-)

--
2.34.1

Comments

Bibek Kumar Patro Oct. 23, 2024, 7:07 p.m. UTC | #1

Hi Rob,

Just wanted to check if anything else need to be addressed here to gain
further attention on this series.

Thanks & regards,
Bibek

On 10/8/2024 6:24 PM, Bibek Kumar Patro wrote:
> This patch series consist of six parts and covers the following:
> 
> 1. Re-enable context caching for Qualcomm SoCs to retain prefetcher
>     settings during reset and runtime suspend.
> 
> 2. Remove cfg inside qcom_smmu structure and replace it with single
>     pointer to qcom_smmu_match_data avoiding replication of multiple
>     members from same.
> 
> 3. Add support for ACTLR PRR bit setup via adreno-smmu-priv interface.
> 
> 4. Introduce intital set of driver changes to implement ACTLR register
>     for custom prefetcher settings in Qualcomm SoCs.
> 
> 5. Add ACTLR data and support for qcom_smmu_500.
> 
> Changes in v16 from v15:
>   - Incorporate Dimitry's suggestion on patch 4/5 to use dev_dbg instead of dev_notice.
>   - Fix kernel test robot warning [1] coming for 32bit architecture configuration.
>   - Updatingthe tags
>   [1]: https://lore.kernel.org/all/[e-mail]/
>   Link to v15:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v15 from v14:
>   - As discussed with Robin and Dmitry modify the actlr table and logic to use
>     compatible string instead of sid, mask for device matching which is
>     similar to qcom_smmu_client_of_match mechanism.
>   - Expand the comment in qcom_smmu500_reset to document reason why CPRE bit is re-enabled again
>     after arm_mmu500_reset resets the bit.
>   - Rearrange the series in order to keep prefetch setting patches in the end.
>   Link to v14:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v14 from v13:
>   Patch 6/6:
>   - As discussed incorprate changes to carry out PRR implementation only for
>     targets based on MMU-500 by using compat string based SMMU version detection.
>   - Split the set_actlr interface into two separate interface namely set_prr_bit
>     and set_prr_addr to set the prr enable bit and prr page address resepectively.
>   Patch 3/6:
>    - Fix a bug in gfx actlr_config which is uncovered while testing the gfx actlr setting in sc7280
>      during PRR experiment which prevented clients on certain sids of gfx smmmu to be skipped during
>      setting up of the ACTLR values : Fix involves swapping the arguments passed in smr_is_subset to make
>       device smr <from devicetree> a subset of actlr_config table entries < defined in the driver>.
>   Patch 4/6, 5/6:
>    - Sort the actlr table values in increasing order of the SIDs.
>   Link to v13:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v13 from v12:
>   - Fix the compilation issues reported by kernel test robot [1].
>   [1]: https://lore.kernel.org/all/[e-mail]/#t
>   Link to v12:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v12 from v11:
>   Changes to incorporate suggestion from Rob:
>   - Fix the set and reset logic for prr bit as pointed out in v11-6/6.
>   - Rename set_actlr_bit function name to set_prr.
>   - Add extension for PRR name as Partially-Resident-Region in comments
>     for set_prr function.
>   - Add few missing sids for sc7280 in patch-5/6.
>   Link to v11:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v11 from v10:
>   - Include a new patch 6/6 to add support for ACTLR PRR bit
>     through adreno-smmu-priv interface as suggested by Rob and Dmitry.
>   Link to v10:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v10 from v9:
>   - Added reviewed-by tags 1/5,2/5,3/5.
>   Changes incorporated:
>   - Remove redundant PRR bit setting from gfx actlr table(patch 4/5,5/5)
>     as this bit needs special handling in the gfx driver along with
>     the associated register settings.
>   Link to discussion on PRR bit:
>   https://lore.kernel.org/all/[e-mail]/
>   Link to v9:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v9 from v8:
>   Changes to incorporate suggestions from Konrad as follows:
>   - Re-wrap struct members of actlr_variant in patch 4/5,5/5
>     in a cleaner way.
>   - Move actlr_config members to the header.
>   Link to v8:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v8 from v7:
>   - Added reviewed-by tags on patch 1/5, 2/5.
>   Changes to incorporate suggestions from Pavan and Konrad:
>   - Remove non necessary extra lines.
>   - Use num_smmu and num_actlrcfg to store the array size and use the
>     same to traverse the table and save on sentinel space along with
>     indentation levels.
>   - Refactor blocks containing qcom_smmu_set_actlr to remove block
>     repetition in patch 3/5.
>   - Change copyright year from 2023 to 2022-2023 in patch 3/5.
>   - Modify qcom_smmu_match_data.actlrvar and actlr_variant.actlrcfg to
>     const pointer to a const resource.
>   - use C99 designated initializers and put the address first.
>   Link to v7:
>   https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v7 from v6:
>   Changes to incorporate suggestions from Dmitry as follows:
>   - Use io_start address instead of compatible string to identify the
>     correct instance by comparing with smmu start address and check for
>     which smmu the corresponding actlr table is to be picked.
> Link to v6:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v6 from v5:
>   - Remove extra Suggested-by tags.
>   - Add return check for arm_mmu500_reset in 1/5 as discussed.
> Link to v5:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v5 from v4:
>   New addition:
>   - Modify copyright year in arm-smmu-qcom.h to 2023 from 2022.
>   Changes to incorporate suggestions from Dmitry as follows:
>   - Modify the defines for prefetch in (foo << bar) format
>     as suggested.(FIELD_PREP could not be used in defines
>     is not inside any block/function)
>   Changes to incorporate suggestions from Konrad as follows:
>   - Shift context caching enablement patch as 1/5 instead of 5/5 to
>     be picked up as independent patch.
>   - Fix the codestyle to orient variables in reverse xmas tree format
>     for patch 1/5.
>   - Fix variable name in patch 1/5 as suggested.
>   Link to v4:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v4 from v3:
>   New addition:
>   - Remove actlrcfg_size and use NULL end element instead to traverse
>     the actlr table, as this would be a cleaner approach by removing
>     redundancy of actlrcfg_size.
>   - Renaming of actlr set function to arm_smmu_qcom based proprietary
>     convention.
>   - break from loop once sid is found and ACTLR value is initialized
>     in qcom_smmu_set_actlr.
>   - Modify the GFX prefetch value separating into 2 sensible defines.
>   - Modify comments for prefetch defines as per SMMU-500 TRM.
>   Changes to incorporate suggestions from Konrad as follows:
>   - Use Reverse-Christmas-tree sorting wherever applicable.
>   - Pass arguments directly to arm_smmu_set_actlr instead of creating
>     duplicate variables.
>   - Use array indexing instead of direct pointer addressed by new
>     addition of eliminating actlrcfg_size.
>   - Switch the HEX value's case from upper to lower case in SC7280
>     actlrcfg table.
>   Changes to incorporate suggestions from Dmitry as follows:
>   - Separate changes not related to ACTLR support to different commit
>     with patch 5/5.
>   - Using pointer to struct for arguments in smr_is_subset().
>   Changes to incorporate suggestions from Bjorn as follows:
>   - fix the commit message for patch 2/5 to properly document the
>     value space to avoid confusion.
>   Fixed build issues reported by kernel test robot [1] for
>   arm64-allyesconfig [2].
>   [1]: https://lore.kernel.org/all/[e-mail]/
>   [2]:
> https://download.01.org/0day-ci/archive/20231201/[e-mail]/config
>   Link to v3:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v3 from v2:
>   New addition:
>   - Include patch 3/4 for adding ACTLR support and data for SC7280.
>   - Add driver changes for actlr support in gpu smmu.
>   - Add target wise actlr data and implementation ops for gpu smmu.
>   Changes to incorporate suggestions from Robin as follows:
>   - Match the ACTLR values with individual corresponding SID instead
>     of assuming that any SMR will be programmed to match a superset of
>     the data.
>   - Instead of replicating each elements from qcom_smmu_match_data to
>     qcom_smmu structre during smmu device creation, replace the
>     replicated members with qcom_smmu_match_data structure inside
>     qcom_smmu structre and handle the dereference in places that
>     requires them.
>   Changes to incorporate suggestions from Dmitry and Konrad as follows:
>   - Maintain actlr table inside a single structure instead of
>     nested structure.
>   - Rename prefetch defines to more appropriately describe their
>     behavior.
>   - Remove SM8550 specific implementation ops and roll back to default
>     qcom_smmu_500_impl implementation ops.
>   - Add back the removed comments which are NAK.
>   - Fix commit description for patch 4/4.
>   Link to v2:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v2 from v1:
>   - Incorporated suggestions on v1 from Dmitry,Konrad,Pratyush.
>   - Added defines for ACTLR values.
>   - Linked sm8550 implementation structure to corresponding
>     compatible string.
>   - Repackaged actlr value set implementation to separate function.
>   - Fixed indentation errors.
>   - Link to v1:
> https://lore.kernel.org/all/[e-mail]/
> 
> Changes in v1 from RFC:
>   - Incorporated suggestion form Robin on RFC
>   - Moved the actlr data table into driver, instead of maintaining
>     it inside soc specific DT and piggybacking on exisiting iommus
>     property (iommu = <SID, MASK, ACTLR>) to set this value during
>     smmu probe.
>   - Link to RFC:
> https://lore.kernel.org/all/[e-mail]/
> 
> Bibek Kumar Patro (5):
>    iommu/arm-smmu: re-enable context caching in smmu reset operation
>    iommu/arm-smmu: refactor qcom_smmu structure to include single pointer
>    iommu/arm-smmu: add support for PRR bit setup
>    iommu/arm-smmu: introduction of ACTLR for custom prefetcher settings
>    iommu/arm-smmu: add ACTLR data and support for qcom_smmu_500
> 
>   .../iommu/arm/arm-smmu/arm-smmu-qcom-debug.c  |   2 +-
>   drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c    | 134 +++++++++++++++++-
>   drivers/iommu/arm/arm-smmu/arm-smmu-qcom.h    |   3 +-
>   drivers/iommu/arm/arm-smmu/arm-smmu.h         |   2 +
>   include/linux/adreno-smmu-priv.h              |  10 +-
>   5 files changed, 144 insertions(+), 7 deletions(-)
> 
> --
> 2.34.1
>