From patchwork Wed Oct 30 11:02:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Glathe via B4 Relay X-Patchwork-Id: 13856315 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A4A1E47A3; Wed, 30 Oct 2024 11:02:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730286148; cv=none; b=SHIeI6fQxNNNWRQpCeix2QCdDfdqZO9CufXtGx87gEO6QJxJSeYn0ag7+mn/z1F/MExUGF8DGJXjL7WLIV9fZ/AJygk8KJJzKYSPOtzsXLJ7TbBM+y06LBEB7AOTCGTnc38P2g53MSqb7ZyUiYJMHCsApLYaRBuphlwbKbITN10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730286148; c=relaxed/simple; bh=0Dx+GRSSReIlp/PbIy5fSGRXrVHxMBc64VeebXZyKYM=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=giicuxhcROPxu9AdkSlOZNpSRLhEFAl1WxQB1Jp4CT+Jwn1d+n367FT4OQG2O3x0s4fJG1vPG+sZsNbA8QqVEqlX+8SEdtZ22qm8PqZsU9F7kf2VoVIRLY9D1rGSl2/X2CZxnAnsry4cHYKwyuPjNuJa+/zQGngg9ODmeIAjQLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MlGjherJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MlGjherJ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2980EC4CEE3; Wed, 30 Oct 2024 11:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730286148; bh=0Dx+GRSSReIlp/PbIy5fSGRXrVHxMBc64VeebXZyKYM=; h=From:Subject:Date:To:Cc:Reply-To:From; b=MlGjherJv+A9GvoNO/dVINT20Ku9Ds+uFOUESpcdMqKh5UbOCphfJVdEwQp+ImTjc EhagezyOpvPwRF0BKxJB9UyRJxx0j+7K9MRVN6qfKTBQS8RN/DYB3hSaLhBC45pb7D hZl5ckio0rgG1GBNyTHomGvWdrDj9/YLQiPa1d3ywP2Ys9WqEjLtOwYL+GOThHBI5Y ero1OBpqzYsYcXRgRV5P/cX8q8nP52TYY6LXXrwxMxnE9ecpwKe6pCQYY0n2w7613J wxs+363Cj8/iCV27ph8ws+tzpqp8wtDPac9OjBca6Y6B92/hLlxoQ1Lm5M48EQs2Xh rK3yIvgPIAO/w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFEED5CC94; Wed, 30 Oct 2024 11:02:28 +0000 (UTC) From: Jens Glathe via B4 Relay Subject: [PATCH v6 0/3] arm64: dts: qcom: sc8280xp-blackrock: dt definition for Windows Dev Kit 2023 Date: Wed, 30 Oct 2024 12:02:00 +0100 Message-Id: <20241030-jg-blackrock-for-upstream-v6-0-7cd7f7d8d97c@oldschoolsolutions.biz> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIACkSImcC/43QwW7DIAwG4FepOM8T2FBgp73HtAMh0LCmpYI02 lbl3UdzmHpZtONvyZ9/+cZqKClU9rK7sRLmVFM+t7B/2jE/uPMhQOpbZshRcoscPg7Qjc4fS/Z HiLnA9VKnEtwJtNfOO+TBELK2fykhps/VfntveUh1yuVrPTWL+5SpqKTRQUCQyoB05MBFjuAVB sW9E3YvX/PYVz/kPNY8XqfWrz536ZvdyRlX5h/lZgQOtosYRYfCCr/J0i8ruKAtlhpryPYkDTk T9CYrH1jUW6xsrObUoZLRWxU3WfXA0uYT1NqWe0tGknb9n+yyLD+v0PvhGwIAAA== To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kalle Valo Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Merck Hung , Jens Glathe , Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1730286146; l=4844; i=jens.glathe@oldschoolsolutions.biz; s=20240919; h=from:subject:message-id; bh=0Dx+GRSSReIlp/PbIy5fSGRXrVHxMBc64VeebXZyKYM=; b=6NT84GoA27w26Pv3Vz0hGK+AVapMcgrpiOMWxz9hHGoYaJByu6s3tFpQPEG7iP3zlyab6ez/D QFfUW7bwgcGCkIOZJ0SCiRjwC6rOuLg97iPDGSeB8lndoiS657NKqiE X-Developer-Key: i=jens.glathe@oldschoolsolutions.biz; a=ed25519; pk=JcRJqJc/y8LsxOlPakALD3juGfOKmFBWtO+GfELMJVg= X-Endpoint-Received: by B4 Relay for jens.glathe@oldschoolsolutions.biz/20240919 with auth_id=216 X-Original-From: Jens Glathe Reply-To: jens.glathe@oldschoolsolutions.biz "Microsoft Windows Dev Kit 2023" aka "Blackrock" aka "Project Volterra" Device tree for the Microsoft Windows Dev Kit 2023. This work is based on the initial work of Merck Hung . The Windows Dev Kit 2023 is a nice little desktop based on sc8280xp. Link: https://learn.microsoft.com/en-us/windows/arm/dev-kit/ Supported features: - USB type-c and type-a ports - minidp connector - built-in r8152 Ethernet adapter - PCIe devices - nvme - ath11k WiFi (WCN6855) - WCN6855 Bluetooth - A690 GPU - ADSP and CDSP - GPIO keys - Audio definition (works via USB) Signed-off-by: Jens Glathe Original work: https://github.com/merckhung/linux_ms_dev_kit/blob/ms-dev-kit-2023-v6.3.0/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-dev-kit-2023.dts This dt is more or less deducted from the Thinkpad X13s. It contains a lot of guesswork, and also a lot of research on what works with the Windows Dev Kit. The WiFi definition references qcom,ath11k-calibration-variant = "MS_Volterra" which is unfortunately not yet in the linux-firmware. The ath11k driver finds the default one for "bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2|18,qmi-board-id=255" when the entry with the variant is not found which is quite sub-optimal. I have placed a pr on github/qca-swiss-army-knife: https://github.com/qca/qca-swiss-army-knife/pull/9 that provides an amended board-2.bin and a board-2.json to generate it. pcie2 (nvme) is intentionally specified as max-link-speed = <4>. The interface is capable of it, most current nvme ssds are capable of it, but the physical slot isn't. This leads to a silent downgrade to <3> instead of the "device is limited by bus, capable of..." message. It is in use and under development since May 2023, pretty stable now. --- Changes in v6: - added missing acked-by tag from Krzysztof - removed aspm-no-l0s from the PCIe ports as suggested by Johan - corrected max-link-speed to <4> on PCIe2 as suggested by Johan - changed WLAN variant description to "MS_Volterra", added Kalle Valo for approval / guidance - trimmed the supply statements on hsphy and other pcie ports for what is known and defined on the Thinkpad X13s - Link to v5: https://lore.kernel.org/r/20241030-jg-blackrock-for-upstream-v5-0-830c938437ad@oldschoolsolutions.biz Changes in v5: - removed s-o-b from Merck Hung as suggested by Bjorn Andersson. The credits for the original work are in the cover letter and in the dts commit - removed Venus codec from the list of supported features. It is, but that part is not in this patch set. - Link to v4: https://lore.kernel.org/r/20241027-jg-blackrock-for-upstream-v4-0-703b254fc95f@oldschoolsolutions.biz Changes in v4: - removed the redundant regulator definitions - changed the pinctrl property order - use microsoft instead of MICROSOFT as subdirectory and device name component - amend spacing in audio nodes - change external connector dp1 for mini-dp to DP-3 for consistency - Link to v3: https://lore.kernel.org/r/20241013-jg-blackrock-for-upstream-v3-0-839d3483a8e7@oldschoolsolutions.biz Changes in v3: - tried to heed all advice and comments given - thank you - re-ordered patches to definition before use - added "microsoft,blackrock" as compatible in QSEECOM driver - removed the qseecom node - ordered nodes alphabetically {address, node name, label} - amended indentation - consistently used blackrock as identifier / directory name - sorted identifiers by the same order for multiple instances - added some explanation re WiFi - added definition for PMU on the WCN6855 - added some explanation for pcie2 max-link-speed - Link to v2: https://lore.kernel.org/r/20240920-jg-blackrock-for-upstream-v2-0-9bf2f1b2191c@oldschoolsolutions.biz Changes in v2: - removed whitespaces and breaks - added compatibility binding - added feature list - reformatted Signed-off list - Link to v1: https://lore.kernel.org/r/5f5487e1-e458-4a3a-af02-c52e50ca1964@oldschoolsolutions.biz --- Jens Glathe (3): dt-bindings: arm: qcom: Add Microsoft Windows Dev Kit 2023 firmware: qcom: scm: Allow QSEECOM for Windows Dev Kit 2023 arm64: dts: qcom: sc8280xp-blackrock: dt definition for WDK2023 Documentation/devicetree/bindings/arm/qcom.yaml | 1 + arch/arm64/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/sc8280xp-microsoft-blackrock.dts | 1373 ++++++++++++++++++++ drivers/firmware/qcom/qcom_scm.c | 1 + 4 files changed, 1376 insertions(+) --- base-commit: 6fb2fa9805c501d9ade047fc511961f3273cdcb5 change-id: 20240920-jg-blackrock-for-upstream-7c7aca20e832 Best regards,