mbox series

[v5,0/2] coresight: Add label sysfs node support

Message ID 20241210122253.31926-1-quic_jinlmao@quicinc.com (mailing list archive)
Headers show
Series coresight: Add label sysfs node support | expand

Message

Jinlong Mao Dec. 10, 2024, 12:22 p.m. UTC
With current design, the name of the non-cpu bounded coresight
component is the device type with the number. And with 'ls' command
we can get the register address of the component. But from these
information, we can't know what the HW or system the component belongs
to. Add label in DT and show the hw information by reading label sysfs
node.

cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2

/sys/bus/coresight/devices # cat cti*/label
cti_dlct_0
cti_dlct_1
cti_apss_0
cti_apss_1
cti_apss_2

Change since V4:
1. Add label in DT and add label sysfs node for each coresight device. 

Change since V3:
1. Change device-name to arm,cs-dev-name.
2. Add arm,cs-dev-name to only CTI and sources' dt-binding.

Change since V2:
1. Fix the error in coresight core.
drivers/hwtracing/coresight/coresight-core.c:1775:7: error: assigning to 'char *' from 'const char *' discards qualifiers

2. Fix the warning when run dtbinding check.
Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml: device-name: missing type definition

Change since V1:
1. Change coresight-name to device name.
2. Add the device-name in coresight dt bindings.

Mao Jinlong (2):
  dt-bindings: arm: Add label in the coresight components
  coresight: Add label sysfs node support

 .../testing/sysfs-bus-coresight-devices-cti   |  6 ++++
 .../sysfs-bus-coresight-devices-funnel        |  6 ++++
 .../testing/sysfs-bus-coresight-devices-tpdm  |  6 ++++
 .../bindings/arm/arm,coresight-cti.yaml       |  6 ++++
 .../arm/arm,coresight-dummy-sink.yaml         |  6 ++++
 .../arm/arm,coresight-dummy-source.yaml       |  6 ++++
 .../arm/arm,coresight-dynamic-funnel.yaml     |  6 ++++
 .../arm/arm,coresight-dynamic-replicator.yaml |  6 ++++
 .../arm/arm,coresight-static-funnel.yaml      |  6 ++++
 .../arm/arm,coresight-static-replicator.yaml  |  6 ++++
 .../bindings/arm/arm,coresight-tmc.yaml       |  6 ++++
 .../bindings/arm/qcom,coresight-tpda.yaml     |  6 ++++
 .../bindings/arm/qcom,coresight-tpdm.yaml     |  6 ++++
 drivers/hwtracing/coresight/coresight-sysfs.c | 32 +++++++++++++++++++
 14 files changed, 110 insertions(+)

Comments

Krzysztof Kozlowski Dec. 11, 2024, 8:46 a.m. UTC | #1
On Tue, Dec 10, 2024 at 08:22:51PM +0800, Mao Jinlong wrote:
> With current design, the name of the non-cpu bounded coresight
> component is the device type with the number. And with 'ls' command
> we can get the register address of the component. But from these
> information, we can't know what the HW or system the component belongs
> to. Add label in DT and show the hw information by reading label sysfs
> node.
> 
> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
> tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
> tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
> tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2
> 
> /sys/bus/coresight/devices # cat cti*/label
> cti_dlct_0
> cti_dlct_1
> cti_apss_0
> cti_apss_1
> cti_apss_2
> 
> Change since V4:
> 1. Add label in DT and add label sysfs node for each coresight device. 

This is v5, no links to previous versions (I really suggest to start
using b4 if you want to make your process easier for you), no other
changes so subject is obviously the same and looking for this patchset
previous versions gives me 0 results:

https://lore.kernel.org/all/?q=%22coresight%3A+Add+label+sysfs+node+support%22

OK, let's try b4 diff:

b4 diff '20241210122253.31926-1-quic_jinlmao@quicinc.com'
Grabbing thread from lore.kernel.org/all/20241210122253.31926-1-quic_jinlmao@quicinc.com/t.mbox.gz
Checking for older revisions
Grabbing search results from lore.kernel.org
Nothing matching that query.
---
Analyzing 3 messages in the thread
Could not find lower series to compare against.


So how do you expect us to do any meaningful review?

Best regards,
Krzysztof
Jinlong Mao Dec. 11, 2024, 11:13 a.m. UTC | #2
On 2024/12/11 16:46, Krzysztof Kozlowski wrote:
> On Tue, Dec 10, 2024 at 08:22:51PM +0800, Mao Jinlong wrote:
>> With current design, the name of the non-cpu bounded coresight
>> component is the device type with the number. And with 'ls' command
>> we can get the register address of the component. But from these
>> information, we can't know what the HW or system the component belongs
>> to. Add label in DT and show the hw information by reading label sysfs
>> node.
>>
>> cti_sys0 -> ../../../devices/platform/soc@0/138f0000.cti/cti_sys0
>> cti_sys1 -> ../../../devices/platform/soc@0/13900000.cti/cti_sys1
>> tpdm0 -> ../../../devices/platform/soc@0/10b0d000.tpdm/tpdm0
>> tpdm1 -> ../../../devices/platform/soc@0/10c28000.tpdm/tpdm1
>> tpdm2 -> ../../../devices/platform/soc@0/10c29000.tpdm/tpdm2
>>
>> /sys/bus/coresight/devices # cat cti*/label
>> cti_dlct_0
>> cti_dlct_1
>> cti_apss_0
>> cti_apss_1
>> cti_apss_2
>>
>> Change since V4:
>> 1. Add label in DT and add label sysfs node for each coresight device.
> 
> This is v5, no links to previous versions (I really suggest to start
> using b4 if you want to make your process easier for you), no other
> changes so subject is obviously the same and looking for this patchset
> previous versions gives me 0 results:
> 
> https://lore.kernel.org/all/?q=%22coresight%3A+Add+label+sysfs+node+support%22
> 
> OK, let's try b4 diff:
> 
> b4 diff '20241210122253.31926-1-quic_jinlmao@quicinc.com'
> Grabbing thread from lore.kernel.org/all/20241210122253.31926-1-quic_jinlmao@quicinc.com/t.mbox.gz
> Checking for older revisions
> Grabbing search results from lore.kernel.org
> Nothing matching that query.
> ---
> Analyzing 3 messages in the thread
> Could not find lower series to compare against.
> 
> 
> So how do you expect us to do any meaningful review?
> 
> Best regards,
> Krzysztof
I will resend the patches with the links of lower series.

>