Message ID | 20241226-mdssdt_qcs8300-v2-0-acba0db533ce@quicinc.com (mailing list archive) |
---|---|
Headers | show |
Series | Display enablement changes for Qualcomm QCS8300 platform | expand |
On Thu, Dec 26, 2024 at 05:40:44PM +0800, Yongxing Mou wrote: > This series introduces support to enable the Mobile Display Subsystem (MDSS) > , Display Processing Unit (DPU), DisplayPort controller and eDP PHY for > the Qualcomm QCS8300 target. It includes the addition of the hardware catalog, > compatible string, and their YAML bindings. > > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> > --- > This series depends on following series: > https://lore.kernel.org/all/20241203-qcs8300_initial_dtsi-v4-2-d7c953484024@quicinc.com/ Then why this is not part of initial DTSI? > https://lore.kernel.org/all/20241106-qcs8300-mm-patches-v3-0-f611a8f87f15@quicinc.com/ > https://lore.kernel.org/all/20241114-qcs8300-mm-cc-dt-patch-v1-1-7a974508c736@quicinc.com/ > https://lore.kernel.org/all/20241024-defconfig_sa8775p_clock_controllers-v2-1-a9e1cdaed785@quicinc.com/ So it cannot be tested? Way too many dependencies for me to review. Best regards, Krzysztof
On Thu, Dec 26, 2024 at 05:40:44PM +0800, Yongxing Mou wrote: > This series introduces support to enable the Mobile Display Subsystem (MDSS) > , Display Processing Unit (DPU), DisplayPort controller and eDP PHY for > the Qualcomm QCS8300 target. It includes the addition of the hardware catalog, > compatible string, and their YAML bindings. > > Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> > --- > This series depends on following series: > https://lore.kernel.org/all/20241203-qcs8300_initial_dtsi-v4-2-d7c953484024@quicinc.com/ > https://lore.kernel.org/all/20241106-qcs8300-mm-patches-v3-0-f611a8f87f15@quicinc.com/ > https://lore.kernel.org/all/20241114-qcs8300-mm-cc-dt-patch-v1-1-7a974508c736@quicinc.com/ > https://lore.kernel.org/all/20241024-defconfig_sa8775p_clock_controllers-v2-1-a9e1cdaed785@quicinc.com/ How does it depend on all those series? Does it have any intersection point at all? You should have decoupled all bindings from those series. If you did, please update your cover letter. If you didn't, please do your home work. > --- > Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob. > - Decouple the devicetree changes from this series.[Dmitry][Krzysztof] > - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry] > - Fix compilation issues in MDSS bindings.[Rob][Krzysztof] > - Correct formatting errors and remove unnecessary status in MDSS > bindings.[Krzysztof] > - Add the the necessary information in MDSS changes commit msg.[Dmitry] > - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/ > 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry] > - Package the DisplayPort controller and eDP PHY bindings document to > this patch series. > - Collecting MDSS changes reviewd-by Dmitry. > - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry] > - Reuse the sm8650 DP controller as a fallback compat.[Dmitry] > - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com > ~ > > --- > Yongxing Mou (5): > dt-bindings: display/msm: Document the DPU for QCS8300 > dt-bindings: display: msm: dp-controller: document QCS8300 compatible > dt-bindings: display/msm: Document MDSS on QCS8300 > dt-bindings: phy: Add eDP PHY compatible for QCS8300 > drm/msm: mdss: Add QCS8300 support > > .../bindings/display/msm/dp-controller.yaml | 4 + > .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 244 +++++++++++++++++++++ > .../bindings/display/msm/qcom,sm8650-dpu.yaml | 13 +- > .../devicetree/bindings/phy/qcom,edp-phy.yaml | 19 +- > drivers/gpu/drm/msm/msm_mdss.c | 11 + > 5 files changed, 280 insertions(+), 11 deletions(-) > --- > base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 > change-id: 20241224-mdssdt_qcs8300-11b7883dc60b > prerequisite-message-id: <20241203-qcs8300_initial_dtsi-v4-2-d7c953484024@quicinc.com> > prerequisite-patch-id: 33f2488a8eb133431f200e17aac743598508dcf3 > prerequisite-patch-id: 7b653ebeaf1ca3f87620ccf7d876e3d1fe496c4a > prerequisite-patch-id: e1b60af8a64332e5f0ecbd3a4ea2b6e090bd97cf > prerequisite-patch-id: b823d744d2fb302e2496eaf0cf0c9c66312dcf2a > prerequisite-message-id: <20241106-qcs8300-mm-patches-v3-0-f611a8f87f15@quicinc.com> > prerequisite-patch-id: 367d9c742fe5087cfa6fb8e7b05ebe9bc78d68f3 > prerequisite-patch-id: ee0513c070ab96e63766d235b38ee53ca9b19181 > prerequisite-patch-id: 970974160bcdc837ccbe5ea3b5dcac582e90bc0d > prerequisite-patch-id: 5b2bd9cc44a529b0b9e5d73128dca5d2ff9f2f44 > prerequisite-patch-id: 6a0a81242e1d0f051e3102533bf0191615c6e96b > prerequisite-patch-id: 322540ce6d45c32f813ecef50e5135c6f08d9019 > prerequisite-message-id: <20241114-qcs8300-mm-cc-dt-patch-v1-1-7a974508c736@quicinc.com> > prerequisite-patch-id: 8faad5c6d8ca255935d3e4d317dcbcc32b8261ff > prerequisite-message-id: <20241024-defconfig_sa8775p_clock_controllers-v2-1-a9e1cdaed785@quicinc.com> > prerequisite-patch-id: 81378ec66ab6e569bd828401c43c4f5af55db32c > > Best regards, > -- > Yongxing Mou <quic_yongmou@quicinc.com> >
This series introduces support to enable the Mobile Display Subsystem (MDSS) , Display Processing Unit (DPU), DisplayPort controller and eDP PHY for the Qualcomm QCS8300 target. It includes the addition of the hardware catalog, compatible string, and their YAML bindings. Signed-off-by: Yongxing Mou <quic_yongmou@quicinc.com> --- This series depends on following series: https://lore.kernel.org/all/20241203-qcs8300_initial_dtsi-v4-2-d7c953484024@quicinc.com/ https://lore.kernel.org/all/20241106-qcs8300-mm-patches-v3-0-f611a8f87f15@quicinc.com/ https://lore.kernel.org/all/20241114-qcs8300-mm-cc-dt-patch-v1-1-7a974508c736@quicinc.com/ https://lore.kernel.org/all/20241024-defconfig_sa8775p_clock_controllers-v2-1-a9e1cdaed785@quicinc.com/ --- Changes in v2:Fixed review comments from Krzysztof, Dmitry, Rob. - Decouple the devicetree changes from this series.[Dmitry][Krzysztof] - Drop the dpu driver changes and reuse SA8775P DPU driver.[Dmitry] - Fix compilation issues in MDSS bindings.[Rob][Krzysztof] - Correct formatting errors and remove unnecessary status in MDSS bindings.[Krzysztof] - Add the the necessary information in MDSS changes commit msg.[Dmitry] - Rebase MDSS driver changes to https://lore.kernel.org/dri-devel/ 20241127-msm-mdss-ubwc-v3-0-9782a7c2b023@linaro.org/.[Dmitry] - Package the DisplayPort controller and eDP PHY bindings document to this patch series. - Collecting MDSS changes reviewd-by Dmitry. - Reuse the sa8775p eDP PHY as a fallback compat.[Dmitry] - Reuse the sm8650 DP controller as a fallback compat.[Dmitry] - Link to v1: https://lore.kernel.org/r/20241127-mdss_qcs8300-v1-0-29b2c3ee95b8@quicinc.com ~ --- Yongxing Mou (5): dt-bindings: display/msm: Document the DPU for QCS8300 dt-bindings: display: msm: dp-controller: document QCS8300 compatible dt-bindings: display/msm: Document MDSS on QCS8300 dt-bindings: phy: Add eDP PHY compatible for QCS8300 drm/msm: mdss: Add QCS8300 support .../bindings/display/msm/dp-controller.yaml | 4 + .../bindings/display/msm/qcom,qcs8300-mdss.yaml | 244 +++++++++++++++++++++ .../bindings/display/msm/qcom,sm8650-dpu.yaml | 13 +- .../devicetree/bindings/phy/qcom,edp-phy.yaml | 19 +- drivers/gpu/drm/msm/msm_mdss.c | 11 + 5 files changed, 280 insertions(+), 11 deletions(-) --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241224-mdssdt_qcs8300-11b7883dc60b prerequisite-message-id: <20241203-qcs8300_initial_dtsi-v4-2-d7c953484024@quicinc.com> prerequisite-patch-id: 33f2488a8eb133431f200e17aac743598508dcf3 prerequisite-patch-id: 7b653ebeaf1ca3f87620ccf7d876e3d1fe496c4a prerequisite-patch-id: e1b60af8a64332e5f0ecbd3a4ea2b6e090bd97cf prerequisite-patch-id: b823d744d2fb302e2496eaf0cf0c9c66312dcf2a prerequisite-message-id: <20241106-qcs8300-mm-patches-v3-0-f611a8f87f15@quicinc.com> prerequisite-patch-id: 367d9c742fe5087cfa6fb8e7b05ebe9bc78d68f3 prerequisite-patch-id: ee0513c070ab96e63766d235b38ee53ca9b19181 prerequisite-patch-id: 970974160bcdc837ccbe5ea3b5dcac582e90bc0d prerequisite-patch-id: 5b2bd9cc44a529b0b9e5d73128dca5d2ff9f2f44 prerequisite-patch-id: 6a0a81242e1d0f051e3102533bf0191615c6e96b prerequisite-patch-id: 322540ce6d45c32f813ecef50e5135c6f08d9019 prerequisite-message-id: <20241114-qcs8300-mm-cc-dt-patch-v1-1-7a974508c736@quicinc.com> prerequisite-patch-id: 8faad5c6d8ca255935d3e4d317dcbcc32b8261ff prerequisite-message-id: <20241024-defconfig_sa8775p_clock_controllers-v2-1-a9e1cdaed785@quicinc.com> prerequisite-patch-id: 81378ec66ab6e569bd828401c43c4f5af55db32c Best regards,