mbox series

[0/3] coresight: Alloc trace ID after building the path

Message ID 20250131163617.1730505-1-james.clark@linaro.org (mailing list archive)
Headers show
Series coresight: Alloc trace ID after building the path | expand

Message

James Clark Jan. 31, 2025, 4:36 p.m. UTC
Proof of concept to support CTCU device. Applies to Jie's patchset in
the parent email. I think this would be a good simplification, it
removes some code and makes things a bit clearer, and works for both the
old and new CTCU requirements. It will require merging into the parent
patchset somehow as it undoes some of those changes.

James Clark (3):
  coresight: Don't save handle in path
  coresight: Export coresight_get_sink()
  coresight: Alloc trace ID after building the path

 drivers/hwtracing/coresight/coresight-core.c  | 107 +++++++++++++-----
 drivers/hwtracing/coresight/coresight-dummy.c |   9 +-
 drivers/hwtracing/coresight/coresight-etb10.c |   8 +-
 .../hwtracing/coresight/coresight-etm-perf.c  |  20 ++--
 drivers/hwtracing/coresight/coresight-etm.h   |   1 -
 .../coresight/coresight-etm3x-core.c          |  84 ++------------
 .../coresight/coresight-etm3x-sysfs.c         |   3 +-
 .../coresight/coresight-etm4x-core.c          |  83 ++------------
 .../coresight/coresight-etm4x-sysfs.c         |   4 +-
 drivers/hwtracing/coresight/coresight-etm4x.h |   1 -
 drivers/hwtracing/coresight/coresight-priv.h  |  17 +--
 drivers/hwtracing/coresight/coresight-stm.c   |   5 +-
 drivers/hwtracing/coresight/coresight-sysfs.c |   6 +-
 .../hwtracing/coresight/coresight-tmc-etf.c   |   9 +-
 .../hwtracing/coresight/coresight-tmc-etr.c   |  13 +--
 drivers/hwtracing/coresight/coresight-tmc.h   |   2 +-
 drivers/hwtracing/coresight/coresight-tpda.c  |   3 +-
 drivers/hwtracing/coresight/coresight-tpdm.c  |   3 +-
 drivers/hwtracing/coresight/coresight-tpiu.c  |   2 +-
 drivers/hwtracing/coresight/coresight-trbe.c  |   4 +-
 drivers/hwtracing/coresight/ultrasoc-smb.c    |   8 +-
 include/linux/coresight.h                     |  25 +++-
 22 files changed, 159 insertions(+), 258 deletions(-)

Comments

Jie Gan Feb. 5, 2025, 4:13 a.m. UTC | #1
On 2/1/2025 12:36 AM, James Clark wrote:
> Proof of concept to support CTCU device. Applies to Jie's patchset in
> the parent email. I think this would be a good simplification, it
> removes some code and makes things a bit clearer, and works for both the
> old and new CTCU requirements. It will require merging into the parent
> patchset somehow as it undoes some of those changes.
Hi, James

I tested the patch series and it works well.

Can I combine these patchsets with mine with co-developed tag?
Or are you prefer to submit them independently?

I believe it would be easier to read if we combined the codes together.

Thanks,
Jie

> 
> James Clark (3):
>    coresight: Don't save handle in path
>    coresight: Export coresight_get_sink()
>    coresight: Alloc trace ID after building the path
> 
>   drivers/hwtracing/coresight/coresight-core.c  | 107 +++++++++++++-----
>   drivers/hwtracing/coresight/coresight-dummy.c |   9 +-
>   drivers/hwtracing/coresight/coresight-etb10.c |   8 +-
>   .../hwtracing/coresight/coresight-etm-perf.c  |  20 ++--
>   drivers/hwtracing/coresight/coresight-etm.h   |   1 -
>   .../coresight/coresight-etm3x-core.c          |  84 ++------------
>   .../coresight/coresight-etm3x-sysfs.c         |   3 +-
>   .../coresight/coresight-etm4x-core.c          |  83 ++------------
>   .../coresight/coresight-etm4x-sysfs.c         |   4 +-
>   drivers/hwtracing/coresight/coresight-etm4x.h |   1 -
>   drivers/hwtracing/coresight/coresight-priv.h  |  17 +--
>   drivers/hwtracing/coresight/coresight-stm.c   |   5 +-
>   drivers/hwtracing/coresight/coresight-sysfs.c |   6 +-
>   .../hwtracing/coresight/coresight-tmc-etf.c   |   9 +-
>   .../hwtracing/coresight/coresight-tmc-etr.c   |  13 +--
>   drivers/hwtracing/coresight/coresight-tmc.h   |   2 +-
>   drivers/hwtracing/coresight/coresight-tpda.c  |   3 +-
>   drivers/hwtracing/coresight/coresight-tpdm.c  |   3 +-
>   drivers/hwtracing/coresight/coresight-tpiu.c  |   2 +-
>   drivers/hwtracing/coresight/coresight-trbe.c  |   4 +-
>   drivers/hwtracing/coresight/ultrasoc-smb.c    |   8 +-
>   include/linux/coresight.h                     |  25 +++-
>   22 files changed, 159 insertions(+), 258 deletions(-)
>
Jie Gan Feb. 5, 2025, 7:44 a.m. UTC | #2
On 2/5/2025 12:13 PM, Jie Gan wrote:
> 
> 
> On 2/1/2025 12:36 AM, James Clark wrote:
>> Proof of concept to support CTCU device. Applies to Jie's patchset in
>> the parent email. I think this would be a good simplification, it
>> removes some code and makes things a bit clearer, and works for both the
>> old and new CTCU requirements. It will require merging into the parent
>> patchset somehow as it undoes some of those changes.
> Hi, James
> 
> I tested the patch series and it works well.
> 
> Can I combine these patchsets with mine with co-developed tag?
> Or are you prefer to submit them independently?
> 
> I believe it would be easier to read if we combined the codes together.

Hi, James

Please ignore my questions here. I missed the last paragraph of the 
description.

I merged your codes with mine and added co-developed and SOB tag.

Sorry for the mistake.

Thanks,
Jie

> 
>>
>> James Clark (3):
>>    coresight: Don't save handle in path
>>    coresight: Export coresight_get_sink()
>>    coresight: Alloc trace ID after building the path
>>
>>   drivers/hwtracing/coresight/coresight-core.c  | 107 +++++++++++++-----
>>   drivers/hwtracing/coresight/coresight-dummy.c |   9 +-
>>   drivers/hwtracing/coresight/coresight-etb10.c |   8 +-
>>   .../hwtracing/coresight/coresight-etm-perf.c  |  20 ++--
>>   drivers/hwtracing/coresight/coresight-etm.h   |   1 -
>>   .../coresight/coresight-etm3x-core.c          |  84 ++------------
>>   .../coresight/coresight-etm3x-sysfs.c         |   3 +-
>>   .../coresight/coresight-etm4x-core.c          |  83 ++------------
>>   .../coresight/coresight-etm4x-sysfs.c         |   4 +-
>>   drivers/hwtracing/coresight/coresight-etm4x.h |   1 -
>>   drivers/hwtracing/coresight/coresight-priv.h  |  17 +--
>>   drivers/hwtracing/coresight/coresight-stm.c   |   5 +-
>>   drivers/hwtracing/coresight/coresight-sysfs.c |   6 +-
>>   .../hwtracing/coresight/coresight-tmc-etf.c   |   9 +-
>>   .../hwtracing/coresight/coresight-tmc-etr.c   |  13 +--
>>   drivers/hwtracing/coresight/coresight-tmc.h   |   2 +-
>>   drivers/hwtracing/coresight/coresight-tpda.c  |   3 +-
>>   drivers/hwtracing/coresight/coresight-tpdm.c  |   3 +-
>>   drivers/hwtracing/coresight/coresight-tpiu.c  |   2 +-
>>   drivers/hwtracing/coresight/coresight-trbe.c  |   4 +-
>>   drivers/hwtracing/coresight/ultrasoc-smb.c    |   8 +-
>>   include/linux/coresight.h                     |  25 +++-
>>   22 files changed, 159 insertions(+), 258 deletions(-)
>>
> 
>