diff mbox series

arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

Message ID 0101016ed035d185-20f04863-0f38-41b7-b88d-76bc36e4dcf9-000000@us-west-2.amazonses.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi | expand

Commit Message

Rakesh Pillai Dec. 4, 2019, 9:20 a.m. UTC
The MSA memory is at a fixed offset, which will be
a part of reserved memory. Add this flag to indicate
that wifi in sc7180 will use a fixed memory for MSA.

Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
---
This patchet is dependent on the below changes
arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)
dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
---
 arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Matthias Kaehlcke Dec. 5, 2019, 12:56 a.m. UTC | #1
On Wed, Dec 04, 2019 at 09:20:18AM +0000, Rakesh Pillai wrote:

> arm64: dts: qcom: sc7180: Make MSA memory fixed for wifi

This is not really done for sc7180, but only for the sc7180-idp,
which should be reflected in the subject (i.e. s/sc7180/sc7180-idp/)

> The MSA memory is at a fixed offset, which will be
> a part of reserved memory. Add this flag to indicate
> that wifi in sc7180 will use a fixed memory for MSA.

ditto, say it's the IDP

> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> This patchet is dependent on the below changes
> arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)
> dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
> ---
>  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 8a6a760..b2ca143f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -250,6 +250,7 @@
>  
>  &wifi {
>  	status = "okay";
> +	qcom,msa_fixed_perm;
>  };
>  
>  /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> -- 
> 2.7.4
>
Bjorn Andersson Dec. 11, 2019, 7:53 a.m. UTC | #2
On Wed 04 Dec 01:20 PST 2019, Rakesh Pillai wrote:

> The MSA memory is at a fixed offset, which will be
> a part of reserved memory. Add this flag to indicate
> that wifi in sc7180 will use a fixed memory for MSA.
> 
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> This patchet is dependent on the below changes
> arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node (https://lore.kernel.org/patchwork/patch/1162434/)

As mentioned for that patch, squash this change into that patch please.

Regards,
Bjorn

> dt: bindings: add dt entry flag to skip SCM call for msa region (https://patchwork.ozlabs.org/patch/1192725/)
> ---
>  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 8a6a760..b2ca143f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -250,6 +250,7 @@
>  
>  &wifi {
>  	status = "okay";
> +	qcom,msa_fixed_perm;
>  };
>  
>  /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> -- 
> 2.7.4
>
Rakesh Pillai Dec. 19, 2019, 7:46 a.m. UTC | #3
Sure Bjorn.
I have sent v2 for the patch "arm64: dts: qcom: sc7180: Add WCN3990 WLAN
module device node", where I have squashed this change as well.

Thanks,
Rakesh.

> -----Original Message-----
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
> Sent: Wednesday, December 11, 2019 1:23 PM
> To: Rakesh Pillai <pillair@codeaurora.org>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
linux-
> kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org
> Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Make MSA memory fixed for
> wifi
> 
> On Wed 04 Dec 01:20 PST 2019, Rakesh Pillai wrote:
> 
> > The MSA memory is at a fixed offset, which will be
> > a part of reserved memory. Add this flag to indicate
> > that wifi in sc7180 will use a fixed memory for MSA.
> >
> > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> > ---
> > This patchet is dependent on the below changes
> > arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
> (https://lore.kernel.org/patchwork/patch/1162434/)
> 
> As mentioned for that patch, squash this change into that patch please.
> 
> Regards,
> Bjorn
> 
> > dt: bindings: add dt entry flag to skip SCM call for msa region
> (https://patchwork.ozlabs.org/patch/1192725/)
> > ---
> >  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 8a6a760..b2ca143f 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -250,6 +250,7 @@
> >
> >  &wifi {
> >  	status = "okay";
> > +	qcom,msa_fixed_perm;
> >  };
> >
> >  /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> > --
> > 2.7.4
> >
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 8a6a760..b2ca143f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -250,6 +250,7 @@ 
 
 &wifi {
 	status = "okay";
+	qcom,msa_fixed_perm;
 };
 
 /* PINCTRL - additions to nodes defined in sc7180.dtsi */