From patchwork Sun Jun 1 13:38:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4278411 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CB8B6BEEA7 for ; Sun, 1 Jun 2014 13:38:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 189F4202E5 for ; Sun, 1 Jun 2014 13:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4988320272 for ; Sun, 1 Jun 2014 13:38:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757807AbaFANhf (ORCPT ); Sun, 1 Jun 2014 09:37:35 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:63506 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757793AbaFANhc (ORCPT ); Sun, 1 Jun 2014 09:37:32 -0400 Received: by mail-la0-f43.google.com with SMTP id mc6so1977022lab.2 for ; Sun, 01 Jun 2014 06:37:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=39uKpl3zT520vt00bgb7bjhiS748dW1MDc+RgIeGJck=; b=H1WUpqbzt/z7Z5tITCuXsNy4DJWquD9ayg6VoJLXEWN8BpsceLZgXZJN15nYxuj2wj /VyaCTv5nULJeEem6G7+uHEAT+V6GXp6cIHp+m8Nb+rbd1cZqERU/3PaBUZH0OkOJ5I6 wH+utekWOAzhapkFvj6iKWx008vIwUOSj01PYOY5d8fIpBUNij1R37at/b1RZGkkKaMg BnUfG2JBW7Xt+XpNl9P1EU74MNkOwHhn4mCcgC1K3hy1cyBHExsKd5VbR1pje289zeF3 A8XOlotetKsQf9Y+vJ/JUHztTLEnWUaSlDaF+mjUAVCGCzVW9tLK7x63EeGqGZnYqq1X lJ4g== X-Gm-Message-State: ALoCoQnCcURWLEr64F5ire7+c+joBxXCjuU6W1LDsUV/Rb50lIO9f9oN1g/YHqLTT8CeHWA69ltn X-Received: by 10.152.5.4 with SMTP id o4mr1842643lao.64.1401629850717; Sun, 01 Jun 2014 06:37:30 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id o17sm8565329lal.21.2014.06.01.06.37.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Jun 2014 06:37:29 -0700 (PDT) From: Rickard Strandqvist To: David Brown , Daniel Walker Cc: Rickard Strandqvist , Bryan Huntsman , Greg Kroah-Hartman , Jiri Slaby , Grant Likely , Rob Herring , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables Date: Sun, 1 Jun 2014 15:38:24 +0200 Message-Id: <1401629904-19492-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/tty/serial/msm_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c index 053b98e..c67f5c5 100644 --- a/drivers/tty/serial/msm_serial.c +++ b/drivers/tty/serial/msm_serial.c @@ -962,7 +962,7 @@ static int __init msm_console_setup(struct console *co, char *options) { struct uart_port *port; struct msm_port *msm_port; - int baud, flow, bits, parity; + int baud = 0, flow, bits, parity; if (unlikely(co->index >= UART_NR || co->index < 0)) return -ENXIO;