| Message ID | 1409299909-5128-1-git-send-email-pramod.gurav@smartplayin.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > This patch releases gpiochip related resources by calling > gpiochip_remove when either of gpiochip_add_pin_range and > gpiochip_irqchip_add fails. > > CC: Linus Walleij <linus.walleij@linaro.org> > CC: Bjorn Andersson <bjorn.andersson@sonymobile.com> > CC: "Ivan T. Ivanov" <iivanov@mm-sol.com> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > --- > > Changes since v1: > - In v1 of this patch gpiochip_remove was called only in failure case of > gpiochip_irqchip_add. This patchs adds a call to gpiochip_remove in failure > case of gpiochip_add_pin_range as well. > > drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 2738108..9175bbc 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -829,6 +829,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > ret = gpiochip_add_pin_range(&pctrl->chip, dev_name(pctrl->dev), 0, 0, chip->ngpio); > if (ret) { > dev_err(pctrl->dev, "Failed to add pin range\n"); > + gpiochip_remove(&pctrl->chip); > return ret; > } > > @@ -839,6 +840,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > IRQ_TYPE_NONE); > if (ret) { > dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n"); > + gpiochip_remove(&pctrl->chip); > return -ENOSYS; > } > It seems like pinctrl-st.c and pinctrl-sirf.c is suffering the same problem, would you mind spinning patches for those too? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bjorn, On 30-08-2014 12:27 AM, Bjorn Andersson wrote: > On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > >> This patch releases gpiochip related resources by calling >> gpiochip_remove when either of gpiochip_add_pin_range and >> gpiochip_irqchip_add fails. >> >> CC: Linus Walleij <linus.walleij@linaro.org> >> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com> >> CC: "Ivan T. Ivanov" <iivanov@mm-sol.com> >> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > > Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > >> --- >> >> Changes since v1: >> - In v1 of this patch gpiochip_remove was called only in failure case of >> gpiochip_irqchip_add. This patchs adds a call to gpiochip_remove in failure >> case of gpiochip_add_pin_range as well. >> >> drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c >> index 2738108..9175bbc 100644 >> --- a/drivers/pinctrl/qcom/pinctrl-msm.c >> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c >> @@ -829,6 +829,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) >> ret = gpiochip_add_pin_range(&pctrl->chip, dev_name(pctrl->dev), 0, 0, chip->ngpio); >> if (ret) { >> dev_err(pctrl->dev, "Failed to add pin range\n"); >> + gpiochip_remove(&pctrl->chip); >> return ret; >> } >> >> @@ -839,6 +840,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) >> IRQ_TYPE_NONE); >> if (ret) { >> dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n"); >> + gpiochip_remove(&pctrl->chip); >> return -ENOSYS; >> } >> > > It seems like pinctrl-st.c and pinctrl-sirf.c is suffering the same problem, > would you mind spinning patches for those too? Sure. Was browsing files but I was caught by this thing called sleep before I catch anything. :) Thanks for pointing them out. Will do it. > > Regards, > Bjorn > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bjorn, On 30-08-2014 12:27 AM, Bjorn Andersson wrote: > On Fri 29 Aug 01:11 PDT 2014, Pramod Gurav wrote: > >> This patch releases gpiochip related resources by calling >> gpiochip_remove when either of gpiochip_add_pin_range and >> gpiochip_irqchip_add fails. >> >> CC: Linus Walleij <linus.walleij@linaro.org> >> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com> >> CC: "Ivan T. Ivanov" <iivanov@mm-sol.com> >> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > > Acked-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > <..> > > It seems like pinctrl-st.c and pinctrl-sirf.c is suffering the same problem, > would you mind spinning patches for those too? Sure. Was browsing files but I was caught by this thing called sleep before I catch anything. :) Thanks for pointing them out. Will do it. > > Regards, > Bjorn > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 29, 2014 at 10:11 AM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: > This patch releases gpiochip related resources by calling > gpiochip_remove when either of gpiochip_add_pin_range and > gpiochip_irqchip_add fails. > > CC: Linus Walleij <linus.walleij@linaro.org> > CC: Bjorn Andersson <bjorn.andersson@sonymobile.com> > CC: "Ivan T. Ivanov" <iivanov@mm-sol.com> > Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> > --- > > Changes since v1: > - In v1 of this patch gpiochip_remove was called only in failure case of > gpiochip_irqchip_add. This patchs adds a call to gpiochip_remove in failure > case of gpiochip_add_pin_range as well. Patch applied with Björn's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index 2738108..9175bbc 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -829,6 +829,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) ret = gpiochip_add_pin_range(&pctrl->chip, dev_name(pctrl->dev), 0, 0, chip->ngpio); if (ret) { dev_err(pctrl->dev, "Failed to add pin range\n"); + gpiochip_remove(&pctrl->chip); return ret; } @@ -839,6 +840,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) IRQ_TYPE_NONE); if (ret) { dev_err(pctrl->dev, "Failed to add irqchip to gpiochip\n"); + gpiochip_remove(&pctrl->chip); return -ENOSYS; }
This patch releases gpiochip related resources by calling gpiochip_remove when either of gpiochip_add_pin_range and gpiochip_irqchip_add fails. CC: Linus Walleij <linus.walleij@linaro.org> CC: Bjorn Andersson <bjorn.andersson@sonymobile.com> CC: "Ivan T. Ivanov" <iivanov@mm-sol.com> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com> --- Changes since v1: - In v1 of this patch gpiochip_remove was called only in failure case of gpiochip_irqchip_add. This patchs adds a call to gpiochip_remove in failure case of gpiochip_add_pin_range as well. drivers/pinctrl/qcom/pinctrl-msm.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)