| Message ID | 1416423169-21865-8-git-send-email-kwestfie@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, Nov 19, 2014 at 10:52:47AM -0800, Kenneth Westfield wrote: > +++ b/sound/soc/qcom/Kconfig > @@ -0,0 +1,43 @@ > +# > +# Copyright (c) 2013-2014 The Linux Foundation. All rights reserved. Is there some kind of copyright assignment on file or something? It's weird to have someone else without obvious authorship own the copyright... > +# Permission to use, copy, modify, and/or distribute this software for any > +# purpose with or without fee is hereby granted, provided that the above > +# copyright notice and this permission notice appear in all copies. > +# > +# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES > +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF > +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR > +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES > +# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN > +# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF > +# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. Please just license the file under the GPL, all the drivers that get built from here are GPLed - I can't see any reason for this to have an odd license. > +config SND_SOC_QCOM > + bool "SoC Audio support for QCOM platforms" > + help > + Support for audio in Qualcomm Technologies SOC-based systems. > + Say Y if you want to use audio devices that will run on IPQ806x and similar SOCs. > + I'd expect this to be the first thing in the file not the last. Why are things in here bools, shouldn't they be tristates? > index 0000000000000000000000000000000000000000..0a74177df75f7aa5f7fbaab35da9b92689fa3d6a > --- /dev/null > +++ b/sound/soc/qcom/Makefile > @@ -0,0 +1,11 @@ > +#QCOM SOUNDCARDS > + This appears to be CPU drivers as well as sound cards (as you'd expect for machine drivers) so the comment isn't quite right - just remove it.
On 11/25/2014 02:07 PM, Mark Brown wrote: > On Wed, Nov 19, 2014 at 10:52:47AM -0800, Kenneth Westfield wrote: > >> +++ b/sound/soc/qcom/Kconfig >> @@ -0,0 +1,43 @@ ... >> +# Permission to use, copy, modify, and/or distribute this software for any >> +# purpose with or without fee is hereby granted, provided that the above >> +# copyright notice and this permission notice appear in all copies. >> +# >> +# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES >> +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF >> +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR >> +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES >> +# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN >> +# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF >> +# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > > Please just license the file under the GPL, all the drivers that get > built from here are GPLed - I can't see any reason for this to have an > odd license. Why is there even a license blurb here? Just drop it. - Bryan
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig new file mode 100644 index 0000000000000000000000000000000000000000..00cbdf8b29e68d32154a854a8bbfe2ac13b8b985 --- /dev/null +++ b/sound/soc/qcom/Kconfig @@ -0,0 +1,43 @@ +# +# Copyright (c) 2013-2014 The Linux Foundation. All rights reserved. +# +# Permission to use, copy, modify, and/or distribute this software for any +# purpose with or without fee is hereby granted, provided that the above +# copyright notice and this permission notice appear in all copies. +# +# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES +# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN +# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF +# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. + +config SND_SOC_CPU_DAI + bool + depends on SND_SOC_QCOM + +config SND_SOC_IPQ806X + bool "SoC Audio support for IPQ806x based platforms" + depends on SND_SOC_QCOM || ARCH_QCOM + select SND_SOC_PCM_I2S + select SND_SOC_CPU_DAI + select SND_SOC_LPAIF + help + Support for Qualcomm Technologies LPASS audio block in IPQ806X SOC-based systems. + Say Y if you want to use audio devices that will run on these boards. + +config SND_SOC_LPAIF + bool + depends on SND_SOC_QCOM + +config SND_SOC_PCM_I2S + bool + depends on SND_SOC_QCOM + +config SND_SOC_QCOM + bool "SoC Audio support for QCOM platforms" + help + Support for audio in Qualcomm Technologies SOC-based systems. + Say Y if you want to use audio devices that will run on IPQ806x and similar SOCs. + diff --git a/sound/soc/qcom/Makefile b/sound/soc/qcom/Makefile new file mode 100644 index 0000000000000000000000000000000000000000..0a74177df75f7aa5f7fbaab35da9b92689fa3d6a --- /dev/null +++ b/sound/soc/qcom/Makefile @@ -0,0 +1,11 @@ +#QCOM SOUNDCARDS + +snd-soc-ipq806x-objs := ipq806x.o +snd-soc-lpass-pcm-mi2s-objs := lpass-pcm-mi2s.o +snd-soc-lpass-cpu-dai-objs := lpass-cpu-dai.o +snd-soc-lpass-lpaif-objs := lpass-lpaif.o + +obj-$(CONFIG_SND_SOC_IPQ806X) += snd-soc-ipq806x.o +obj-$(CONFIG_SND_SOC_PCM_I2S) += snd-soc-lpass-pcm-mi2s.o +obj-$(CONFIG_SND_SOC_CPU_DAI) += snd-soc-lpass-cpu-dai.o +obj-$(CONFIG_SND_SOC_LPAIF) += snd-soc-lpass-lpaif.o