diff mbox

regulator: qcom-rpm: Make it possible to specify supply

Message ID 1422577377-31986-1-git-send-email-bjorn.andersson@sonymobile.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bjorn Andersson Jan. 30, 2015, 12:22 a.m. UTC
Make it possible to specify the supply of a regulator, through the
vin-supply property in dt.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---
 drivers/regulator/qcom_rpm-regulator.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Srinivas Kandagatla Jan. 30, 2015, 8:57 a.m. UTC | #1
Hi Bjorn,
Thanks for sending this patch.. I almost forgot about this.

Shouldn’t we update the DT Bindings with this info?

Other than that:
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

--srini

On 30/01/15 00:22, Bjorn Andersson wrote:
> Make it possible to specify the supply of a regulator, through the
> vin-supply property in dt.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>   drivers/regulator/qcom_rpm-regulator.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index e3120bf..00c5cc3 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -679,6 +679,7 @@ static int rpm_reg_probe(struct platform_device *pdev)
>   	vreg->desc.owner = THIS_MODULE;
>   	vreg->desc.type = REGULATOR_VOLTAGE;
>   	vreg->desc.name = pdev->dev.of_node->name;
> +	vreg->desc.supply_name = "vin";
>
>   	vreg->rpm = dev_get_drvdata(pdev->dev.parent);
>   	if (!vreg->rpm) {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown Jan. 30, 2015, 12:39 p.m. UTC | #2
On Fri, Jan 30, 2015 at 08:57:29AM +0000, Srinivas Kandagatla wrote:
> Hi Bjorn,
> Thanks for sending this patch.. I almost forgot about this.
> 
> Shouldn’t we update the DT Bindings with this info?
> 
> Other than that:
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Please don't top post.
Bjorn Andersson Jan. 30, 2015, 3:46 p.m. UTC | #3
On Fri 30 Jan 00:57 PST 2015, Srinivas Kandagatla wrote:

> Hi Bjorn,
> Thanks for sending this patch.. I almost forgot about this.
> 
> Shouldn’t we update the DT Bindings with this info?
> 

At this time we don't have any bindings for the subnodes merged. So I also sent
out [1] yesterday, including this property. Seems I forgot linux-arm-msm
though.

> Other than that:
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 

Thanks

[1] https://lkml.org/lkml/2015/1/29/1077

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
index e3120bf..00c5cc3 100644
--- a/drivers/regulator/qcom_rpm-regulator.c
+++ b/drivers/regulator/qcom_rpm-regulator.c
@@ -679,6 +679,7 @@  static int rpm_reg_probe(struct platform_device *pdev)
 	vreg->desc.owner = THIS_MODULE;
 	vreg->desc.type = REGULATOR_VOLTAGE;
 	vreg->desc.name = pdev->dev.of_node->name;
+	vreg->desc.supply_name = "vin";
 
 	vreg->rpm = dev_get_drvdata(pdev->dev.parent);
 	if (!vreg->rpm) {