diff mbox

ARM: DT: apq8064: specify memory in dts file

Message ID 1425340485-31334-1-git-send-email-robdclark@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Rob Clark March 2, 2015, 11:54 p.m. UTC
Seems required for kexec (where --atags support is mutually exclusive
with --dtb).

Signed-off-by: Rob Clark <robdclark@gmail.com>
---
 arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Kumar Gala March 5, 2015, 2:41 p.m. UTC | #1
On Mar 2, 2015, at 5:54 PM, Rob Clark <robdclark@gmail.com> wrote:

> Seems required for kexec (where --atags support is mutually exclusive
> with --dtb).
> 
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index b396c83..fa40409 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -4,6 +4,15 @@
> 	model = "Qualcomm APQ8064/IFC6410";
> 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
> 
> +	memory {
> +		device_type = "memory";
> +		reg = <0x80000000 0x08e00000
> +				0x8a000000 0x03a00000
> +				0x8ec00000 0x00400000
> +				0x8f700000 0x00700000
> +				0x90000000 0x70000000>;
> +	};
> +

Curious, where did you get these ranges from?

- k

> 	soc {
> 		pinctrl@800000 {
> 			i2c1_pins: i2c1 {
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Clark March 19, 2015, 11:01 p.m. UTC | #2
On Thu, Mar 5, 2015 at 9:41 AM, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Mar 2, 2015, at 5:54 PM, Rob Clark <robdclark@gmail.com> wrote:
>
>> Seems required for kexec (where --atags support is mutually exclusive
>> with --dtb).
>>
>> Signed-off-by: Rob Clark <robdclark@gmail.com>
>> ---
>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index b396c83..fa40409 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -4,6 +4,15 @@
>>       model = "Qualcomm APQ8064/IFC6410";
>>       compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>>
>> +     memory {
>> +             device_type = "memory";
>> +             reg = <0x80000000 0x08e00000
>> +                             0x8a000000 0x03a00000
>> +                             0x8ec00000 0x00400000
>> +                             0x8f700000 0x00700000
>> +                             0x90000000 0x70000000>;
>> +     };
>> +
>
> Curious, where did you get these ranges from?

iirc, I was working backwards from the ranges that it gets atags when
I boot directly from bootloader (rather than kexec)

I cannot guarantee them 100%, but board booted up ok, gnome-shell, etc
worked..  I didn't see any obvious signs of memory corruption, so it
seemed like it was working.

BR,
-R

>
> - k
>
>>       soc {
>>               pinctrl@800000 {
>>                       i2c1_pins: i2c1 {
>> --
>> 2.1.0
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> --
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
index b396c83..fa40409 100644
--- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
+++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
@@ -4,6 +4,15 @@ 
 	model = "Qualcomm APQ8064/IFC6410";
 	compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
 
+	memory {
+		device_type = "memory";
+		reg = <0x80000000 0x08e00000
+				0x8a000000 0x03a00000
+				0x8ec00000 0x00400000
+				0x8f700000 0x00700000
+				0x90000000 0x70000000>;
+	};
+
 	soc {
 		pinctrl@800000 {
 			i2c1_pins: i2c1 {