| Message ID | 1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote: > > config SND_SOC_LPASS_CPU > tristate > + depends on OF > select REGMAP_MMIO > > config SND_SOC_LPASS_PLATFORM > tristate > + depends on OF > select REGMAP_MMIO > > config SND_SOC_LPASS_IPQ806X > Could you instead make the drivers compile without OF being set? I see that patch 7 and 8 introduces another two options doing +config SND_SOC_LPASS_APQ8016 + tristate + depends on SND_SOC_QCOM + select SND_SOC_LPASS_CPU + select SND_SOC_LPASS_PLATFORM + +config SND_SOC_APQ8016_SBC + tristate "SoC Audio support for APQ8016 SBC platforms" + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST + select SND_SOC_LPASS_APQ8016 + help so you get an obvious build failure here when SND_SOC_APQ8016_SBC gets selected with COMPILE_TEST on a platform that does not support OF. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks for looking at this patch. On 22/05/15 08:24, Arnd Bergmann wrote: > On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote: >> >> config SND_SOC_LPASS_CPU >> tristate >> + depends on OF >> select REGMAP_MMIO >> >> config SND_SOC_LPASS_PLATFORM >> tristate >> + depends on OF >> select REGMAP_MMIO >> >> config SND_SOC_LPASS_IPQ806X >> > > Could you instead make the drivers compile without OF being set? > > I see that patch 7 and 8 introduces another two options doing > > > +config SND_SOC_LPASS_APQ8016 > + tristate > + depends on SND_SOC_QCOM > + select SND_SOC_LPASS_CPU > + select SND_SOC_LPASS_PLATFORM > + > > +config SND_SOC_APQ8016_SBC > + tristate "SoC Audio support for APQ8016 SBC platforms" > + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST > + select SND_SOC_LPASS_APQ8016 > + help > > so you get an obvious build failure here when SND_SOC_APQ8016_SBC > gets selected with COMPILE_TEST on a platform that does not support OF. > Yes, this would fail. I think moving of_device_id structures in drivers under #ifdef CONFIG_OF and removing the depends on OF would fix it. --srini > Arnd > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 22 May 2015 12:53:44 Srinivas Kandagatla wrote: > Thanks for looking at this patch. > > On 22/05/15 08:24, Arnd Bergmann wrote: > > On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote: > >> > >> config SND_SOC_LPASS_CPU > >> tristate > >> + depends on OF > >> select REGMAP_MMIO > >> > >> config SND_SOC_LPASS_PLATFORM > >> tristate > >> + depends on OF > >> select REGMAP_MMIO > >> > >> config SND_SOC_LPASS_IPQ806X > >> > > > > Could you instead make the drivers compile without OF being set? > > > > I see that patch 7 and 8 introduces another two options doing > > > > > > +config SND_SOC_LPASS_APQ8016 > > + tristate > > + depends on SND_SOC_QCOM > > + select SND_SOC_LPASS_CPU > > + select SND_SOC_LPASS_PLATFORM > > + > > > > +config SND_SOC_APQ8016_SBC > > + tristate "SoC Audio support for APQ8016 SBC platforms" > > + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST > > + select SND_SOC_LPASS_APQ8016 > > + help > > > > so you get an obvious build failure here when SND_SOC_APQ8016_SBC > > gets selected with COMPILE_TEST on a platform that does not support OF. > > > > Yes, this would fail. > I think moving of_device_id structures in drivers under #ifdef CONFIG_OF > and removing the depends on OF would fix it. > Why? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 22/05/15 14:21, Arnd Bergmann wrote: > On Friday 22 May 2015 12:53:44 Srinivas Kandagatla wrote: >> Thanks for looking at this patch. >> >> On 22/05/15 08:24, Arnd Bergmann wrote: >>> On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote: >>>> >>>> config SND_SOC_LPASS_CPU >>>> tristate >>>> + depends on OF >>>> select REGMAP_MMIO >>>> >>>> config SND_SOC_LPASS_PLATFORM >>>> tristate >>>> + depends on OF >>>> select REGMAP_MMIO >>>> >>>> config SND_SOC_LPASS_IPQ806X >>>> >>> >>> Could you instead make the drivers compile without OF being set? >>> >>> I see that patch 7 and 8 introduces another two options doing >>> >>> >>> +config SND_SOC_LPASS_APQ8016 >>> + tristate >>> + depends on SND_SOC_QCOM >>> + select SND_SOC_LPASS_CPU >>> + select SND_SOC_LPASS_PLATFORM >>> + >>> >>> +config SND_SOC_APQ8016_SBC >>> + tristate "SoC Audio support for APQ8016 SBC platforms" >>> + depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST >>> + select SND_SOC_LPASS_APQ8016 >>> + help >>> >>> so you get an obvious build failure here when SND_SOC_APQ8016_SBC >>> gets selected with COMPILE_TEST on a platform that does not support OF. >>> >> >> Yes, this would fail. >> I think moving of_device_id structures in drivers under #ifdef CONFIG_OF >> and removing the depends on OF would fix it. >> > > Why? Yes, you are correct we don't need the ifdef's anymore. I will send a fixup patch on top of what Mark has already applied. --srini > > Arnd > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index b30c2ba..190c27d 100644 --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -6,10 +6,12 @@ config SND_SOC_QCOM config SND_SOC_LPASS_CPU tristate + depends on OF select REGMAP_MMIO config SND_SOC_LPASS_PLATFORM tristate + depends on OF select REGMAP_MMIO config SND_SOC_LPASS_IPQ806X