| Message ID | 1435355419-23602-2-git-send-email-bjorn.andersson@sonymobile.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 06/26/2015 02:50 PM, bjorn@kryo.se wrote: > += EXAMPLE > +The following example shows the SMEM setup for MSM8974, with a main SMEM region > +at 0xfa00000 and an auxiliary region at 0xfc428000: > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + smem_region: smem@fa00000 { > + reg = <0xfa00000 0x200000>; > + no-map; > + }; > + }; > + > + smem@fa00000 { This should be smem@fc428000 matching the first reg property. It's weird though, because if smem is using a secondary region it will be under the SoC node and have a reg property. Otherwise it would be directly under the root node and only have a memory-region. It would be nice if we could somehow move the rpm message ram (0xfc428000) into the reserved-memory node so that we could use memory-region for both regions. > + compatible = "qcom,smem"; > + > + memory-region = <&smem_region>; > + reg = <0xfc428000 0x4000>; > + > + hwlocks = <&tcsr_mutex 3>; > + };
On Wed, Jul 08, 2015 at 04:56:34PM -0700, Stephen Boyd wrote: > On 06/26/2015 02:50 PM, bjorn@kryo.se wrote: > > += EXAMPLE > > +The following example shows the SMEM setup for MSM8974, with a main SMEM region > > +at 0xfa00000 and an auxiliary region at 0xfc428000: > > + > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + smem_region: smem@fa00000 { > > + reg = <0xfa00000 0x200000>; > > + no-map; > > + }; > > + }; > > + > > + smem@fa00000 { > > This should be smem@fc428000 matching the first reg property. It's weird > though, because if smem is using a secondary region it will be under the > SoC node and have a reg property. Otherwise it would be directly under > the root node and only have a memory-region. It would be nice if we > could somehow move the rpm message ram (0xfc428000) into the > reserved-memory node so that we could use memory-region for both regions. The memory-region is just used to describe 'real' memory. The RPM message is IO memory and part of the SOC. Thats my take at least. > > > + compatible = "qcom,smem"; > > + > > + memory-region = <&smem_region>; > > + reg = <0xfc428000 0x4000>; > > + > > + hwlocks = <&tcsr_mutex 3>; > > + };
On Wed 08 Jul 16:56 PDT 2015, Stephen Boyd wrote: > On 06/26/2015 02:50 PM, bjorn@kryo.se wrote: > > += EXAMPLE > > +The following example shows the SMEM setup for MSM8974, with a main SMEM region > > +at 0xfa00000 and an auxiliary region at 0xfc428000: > > + > > + reserved-memory { > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + > > + smem_region: smem@fa00000 { > > + reg = <0xfa00000 0x200000>; > > + no-map; > > + }; > > + }; > > + > > + smem@fa00000 { > > This should be smem@fc428000 matching the first reg property. It's weird > though, because if smem is using a secondary region it will be under the > SoC node and have a reg property. Otherwise it would be directly under > the root node and only have a memory-region. It would be nice if we > could somehow move the rpm message ram (0xfc428000) into the > reserved-memory node so that we could use memory-region for both regions. > I agree, the semantics here became a little bit odd. I do not think we should list the 0xfc428000 region as a memory-region, as it's "device memory" and I do like the fact that we don't repeat ourselves with listing the memory-region as a reg. Therefor I think this is the least ugly option, but the address in the name of the node should be updated. > > + compatible = "qcom,smem"; > > + > > + memory-region = <&smem_region>; > > + reg = <0xfc428000 0x4000>; > > + > > + hwlocks = <&tcsr_mutex 3>; > > + }; > Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 26, 2015 at 02:50:09PM -0700, bjorn@kryo.se wrote: > From: Bjorn Andersson <bjorn.andersson@sonymobile.com> > > Add device tree binding documentation for the Qualcom Shared Memory > Manager. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> <snip> > + smem@fa00000 { > + compatible = "qcom,smem"; > + > + memory-region = <&smem_region>; > + reg = <0xfc428000 0x4000>; I'll fixup the address here before applying. Applied, thanks!
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt new file mode 100644 index 0000000..19cad6c --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt @@ -0,0 +1,51 @@ +Qualcomm Shared Memory Manager binding + +This binding describes the Qualcomm Shared Memory Manager, used to share data +between various subsystems and OSes in Qualcomm platforms. + +- compatible: + Usage: required + Value type: <stringlist> + Definition: must be: + "qcom,smem" + +- memory-region: + Usage: required + Value type: <prop-encoded-array> + Definition: handle to memory reservation for main SMEM memory region. + +- reg: + Usage: optional + Value type: <prop-encoded-array> + Definition: base address and size pair for any additional memory areas + of the shared memory. + +- hwlocks: + Usage: required + Value type: <prop-encoded-array> + Definition: reference to a hwspinlock used to protect allocations from + the shared memory + += EXAMPLE +The following example shows the SMEM setup for MSM8974, with a main SMEM region +at 0xfa00000 and an auxiliary region at 0xfc428000: + + reserved-memory { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + smem_region: smem@fa00000 { + reg = <0xfa00000 0x200000>; + no-map; + }; + }; + + smem@fa00000 { + compatible = "qcom,smem"; + + memory-region = <&smem_region>; + reg = <0xfc428000 0x4000>; + + hwlocks = <&tcsr_mutex 3>; + };