From patchwork Mon Jul 6 12:16:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ivan T. Ivanov" X-Patchwork-Id: 6722691 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1EC4FC05AC for ; Mon, 6 Jul 2015 12:17:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 444B32060F for ; Mon, 6 Jul 2015 12:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6AA7A20426 for ; Mon, 6 Jul 2015 12:17:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754646AbbGFMRP (ORCPT ); Mon, 6 Jul 2015 08:17:15 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:36036 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754582AbbGFMQe (ORCPT ); Mon, 6 Jul 2015 08:16:34 -0400 Received: by wguu7 with SMTP id u7so138735497wgu.3 for ; Mon, 06 Jul 2015 05:16:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BunBGhzfca2yA1iiTSDyZDO7Tb00EkF8C5qUBSZJazY=; b=cmwlWtKNCR5meTsQWls3eCzywK8+R+QnyBqVYSFRdJJR54gx49m4V4paeMA/X3Q9R5 obbiNFrpD6WFL3byOd3KAeAzNHt+VZQHdnd8K82DTftzhu0QEW1vzjbb6SgOckLeeTy7 I6h/yZTQGIFiiYQtjpTbYtCSlGiqhkqjxXUJeXPx0vxt1UtePE76Kj85vHhjMf2IOVIN +kDcLKsgjs3WJY7KRSBA+/2Qm5e9oOyDTAc0mjCKmNck9Skml4mMRn6R+Dr2BPgjy37c 4NVyE58FDA6t8GcUUfdtJo95SvPs0RSkeyWFbsJzoAVQQy5p+D29rEJHzZdf0dtfOR2b 9v4g== X-Gm-Message-State: ALoCoQnrZp5o/6XB+X+Ycba8omc5CQlnY0FTrBIAfqfKz2B+4dJirPYhb5IRn52PziDA072uqfwl X-Received: by 10.180.206.211 with SMTP id lq19mr95032651wic.81.1436184993840; Mon, 06 Jul 2015 05:16:33 -0700 (PDT) Received: from localhost.localdomain ([37.157.136.206]) by mx.google.com with ESMTPSA id ha4sm46918316wib.0.2015.07.06.05.16.32 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jul 2015 05:16:33 -0700 (PDT) From: "Ivan T. Ivanov" To: Ulf Hansson Cc: Adrian Hunter , Tim Kryger , Aisheng Dong , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 2/3] mmc: sdhci: don't use card state polling when CD GPIO is defined Date: Mon, 6 Jul 2015 15:16:20 +0300 Message-Id: <1436184981-16719-3-git-send-email-ivan.ivanov@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1436184981-16719-1-git-send-email-ivan.ivanov@linaro.org> References: <1436184981-16719-1-git-send-email-ivan.ivanov@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason to use polling for card detection state change when drivers are using dedicated GPIO for this. Don't poll in this case. Signed-off-by: Ivan T. Ivanov --- drivers/mmc/host/sdhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index dd91b24..02ac7a4 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -3124,7 +3124,8 @@ int sdhci_add_host(struct sdhci_host *host) mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) && - !(mmc->caps & MMC_CAP_NONREMOVABLE)) + !(mmc->caps & MMC_CAP_NONREMOVABLE) && + IS_ERR_VALUE(mmc_gpio_get_cd(host->mmc))) mmc->caps |= MMC_CAP_NEEDS_POLL; /* If there are external regulators, get them */