diff mbox

[RFC,20/21] drm/shmobile: Remove FB_KMS_HELPER config option

Message ID 1436769848-4990-21-git-send-email-architt@codeaurora.org (mailing list archive)
State Not Applicable, archived
Delegated to: Andy Gross
Headers show

Commit Message

Archit Taneja July 13, 2015, 6:44 a.m. UTC
The driver internally uses drm_fb_cma helpers to emulate fbdev and
allocate buffers. It doesn't need to select DRM_FB_KMS_HELPER. This
will be managed by the config option DRM_KMS_CMA_HELPER.

Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
 drivers/gpu/drm/shmobile/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Laurent Pinchart Aug. 1, 2015, 10:02 a.m. UTC | #1
Hi Archit,

Thank you for the patch.

On Monday 13 July 2015 12:14:07 Archit Taneja wrote:
> The driver internally uses drm_fb_cma helpers to emulate fbdev and
> allocate buffers. It doesn't need to select DRM_FB_KMS_HELPER. This
> will be managed by the config option DRM_KMS_CMA_HELPER.
> 
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Signed-off-by: Archit Taneja <architt@codeaurora.org>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/shmobile/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/Kconfig
> b/drivers/gpu/drm/shmobile/Kconfig index b9202aa..389b5f9 100644
> --- a/drivers/gpu/drm/shmobile/Kconfig
> +++ b/drivers/gpu/drm/shmobile/Kconfig
> @@ -6,7 +6,6 @@ config DRM_SHMOBILE
>  	select BACKLIGHT_CLASS_DEVICE
>  	select BACKLIGHT_LCD_SUPPORT
>  	select DRM_KMS_HELPER
> -	select DRM_KMS_FB_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_GEM_CMA_HELPER
>  	help
diff mbox

Patch

diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index b9202aa..389b5f9 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
@@ -6,7 +6,6 @@  config DRM_SHMOBILE
 	select BACKLIGHT_CLASS_DEVICE
 	select BACKLIGHT_LCD_SUPPORT
 	select DRM_KMS_HELPER
-	select DRM_KMS_FB_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
 	help