| Message ID | 1436769848-4990-6-git-send-email-architt@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
Hi Archit, Thank you for the patch. On Monday 13 July 2015 12:13:52 Archit Taneja wrote: > Remove FB_* config options since the driver doesn't call any fbdev > functions directly. > > Remove FB_KMS_HELPER as this would now be selected by the top level > FBDEV_EMULATION config option. If the fbdev emulation isn't selected, > the drm_fb_helper functions will be stubbed out. > > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Signed-off-by: Archit Taneja <architt@codeaurora.org> I like that, one step closer to removing fbdev altogether (even if there are many steps left) :-) Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/omapdrm/Kconfig | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/Kconfig > b/drivers/gpu/drm/omapdrm/Kconfig index 6c220cd..340ece7 100644 > --- a/drivers/gpu/drm/omapdrm/Kconfig > +++ b/drivers/gpu/drm/omapdrm/Kconfig > @@ -5,11 +5,6 @@ config DRM_OMAP > depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM > depends on OMAP2_DSS > select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > - select FB_SYS_FILLRECT > - select FB_SYS_COPYAREA > - select FB_SYS_IMAGEBLIT > - select FB_SYS_FOPS > default n > help > DRM display driver for OMAP2/3/4 based boards.
On 08/01/2015 03:32 PM, Laurent Pinchart wrote: > Hi Archit, > > Thank you for the patch. > > On Monday 13 July 2015 12:13:52 Archit Taneja wrote: >> Remove FB_* config options since the driver doesn't call any fbdev >> functions directly. >> >> Remove FB_KMS_HELPER as this would now be selected by the top level >> FBDEV_EMULATION config option. If the fbdev emulation isn't selected, >> the drm_fb_helper functions will be stubbed out. >> >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> >> Signed-off-by: Archit Taneja <architt@codeaurora.org> > > I like that, one step closer to removing fbdev altogether (even if there are > many steps left) :-) > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks for the Acks. I'll use them when I post again. Archit
diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig index 6c220cd..340ece7 100644 --- a/drivers/gpu/drm/omapdrm/Kconfig +++ b/drivers/gpu/drm/omapdrm/Kconfig @@ -5,11 +5,6 @@ config DRM_OMAP depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM depends on OMAP2_DSS select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select FB_SYS_FILLRECT - select FB_SYS_COPYAREA - select FB_SYS_IMAGEBLIT - select FB_SYS_FOPS default n help DRM display driver for OMAP2/3/4 based boards.
Remove FB_* config options since the driver doesn't call any fbdev functions directly. Remove FB_KMS_HELPER as this would now be selected by the top level FBDEV_EMULATION config option. If the fbdev emulation isn't selected, the drm_fb_helper functions will be stubbed out. Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Archit Taneja <architt@codeaurora.org> --- drivers/gpu/drm/omapdrm/Kconfig | 5 ----- 1 file changed, 5 deletions(-)