| Message ID | 1446789847-640-3-git-send-email-agross@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 11/06/2015 08:04 AM, Andy Gross wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross <agross@codeaurora.org> With these patches I see significant improvement in throughput on my db410c board. Tested-by: Georgi Djakov <georgi.djakov@linaro.org> > --- > drivers/usb/host/ehci-msm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > index c4f84c8..c23e285 100644 > --- a/drivers/usb/host/ehci-msm.c > +++ b/drivers/usb/host/ehci-msm.c > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > /* bursts of unspecified length. */ > writel(0, USB_AHBBURST); > - /* Use the AHB transactor */ > - writel(0, USB_AHBMODE); > + /* Use the AHB transactor, allow posted data writes */ > + writel(0x8, USB_AHBMODE); > /* Disable streaming mode and select host mode */ > writel(0x13, USB_USBMODE); > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 6 Nov 2015, Georgi Djakov wrote: > On 11/06/2015 08:04 AM, Andy Gross wrote: > > This patch sets the AHBMODE to allow for posted data writes. This > > results in higher performance. > > > > Signed-off-by: Andy Gross <agross@codeaurora.org> > > With these patches I see significant improvement in throughput > on my db410c board. > > Tested-by: Georgi Djakov <georgi.djakov@linaro.org> > > > --- > > drivers/usb/host/ehci-msm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c > > index c4f84c8..c23e285 100644 > > --- a/drivers/usb/host/ehci-msm.c > > +++ b/drivers/usb/host/ehci-msm.c > > @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) > > > > /* bursts of unspecified length. */ > > writel(0, USB_AHBBURST); > > - /* Use the AHB transactor */ > > - writel(0, USB_AHBMODE); > > + /* Use the AHB transactor, allow posted data writes */ > > + writel(0x8, USB_AHBMODE); > > /* Disable streaming mode and select host mode */ > > writel(0x13, USB_USBMODE); Acked-by: Alan Stern <stern@rowland.harvard.edu> -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 6, 2015 at 12:04 AM, Andy Gross <agross@codeaurora.org> wrote: > This patch sets the AHBMODE to allow for posted data writes. This > results in higher performance. > > Signed-off-by: Andy Gross <agross@codeaurora.org> I know it's a little late, but ... Acked-by: Timur Tabi <timur@codeaurora.org>
diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index c4f84c8..c23e285 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -57,8 +57,8 @@ static int ehci_msm_reset(struct usb_hcd *hcd) /* bursts of unspecified length. */ writel(0, USB_AHBBURST); - /* Use the AHB transactor */ - writel(0, USB_AHBMODE); + /* Use the AHB transactor, allow posted data writes */ + writel(0x8, USB_AHBMODE); /* Disable streaming mode and select host mode */ writel(0x13, USB_USBMODE);
This patch sets the AHBMODE to allow for posted data writes. This results in higher performance. Signed-off-by: Andy Gross <agross@codeaurora.org> --- drivers/usb/host/ehci-msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)