diff mbox

[v4,9/9] media: venus: enable building of Venus video driver

Message ID 1480583001-32236-10-git-send-email-stanimir.varbanov@linaro.org (mailing list archive)
State Superseded, archived
Delegated to: Andy Gross
Headers show

Commit Message

Stanimir Varbanov Dec. 1, 2016, 9:03 a.m. UTC
This adds Venus driver Makefile and changes v4l2 platform
Makefile/Kconfig in order to enable building of the driver.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/media/platform/Kconfig             | 13 +++++++++++++
 drivers/media/platform/Makefile            |  2 ++
 drivers/media/platform/qcom/venus/Makefile | 14 ++++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 drivers/media/platform/qcom/venus/Makefile

Comments

kernel test robot Dec. 3, 2016, 12:07 a.m. UTC | #1
Hi Stanimir,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20161202]
[cannot apply to v4.9-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Qualcomm-video-decoder-encoder-driver/20161203-054705
base:   git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/media/platform/qcom/venus/hfi_venus.c: In function 'venus_tzbsp_set_video_state':
>> drivers/media/platform/qcom/venus/hfi_venus.c:455:9: error: implicit declaration of function 'qcom_scm_video_set_state' [-Werror=implicit-function-declaration]
     return qcom_scm_video_set_state(state, 0);
            ^~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/qcom_scm_video_set_state +455 drivers/media/platform/qcom/venus/hfi_venus.c

93fa34d2 Stanimir Varbanov 2016-12-01  439  
93fa34d2 Stanimir Varbanov 2016-12-01  440  	pkt = (struct hfi_sys_set_resource_pkt *) packet;
93fa34d2 Stanimir Varbanov 2016-12-01  441  
93fa34d2 Stanimir Varbanov 2016-12-01  442  	ret = pkt_sys_set_resource(pkt, id, size, addr, cookie);
93fa34d2 Stanimir Varbanov 2016-12-01  443  	if (ret)
93fa34d2 Stanimir Varbanov 2016-12-01  444  		return ret;
93fa34d2 Stanimir Varbanov 2016-12-01  445  
93fa34d2 Stanimir Varbanov 2016-12-01  446  	ret = venus_iface_cmdq_write(hdev, pkt);
93fa34d2 Stanimir Varbanov 2016-12-01  447  	if (ret)
93fa34d2 Stanimir Varbanov 2016-12-01  448  		return ret;
93fa34d2 Stanimir Varbanov 2016-12-01  449  
93fa34d2 Stanimir Varbanov 2016-12-01  450  	return 0;
93fa34d2 Stanimir Varbanov 2016-12-01  451  }
93fa34d2 Stanimir Varbanov 2016-12-01  452  
93fa34d2 Stanimir Varbanov 2016-12-01  453  static int venus_tzbsp_set_video_state(enum tzbsp_video_state state)
93fa34d2 Stanimir Varbanov 2016-12-01  454  {
93fa34d2 Stanimir Varbanov 2016-12-01 @455  	return qcom_scm_video_set_state(state, 0);
93fa34d2 Stanimir Varbanov 2016-12-01  456  }
93fa34d2 Stanimir Varbanov 2016-12-01  457  
93fa34d2 Stanimir Varbanov 2016-12-01  458  static int venus_boot_core(struct venus_hfi_device *hdev)
93fa34d2 Stanimir Varbanov 2016-12-01  459  {
93fa34d2 Stanimir Varbanov 2016-12-01  460  	struct device *dev = hdev->core->dev;
93fa34d2 Stanimir Varbanov 2016-12-01  461  	static const unsigned int max_tries = 100;
93fa34d2 Stanimir Varbanov 2016-12-01  462  	u32 ctrl_status = 0;
93fa34d2 Stanimir Varbanov 2016-12-01  463  	unsigned int count = 0;

:::::: The code at line 455 was first introduced by commit
:::::: 93fa34d264d32979ec1634d8fc366d7cf6ff453d media: venus: hfi: add Venus HFI files

:::::: TO: Stanimir Varbanov <stanimir.varbanov@linaro.org>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index d944421e392d..2fc81dcbdb1f 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -379,6 +379,19 @@  config VIDEO_TI_VPE_DEBUG
 	---help---
 	  Enable debug messages on VPE driver.
 
+config VIDEO_QCOM_VENUS
+	tristate "Qualcomm Venus V4L2 encoder/decoder driver"
+	depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
+	depends on (ARCH_QCOM && OF) || COMPILE_TEST
+	depends on (IOMMU_DMA && QCOM_VENUS_PIL) || COMPILE_TEST
+	select VIDEOBUF2_DMA_SG
+	select V4L2_MEM2MEM_DEV
+	---help---
+	  This is a V4L2 driver for Qualcomm Venus video accelerator
+	  hardware. It accelerates encoding and decoding operations
+	  on various Qualcomm SoCs.
+	  To compile this driver as a module choose m here.
+
 endif # V4L_MEM2MEM_DRIVERS
 
 # TI VIDEO PORT Helper Modules
diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
index 5b3cb271d2b8..d88a4e1eb850 100644
--- a/drivers/media/platform/Makefile
+++ b/drivers/media/platform/Makefile
@@ -69,3 +69,5 @@  obj-$(CONFIG_VIDEO_MEDIATEK_VPU)	+= mtk-vpu/
 obj-$(CONFIG_VIDEO_MEDIATEK_VCODEC)	+= mtk-vcodec/
 
 obj-$(CONFIG_VIDEO_MEDIATEK_MDP)	+= mtk-mdp/
+
+obj-$(CONFIG_VIDEO_QCOM_VENUS)		+= qcom/venus/
diff --git a/drivers/media/platform/qcom/venus/Makefile b/drivers/media/platform/qcom/venus/Makefile
new file mode 100644
index 000000000000..8c4ef27e30fe
--- /dev/null
+++ b/drivers/media/platform/qcom/venus/Makefile
@@ -0,0 +1,14 @@ 
+# Makefile for Qualcomm Venus driver
+
+venus-objs += 	core.o \
+		helpers.o \
+		vdec.o \
+		vdec_ctrls.o \
+		venc.o \
+		venc_ctrls.o \
+		hfi_venus.o \
+		hfi_msgs.o \
+		hfi_cmds.o \
+		hfi.o \
+
+obj-$(CONFIG_VIDEO_QCOM_VENUS) += venus.o