| Message ID | 1482130389-3164-1-git-send-email-vivek.gautam@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 12/19, Vivek Gautam wrote: > nvmem_cell_read() API fills in the argument 'len' with > the number of bytes read from the cell. Many users don't > care about this length value. So allow users to pass a > NULL pointer to this len field. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
On Tue, Dec 20, 2016 at 3:17 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 12/19, Vivek Gautam wrote: >> nvmem_cell_read() API fills in the argument 'len' with >> the number of bytes read from the cell. Many users don't >> care about this length value. So allow users to pass a >> NULL pointer to this len field. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Thanks Stephen.
Hi Srinivas, On Tue, Dec 20, 2016 at 3:17 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 12/19, Vivek Gautam wrote: >> nvmem_cell_read() API fills in the argument 'len' with >> the number of bytes read from the cell. Many users don't >> care about this length value. So allow users to pass a >> NULL pointer to this len field. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Can you please pick this patch as well, adding Stephen's 'Reviewed-by' tag. Regards Vivek
On 05/01/17 05:34, Vivek Gautam wrote: > Hi Srinivas, > > On Tue, Dec 20, 2016 at 3:17 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> On 12/19, Vivek Gautam wrote: >>> nvmem_cell_read() API fills in the argument 'len' with >>> the number of bytes read from the cell. Many users don't >>> care about this length value. So allow users to pass a >>> NULL pointer to this len field. >>> >>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >>> --- >> >> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> > > Can you please pick this patch as well, adding Stephen's 'Reviewed-by' tag. > This is already in my queue for 4.11 release, as this is an enhancement. I will send them to Greg once we hit rc4 or rc5. thanks, srini > > Regards > Vivek > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/05/2017 03:10 PM, Srinivas Kandagatla wrote: > > > On 05/01/17 05:34, Vivek Gautam wrote: >> Hi Srinivas, >> >> On Tue, Dec 20, 2016 at 3:17 AM, Stephen Boyd <sboyd@codeaurora.org> >> wrote: >>> On 12/19, Vivek Gautam wrote: >>>> nvmem_cell_read() API fills in the argument 'len' with >>>> the number of bytes read from the cell. Many users don't >>>> care about this length value. So allow users to pass a >>>> NULL pointer to this len field. >>>> >>>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >>>> --- >>> >>> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> >> >> Can you please pick this patch as well, adding Stephen's >> 'Reviewed-by' tag. >> > This is already in my queue for 4.11 release, as this is an > enhancement. I will send them to Greg once we hit rc4 or rc5. Okay. Thanks for picking. Regards Vivek
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 965911d..4c38842 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -970,7 +970,8 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, if (cell->bit_offset || cell->nbits) nvmem_shift_read_buffer_in_place(cell, buf); - *len = cell->bytes; + if (len) + *len = cell->bytes; return 0; } @@ -979,7 +980,8 @@ static int __nvmem_cell_read(struct nvmem_device *nvmem, * nvmem_cell_read() - Read a given nvmem cell * * @cell: nvmem cell to be read. - * @len: pointer to length of cell which will be populated on successful read. + * @len: pointer to length of cell which will be populated on successful read; + * can be NULL. * * Return: ERR_PTR() on error or a valid pointer to a char * buffer on success. * The buffer should be freed by the consumer with a kfree().
nvmem_cell_read() API fills in the argument 'len' with the number of bytes read from the cell. Many users don't care about this length value. So allow users to pass a NULL pointer to this len field. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- Based on torvalds's master branch. - Tested against 'next-20161219' tag on db410c (apq8016) target for thermal sensors. drivers/nvmem/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)