diff mbox

[V1,15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall

Message ID 1496147943-25822-16-git-send-email-kgunda@codeaurora.org (mailing list archive)
State Not Applicable, archived
Delegated to: Andy Gross
Headers show

Commit Message

Kiran Gunda May 30, 2017, 12:39 p.m. UTC 
From: Abhijeet Dharmapurikar <adharmap@codeaurora.org>

The spmi arbiter device spawns spmi_devices which in turn spawn
platform_devices for pmic peripherals.

Move the arbiter's driver init to arch_initcall so that the subsequent
devices it spawns get instantiated earlier.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
---
 drivers/spmi/spmi-pmic-arb.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Stephen Boyd May 31, 2017, 10:07 p.m. UTC | #1 
On 05/30, Kiran Gunda wrote:
> @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev)
>  		.of_match_table = spmi_pmic_arb_match_table,
>  	},
>  };
> -module_platform_driver(spmi_pmic_arb_driver);
> +
> +int __init spmi_pmic_arb_init(void)

Missing static.

> +{
> +	return platform_driver_register(&spmi_pmic_arb_driver);
> +}
> +arch_initcall(spmi_pmic_arb_init);

We also lost module removal. Probably nobody tests it, but still
no mention of that in commit text.

I'm not sure we need this at all though. Is there something that
needs to probe early? Indicating what that is in the commit text
would be helpful.
Kiran Gunda July 18, 2017, 11:49 a.m. UTC | #2 
On 2017-06-01 03:37, Stephen Boyd wrote:
> On 05/30, Kiran Gunda wrote:
>> @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct 
>> platform_device *pdev)
>>  		.of_match_table = spmi_pmic_arb_match_table,
>>  	},
>>  };
>> -module_platform_driver(spmi_pmic_arb_driver);
>> +
>> +int __init spmi_pmic_arb_init(void)
> 
> Missing static.
> 
>> +{
>> +	return platform_driver_register(&spmi_pmic_arb_driver);
>> +}
>> +arch_initcall(spmi_pmic_arb_init);
> 
> We also lost module removal. Probably nobody tests it, but still
> no mention of that in commit text.
> 
> I'm not sure we need this at all though. Is there something that
> needs to probe early? Indicating what that is in the commit text
> would be helpful.
Dropped out this patch. As this is no more required.
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c
index 767bd2c..069799c 100644
--- a/drivers/spmi/spmi-pmic-arb.c
+++ b/drivers/spmi/spmi-pmic-arb.c
@@ -1384,7 +1384,12 @@  static int spmi_pmic_arb_remove(struct platform_device *pdev)
 		.of_match_table = spmi_pmic_arb_match_table,
 	},
 };
-module_platform_driver(spmi_pmic_arb_driver);
+
+int __init spmi_pmic_arb_init(void)
+{
+	return platform_driver_register(&spmi_pmic_arb_driver);
+}
+arch_initcall(spmi_pmic_arb_init);
 
 MODULE_LICENSE("GPL v2");
 MODULE_ALIAS("platform:spmi_pmic_arb");