From patchwork Mon Jul 3 12:18:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiran Gunda X-Patchwork-Id: 9822613 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3CC12602F0 for ; Mon, 3 Jul 2017 12:21:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EF122684F for ; Mon, 3 Jul 2017 12:21:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2398D28557; Mon, 3 Jul 2017 12:21:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F55A2684F for ; Mon, 3 Jul 2017 12:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbdGCMVv (ORCPT ); Mon, 3 Jul 2017 08:21:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37248 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752866AbdGCMVu (ORCPT ); Mon, 3 Jul 2017 08:21:50 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 267D2607C5; Mon, 3 Jul 2017 12:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499084496; bh=iO7emAj5qhlDdNeeN0ImHCzUt8y8f3y3iJT+jqlbyts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U8tDcmjBnJ1C9gH2KsxoOlTlydtO3n7hT2zW0dG8NznhhwWqR5134IxWHhjuxJZpi 1IpI3nC5nlxIKBCBeLsi5QCAhud+kR2IhCdn87Q4j3Gw8PUTkWOwq1QUGCasRNcjOb US0V3gYnCxO7hX+C6499uj1Dz2q6/SRrTGy08/eg= Received: from kgunda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kgunda@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 38401607C5; Mon, 3 Jul 2017 12:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499084495; bh=iO7emAj5qhlDdNeeN0ImHCzUt8y8f3y3iJT+jqlbyts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WWAf7DuLKhqHGCK3phrylaa2MuacfxBJRuiyTUbLaUe2uzvETBWMjzRBoRpBHWe8v y5sPK1QXROjmot2fJD/vQ/1BART45YY5uvS5mhsjH2X2I/oVADP+mLzVGBreZ8uhf1 2oByG/XKYGYrDPixePfQJt0fA0SGEVP6LfAQ+bpY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 38401607C5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org From: Kiran Gunda To: Kiran Gunda , Abhijeet Dharmapurikar , Stephen Boyd , Nicholas Troast , Greg Kroah-Hartman , Christophe JAILLET , linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org Subject: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Date: Mon, 3 Jul 2017 17:48:28 +0530 Message-Id: <1499084308-2232-6-git-send-email-kgunda@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> References: <1499084308-2232-1-git-send-email-kgunda@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently the driver sets the pmic_arb core interrupt as wakeup capable irrespective of the child irqs which causes the system to wakeup unnecessarily. To fix this, set the core interrupt as wakeup capable only if any of the child irqs request for it. Do this by marking it as wakeup capable in the irq_set_wake callback. Signed-off-by: Kiran Gunda --- drivers/spmi/spmi-pmic-arb.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 5285245..2d2e39c 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -621,6 +621,19 @@ static int qpnpint_irq_set_type(struct irq_data *d, unsigned int flow_type) return 0; } +static int qpnpint_irq_set_wake(struct irq_data *d, unsigned int on) +{ + struct spmi_pmic_arb *pmic_arb = irq_data_get_irq_chip_data(d); + int ret; + + if (on) + ret = enable_irq_wake(pmic_arb->irq); + else + ret = disable_irq_wake(pmic_arb->irq); + + return ret; +} + static int qpnpint_get_irqchip_state(struct irq_data *d, enum irqchip_irq_state which, bool *state) @@ -643,9 +656,9 @@ static int qpnpint_get_irqchip_state(struct irq_data *d, .irq_mask = qpnpint_irq_mask, .irq_unmask = qpnpint_irq_unmask, .irq_set_type = qpnpint_irq_set_type, + .irq_set_wake = qpnpint_irq_set_wake, .irq_get_irqchip_state = qpnpint_get_irqchip_state, - .flags = IRQCHIP_MASK_ON_SUSPEND - | IRQCHIP_SKIP_SET_WAKE, + .flags = IRQCHIP_MASK_ON_SUSPEND, }; static int qpnpint_irq_domain_dt_translate(struct irq_domain *d, @@ -1071,8 +1084,6 @@ static int spmi_pmic_arb_probe(struct platform_device *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, pmic_arb_chained_irq, pmic_arb); - enable_irq_wake(pmic_arb->irq); - err = spmi_controller_add(ctrl); if (err) goto err_domain_remove;