From patchwork Mon Jul 10 13:05:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiran Gunda X-Patchwork-Id: 9832949 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5A2E860393 for ; Mon, 10 Jul 2017 13:06:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C8B01FEB1 for ; Mon, 10 Jul 2017 13:06:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40E242621D; Mon, 10 Jul 2017 13:06:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D07182521E for ; Mon, 10 Jul 2017 13:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754142AbdGJNGW (ORCPT ); Mon, 10 Jul 2017 09:06:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32988 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbdGJNGU (ORCPT ); Mon, 10 Jul 2017 09:06:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DA77B612CA; Mon, 10 Jul 2017 13:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499691974; bh=45BZ7KbLioBoKjdcAnpn8vFElLdmqPbdYMIDQfr0qDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QfT6z2AAgw7/oxuPOKgc+jwOpCPLrnLlzEDBEsLzpNOYVWmHKqXeGs+s+rOqCwIi8 5SO4n2/o8sEsUzbstnZ2zkuyXdKkMrCE+jfDmG+5gOF7BwR/2ZOlLz4cSEJZcJfGV/ sG8KyTP8xS73MFPlC52jxvYsWuJaHHODICnuXFQg= Received: from kgunda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kgunda@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1057460209; Mon, 10 Jul 2017 13:06:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1499691974; bh=45BZ7KbLioBoKjdcAnpn8vFElLdmqPbdYMIDQfr0qDA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QfT6z2AAgw7/oxuPOKgc+jwOpCPLrnLlzEDBEsLzpNOYVWmHKqXeGs+s+rOqCwIi8 5SO4n2/o8sEsUzbstnZ2zkuyXdKkMrCE+jfDmG+5gOF7BwR/2ZOlLz4cSEJZcJfGV/ sG8KyTP8xS73MFPlC52jxvYsWuJaHHODICnuXFQg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1057460209 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kgunda@codeaurora.org From: Kiran Gunda To: gregkh@linuxfoundation.org, sboyd@codeaurora.org, Kiran Gunda , Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, Fenglin Wu Subject: [PATCH V2 4/4] spmi: pmic-arb: Remove checking opc value not less than 0 Date: Mon, 10 Jul 2017 18:35:26 +0530 Message-Id: <1499691926-16030-5-git-send-email-kgunda@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1499691926-16030-1-git-send-email-kgunda@codeaurora.org> References: <1499691926-16030-1-git-send-email-kgunda@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can cause a forbidden warning during compilation. Remove the check. Signed-off-by: Fenglin Wu Signed-off-by: Kiran Gunda Reviewed-by: Stephen Boyd --- drivers/spmi/spmi-pmic-arb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index d992634..5114264 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012-2017, The Linux Foundation. All rights reserved. + * Copyright (c) 2012-2015, 2017, The Linux Foundation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 and @@ -419,7 +419,7 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid, /* Check the opcode */ if (opc >= 0x40 && opc <= 0x5F) opc = PMIC_ARB_OP_WRITE; - else if (opc >= 0x00 && opc <= 0x0F) + else if (opc <= 0x0F) opc = PMIC_ARB_OP_EXT_WRITE; else if (opc >= 0x30 && opc <= 0x37) opc = PMIC_ARB_OP_EXT_WRITEL;