From patchwork Wed Oct 11 15:14:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jordan Crouse X-Patchwork-Id: 9999903 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EDB1660244 for ; Wed, 11 Oct 2017 15:14:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6E6B2897E for ; Wed, 11 Oct 2017 15:14:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC144289D0; Wed, 11 Oct 2017 15:14:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D55E2897E for ; Wed, 11 Oct 2017 15:14:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750705AbdJKPOl (ORCPT ); Wed, 11 Oct 2017 11:14:41 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:32908 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752099AbdJKPOk (ORCPT ); Wed, 11 Oct 2017 11:14:40 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DC75D60D6E; Wed, 11 Oct 2017 15:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507734880; bh=cpZTrnGyg+u3GluPC+9eTZ2wHXHacwjgyoO+FmKxk2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K9dedRLYuCPYtRBdxqXNR4KWHdcQNx0XZBM6JzuzdRARJtbmf8n6+n46QQThQa/Dr nWfNEcPQ8xxAj+07jJcNZH5Y6MxBjiikFrJmMJAhKM7AL8vw7CwmCf1pLJuy+JS2Qc 1xhmoBZEjTy6W/NKTFZO13KwKgGRJwpLXbDgf5RQ= Received: from jcrouse-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id EFD1260D0C; Wed, 11 Oct 2017 15:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507734875; bh=cpZTrnGyg+u3GluPC+9eTZ2wHXHacwjgyoO+FmKxk2o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LWzpw3nIbRT2za0vkw2V2DlMX+Wdmi5RLmpSiChJ3R8eWvwQCUYuyjTmHDVfNLKox 3r/FkPtJTV2J/Y/Od0VWoP7MtJfdNBJ3fmA5QBx8JWZA2caM029QEw88yhlGnjlkdS 2N87QVMGBcE0IIzP5CL4QvPf89ggqn5IR9h/a5XA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EFD1260D0C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org From: Jordan Crouse To: freedreno@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org Subject: [PATCH 8/9] drm/msm: Removed unused struct_mutex_task Date: Wed, 11 Oct 2017 09:14:23 -0600 Message-Id: <1507734864-25069-9-git-send-email-jcrouse@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1507734864-25069-1-git-send-email-jcrouse@codeaurora.org> References: <1507734864-25069-1-git-send-email-jcrouse@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Recent changes to locking have rendered struct_mutex_task unused. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_drv.h | 6 ------ drivers/gpu/drm/msm/msm_gem_submit.c | 2 -- 2 files changed, 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h index 9853e3e..c46dc12 100644 --- a/drivers/gpu/drm/msm/msm_drv.h +++ b/drivers/gpu/drm/msm/msm_drv.h @@ -154,12 +154,6 @@ struct msm_drm_private { struct shrinker shrinker; struct msm_vblank_ctrl vblank_ctrl; - - /* task holding struct_mutex.. currently only used in submit path - * to detect and reject faults from copy_from_user() for submit - * ioctl. - */ - struct task_struct *struct_mutex_task; }; struct msm_format { diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c index 9e087cf..d68bfa6 100644 --- a/drivers/gpu/drm/msm/msm_gem_submit.c +++ b/drivers/gpu/drm/msm/msm_gem_submit.c @@ -449,7 +449,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, goto out_unlock; } } - priv->struct_mutex_task = current; submit = submit_create(dev, gpu, queue, args->nr_bos, args->nr_cmds); if (!submit) { @@ -569,7 +568,6 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, out_unlock: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd); - priv->struct_mutex_task = NULL; mutex_unlock(&dev->struct_mutex); return ret; }