| Message ID | 1521525707-23927-1-git-send-email-mgautam@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Kishon, On 3/20/2018 11:31 AM, Manu Gautam wrote: > phy_init() and phy_exit() calls, and phy_power_on() and > phy_power_off() already accept NULL as valid PHY reference > and act as NOP. Extend same concept to phy runtime_pm APIs > to keep drivers (e.g. dwc3) code simple while dealing with > optional PHYs. Wondering if you had a chance to review this.
On Tuesday 20 March 2018 11:31 AM, Manu Gautam wrote: > phy_init() and phy_exit() calls, and phy_power_on() and > phy_power_off() already accept NULL as valid PHY reference > and act as NOP. Extend same concept to phy runtime_pm APIs > to keep drivers (e.g. dwc3) code simple while dealing with > optional PHYs. > > Signed-off-by: Manu Gautam <mgautam@codeaurora.org> merged, thanks! -Kishon > --- > Changes for v2: > - Fixed compilation warning > > drivers/phy/phy-core.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > index 3c31ce5..1fda576 100644 > --- a/drivers/phy/phy-core.c > +++ b/drivers/phy/phy-core.c > @@ -153,6 +153,9 @@ int phy_pm_runtime_get(struct phy *phy) > { > int ret; > > + if (!phy) > + return 0; > + > if (!pm_runtime_enabled(&phy->dev)) > return -ENOTSUPP; > > @@ -168,6 +171,9 @@ int phy_pm_runtime_get_sync(struct phy *phy) > { > int ret; > > + if (!phy) > + return 0; > + > if (!pm_runtime_enabled(&phy->dev)) > return -ENOTSUPP; > > @@ -181,6 +187,9 @@ int phy_pm_runtime_get_sync(struct phy *phy) > > int phy_pm_runtime_put(struct phy *phy) > { > + if (!phy) > + return 0; > + > if (!pm_runtime_enabled(&phy->dev)) > return -ENOTSUPP; > > @@ -190,6 +199,9 @@ int phy_pm_runtime_put(struct phy *phy) > > int phy_pm_runtime_put_sync(struct phy *phy) > { > + if (!phy) > + return 0; > + > if (!pm_runtime_enabled(&phy->dev)) > return -ENOTSUPP; > > @@ -199,6 +211,9 @@ int phy_pm_runtime_put_sync(struct phy *phy) > > void phy_pm_runtime_allow(struct phy *phy) > { > + if (!phy) > + return; > + > if (!pm_runtime_enabled(&phy->dev)) > return; > > @@ -208,6 +223,9 @@ void phy_pm_runtime_allow(struct phy *phy) > > void phy_pm_runtime_forbid(struct phy *phy) > { > + if (!phy) > + return; > + > if (!pm_runtime_enabled(&phy->dev)) > return; > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 3c31ce5..1fda576 100644 --- a/drivers/phy/phy-core.c +++ b/drivers/phy/phy-core.c @@ -153,6 +153,9 @@ int phy_pm_runtime_get(struct phy *phy) { int ret; + if (!phy) + return 0; + if (!pm_runtime_enabled(&phy->dev)) return -ENOTSUPP; @@ -168,6 +171,9 @@ int phy_pm_runtime_get_sync(struct phy *phy) { int ret; + if (!phy) + return 0; + if (!pm_runtime_enabled(&phy->dev)) return -ENOTSUPP; @@ -181,6 +187,9 @@ int phy_pm_runtime_get_sync(struct phy *phy) int phy_pm_runtime_put(struct phy *phy) { + if (!phy) + return 0; + if (!pm_runtime_enabled(&phy->dev)) return -ENOTSUPP; @@ -190,6 +199,9 @@ int phy_pm_runtime_put(struct phy *phy) int phy_pm_runtime_put_sync(struct phy *phy) { + if (!phy) + return 0; + if (!pm_runtime_enabled(&phy->dev)) return -ENOTSUPP; @@ -199,6 +211,9 @@ int phy_pm_runtime_put_sync(struct phy *phy) void phy_pm_runtime_allow(struct phy *phy) { + if (!phy) + return; + if (!pm_runtime_enabled(&phy->dev)) return; @@ -208,6 +223,9 @@ void phy_pm_runtime_allow(struct phy *phy) void phy_pm_runtime_forbid(struct phy *phy) { + if (!phy) + return; + if (!pm_runtime_enabled(&phy->dev)) return;
phy_init() and phy_exit() calls, and phy_power_on() and phy_power_off() already accept NULL as valid PHY reference and act as NOP. Extend same concept to phy runtime_pm APIs to keep drivers (e.g. dwc3) code simple while dealing with optional PHYs. Signed-off-by: Manu Gautam <mgautam@codeaurora.org> --- Changes for v2: - Fixed compilation warning drivers/phy/phy-core.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)