From patchwork Thu Mar 22 08:50:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manu Gautam X-Patchwork-Id: 10300999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0A24A60349 for ; Thu, 22 Mar 2018 08:53:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F073628FE8 for ; Thu, 22 Mar 2018 08:53:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E41342997B; Thu, 22 Mar 2018 08:53:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E84C28FE8 for ; Thu, 22 Mar 2018 08:53:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbeCVIv0 (ORCPT ); Thu, 22 Mar 2018 04:51:26 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38608 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbeCVIvU (ORCPT ); Thu, 22 Mar 2018 04:51:20 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1DA4660312; Thu, 22 Mar 2018 08:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521708680; bh=zW8gwN2xBaQ+o40Oh619Mh7SE0QP+OAoyw9M4j7ZNZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T24e9leRhM9a1zFi0NPkboBGZIwgCRb/yLQQ89CC1SkSMySiIHQw7iRgBxdqoTqZr 1piCTL0f+kvwx2pFSWSkmdvg3XWeWW/M0MkXBumMRCvZGlT2OisSVtiXR2FgU4pWe5 EnyRhtjb58UgatnDdEBbslXfMpUpVCMfwfXRy9Rw= Received: from mgautam-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 100D660314; Thu, 22 Mar 2018 08:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521708679; bh=zW8gwN2xBaQ+o40Oh619Mh7SE0QP+OAoyw9M4j7ZNZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KaRyFQUl3MnyuNbOsrQ5iE6+JR4LZbIITSSjPJPOucgAeTLbuLHo0TkHs7ePZ2RjN 6/JfDhdcA0YSRitR6RE7wBgFo9yw4d2hCJ0PpEVO1/edHM6Mb/s4AJ4zKRt75t+2Ak /COYBLYZx47wWERlxa0muFGiOwT6od1bIf36LMwc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 100D660314 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org From: Manu Gautam To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-arm-msm@vger.kernel.org, Manu Gautam , stable , Vivek Gautam , Krzysztof Kozlowski , Heiko Stuebner Subject: [PATCH v2 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified Date: Thu, 22 Mar 2018 14:20:42 +0530 Message-Id: <1521708646-5379-3-git-send-email-mgautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521708646-5379-1-git-send-email-mgautam@codeaurora.org> References: <1521708646-5379-1-git-send-email-mgautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver currently crashes due to NULL pointer deference while updating PHY tune register if nvmem cell is NULL. Since, fused value for Tune1/2 register is optional, we'd rather bail out. Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips") Reviewed-by: Vivek Gautam Cc: stable # 4.14+ Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 94afeac..40fdef8 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -315,6 +315,10 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy) const struct qusb2_phy_cfg *cfg = qphy->cfg; u8 *val; + /* efuse register is optional */ + if (!qphy->cell) + return; + /* * Read efuse register having TUNE2/1 parameter's high nibble. * If efuse register shows value as 0x0, or if we fail to find