diff mbox

[v4,10/14] dt-bindings: Add support for SAW documentation

Message ID 1522358807-10413-11-git-send-email-ilialin@codeaurora.org (mailing list archive)
State Changes Requested
Delegated to: Andy Gross
Headers show

Commit Message

Ilia Lin March 29, 2018, 9:26 p.m. UTC
Add support for SAW controlled regulators in 8x96.
Document it.

Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
---
 .../bindings/regulator/qcom,spmi-regulator.txt     | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)

Comments

Rob Herring April 9, 2018, 8:21 p.m. UTC | #1
On Fri, Mar 30, 2018 at 12:26:43AM +0300, Ilia Lin wrote:
> Add support for SAW controlled regulators in 8x96.
> Document it.

Perhaps some clue in the subject what subsystem and/or device this 
applies to.

> 
> Signed-off-by: Ilia Lin <ilialin@codeaurora.org>
> ---
>  .../bindings/regulator/qcom,spmi-regulator.txt     | 45 ++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> index 57d2c65..406f2e5 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
> @@ -110,6 +110,11 @@ Qualcomm SPMI Regulators
>  	Definition: Reference to regulator supplying the input pin, as
>  		    described in the data sheet.
>  
> +- qcom,saw-reg:
> +	Usage: optional
> +	Value type: <phandle>
> +	Description: Reference to syscon node defining the SAW registers.
> +
>  
>  The regulator node houses sub-nodes for each regulator within the device. Each
>  sub-node is identified using the node's name, with valid values listed for each
> @@ -201,6 +206,17 @@ see regulator.txt - with additional custom properties described below:
>  			2 = 0.55 uA
>  			3 = 0.75 uA
>  
> +- qcom,saw-slave:
> +	Usage: optional
> +	Value type: <boo>
> +	Description: SAW controlled gang slave. Will not be configured.
> +
> +- qcom,saw-leader:
> +	Usage: optional
> +	Value type: <boo>
> +	Description: SAW controlled gang leader. Will be configured as
> +		     SAW regulator.

Would the coupled regulator binding work in this case?

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown April 17, 2018, 11:09 a.m. UTC | #2
On Mon, Apr 09, 2018 at 03:21:44PM -0500, Rob Herring wrote:
> On Fri, Mar 30, 2018 at 12:26:43AM +0300, Ilia Lin wrote:
> > Add support for SAW controlled regulators in 8x96.
> > Document it.

> Perhaps some clue in the subject what subsystem and/or device this 
> applies to.

Right, especially given that if people can't find the documentation for
driver binding changes that's likely to be one of the first compliants.

> > +- qcom,saw-leader:
> > +	Usage: optional
> > +	Value type: <boo>
> > +	Description: SAW controlled gang leader. Will be configured as
> > +		     SAW regulator.

> Would the coupled regulator binding work in this case?

Someone would need to get the code working first though depending on
what the hardware does that might not be the right thing.  It's fairly
common to have hardware support for grouping multiple physical
regulators together into a single supply in order to provide more
current with all the control being done from one of the regulators.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
index 57d2c65..406f2e5 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/qcom,spmi-regulator.txt
@@ -110,6 +110,11 @@  Qualcomm SPMI Regulators
 	Definition: Reference to regulator supplying the input pin, as
 		    described in the data sheet.
 
+- qcom,saw-reg:
+	Usage: optional
+	Value type: <phandle>
+	Description: Reference to syscon node defining the SAW registers.
+
 
 The regulator node houses sub-nodes for each regulator within the device. Each
 sub-node is identified using the node's name, with valid values listed for each
@@ -201,6 +206,17 @@  see regulator.txt - with additional custom properties described below:
 			2 = 0.55 uA
 			3 = 0.75 uA
 
+- qcom,saw-slave:
+	Usage: optional
+	Value type: <boo>
+	Description: SAW controlled gang slave. Will not be configured.
+
+- qcom,saw-leader:
+	Usage: optional
+	Value type: <boo>
+	Description: SAW controlled gang leader. Will be configured as
+		     SAW regulator.
+
 Example:
 
 	regulators {
@@ -221,3 +237,32 @@  Example:
 
 		....
 	};
+
+Example 2:
+
+	saw3: syscon@9A10000 {
+		compatible = "syscon";
+		reg = <0x9A10000 0x1000>;
+	};
+
+	...
+
+	spm-regulators {
+		compatible = "qcom,pm8994-regulators";
+		qcom,saw-reg = <&saw3>;
+		s8 {
+			qcom,saw-slave;
+		};
+		s9 {
+			qcom,saw-slave;
+		};
+		s10 {
+			qcom,saw-slave;
+		};
+		pm8994_s11_saw: s11 {
+			qcom,saw-leader;
+			regulator-always-on;
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <1140000>;
+		};
+	};