From patchwork Mon Apr 9 19:38:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan Ramasubramanian X-Patchwork-Id: 10331949 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95FEE6037F for ; Mon, 9 Apr 2018 19:39:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8725F28BF0 for ; Mon, 9 Apr 2018 19:39:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BA7628BF4; Mon, 9 Apr 2018 19:39:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2246E28BF0 for ; Mon, 9 Apr 2018 19:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144AbeDITjF (ORCPT ); Mon, 9 Apr 2018 15:39:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42864 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753459AbeDITjE (ORCPT ); Mon, 9 Apr 2018 15:39:04 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C80C060D81; Mon, 9 Apr 2018 19:39:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1523302743; bh=B65Adw1fXNXnLykvVWkYFArA6UT6vhyX4/vQBs8k7pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FSrrmOBkkwTjrJnNw6fB3PrLJi95zA6mNOM+xoUNp+Lnk9x1aqWR/pK+Jc5TRG6Oi A6NnV6v06COuNmzG1ScwDFXFu00GP0fIp+Gsd7FpCwGGs/MG/ndnFas0fYYr5jMK2a 1seE/mR7hklTCcaIQckTEHhQ7BUhyo9JSxWcd0Us= Received: from codeaurora.org (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kramasub@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2412560FF3; Mon, 9 Apr 2018 19:38:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1523302739; bh=B65Adw1fXNXnLykvVWkYFArA6UT6vhyX4/vQBs8k7pk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=myyb1cvRHeyO6iKDUOwFTLydYCD+5cvU2gYUnRXI/EauwYS6sdExpPszY0FqyxzLi JtF84WyEKy/qLuhKfqwlFljFLvFhfwB/tmgxdcnQujcdY4cFG8u00LJJO/Oxu+tv/V VE9Jx9dLpRdG1+Ge7Y2eESzOOT4f6yWFmNI36/8o= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2412560FF3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kramasub@codeaurora.org From: Karthikeyan Ramasubramanian To: gregkh@linuxfoundation.org, jslaby@suse.com Cc: Karthikeyan Ramasubramanian , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, evgreen@chromium.org, acourbot@chromium.org, swboyd@chromium.org, dianders@chromium.org, sdharia@codeaurora.org, girishm@codeaurora.org, festevam@gmail.com Subject: [PATCH v2 7/8] tty: serial: qcom_geni_serial: Return IRQ_NONE for spurious interrupts Date: Mon, 9 Apr 2018 13:38:40 -0600 Message-Id: <1523302721-19439-8-git-send-email-kramasub@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1523302721-19439-1-git-send-email-kramasub@codeaurora.org> References: <1523302721-19439-1-git-send-email-kramasub@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently the driver returns IRQ_HANDLED when spurious interrupts happen. This is misleading. Fix the behavior by returning IRQ_NONE for spurious interrupts. Signed-off-by: Karthikeyan Ramasubramanian Reviewed-by: Matthias Kaehlcke Reviewed-by: Stephen Boyd --- drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 801e6eb..e40d4a4 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -633,7 +633,7 @@ static irqreturn_t qcom_geni_serial_isr(int isr, void *dev) struct qcom_geni_serial_port *port = to_dev_port(uport, uport); if (uport->suspended) - return IRQ_HANDLED; + return IRQ_NONE; spin_lock_irqsave(&uport->lock, flags); m_irq_status = readl_relaxed(uport->membase + SE_GENI_M_IRQ_STATUS);