From patchwork Wed May 2 21:06:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manu Gautam X-Patchwork-Id: 10376553 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18D576038F for ; Wed, 2 May 2018 21:08:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0993628FF6 for ; Wed, 2 May 2018 21:08:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F298929023; Wed, 2 May 2018 21:08:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B3EA28FF6 for ; Wed, 2 May 2018 21:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751618AbeEBVIH (ORCPT ); Wed, 2 May 2018 17:08:07 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59664 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbeEBVGp (ORCPT ); Wed, 2 May 2018 17:06:45 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8D82560310; Wed, 2 May 2018 21:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525295204; bh=wY1u/y7YYuZyKb5K1mf2Z6OpsGfhhFaI8QOi9PLKQfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVKpCW507I1QpLlKyNXFvltXoAswAg8WzRQeO5abshRBEehlyhSi0ddyjh+ZzWg0z Wf5HbcG/88dQkzSIdyghgQ56iV8POHXkUd3yIJGLyCEPvbNnHqEyBk5Jt33uC3VXGP p3/SQjCJ5r7ti3/uZQLsGU52i1iBcGBhOnxs52R8= Received: from mgautam-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 098766090E; Wed, 2 May 2018 21:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1525295203; bh=wY1u/y7YYuZyKb5K1mf2Z6OpsGfhhFaI8QOi9PLKQfo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I34S0OlBpQoD1Qm8T4Oghl+leIqoPqIvLmZy9MZPDa8CE+/7EjOv53qaN5im4RsdH bZ5YwRrSWTYx5kqAXMPvmguvQBiyq6WQJB+631uYZ/HU+tghzCLu1RS+WKtJxzLxVG /fClLjElkC6M17YDYgrr4T5T4yFMRO34sYVAiEF0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 098766090E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org From: Manu Gautam To: Kishon Vijay Abraham I , robh@kernel.org, sboyd@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, evgreen@chromium.org, Vivek Gautam , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Manu Gautam , stable Subject: [PATCH v5 3/7] phy: qcom-qusb2: Fix crash if nvmem cell not specified Date: Thu, 3 May 2018 02:36:10 +0530 Message-Id: <1525295174-15995-4-git-send-email-mgautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1525295174-15995-1-git-send-email-mgautam@codeaurora.org> References: <1525295174-15995-1-git-send-email-mgautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver currently crashes due to NULL pointer deference while updating PHY tune register if nvmem cell is NULL. Since, fused value for Tune1/2 register is optional, we'd rather bail out. Fixes: ca04d9d3e1b1 ("phy: qcom-qusb2: New driver for QUSB2 PHY on Qcom chips") Reviewed-by: Vivek Gautam Reviewed-by: Evan Green Cc: stable # 4.14+ Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 94afeac..40fdef8 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -315,6 +315,10 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy) const struct qusb2_phy_cfg *cfg = qphy->cfg; u8 *val; + /* efuse register is optional */ + if (!qphy->cell) + return; + /* * Read efuse register having TUNE2/1 parameter's high nibble. * If efuse register shows value as 0x0, or if we fail to find