Message ID | 1528723089-24904-1-git-send-email-loic.poulain@linaro.org (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Andy Gross |
Headers | show |
Hi David, Andy, On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote: > Current LED trigger, 'bt', is not known/used by any existing driver. > Fix this by renaming it to 'bluetooth-power' trigger which is > controlled by the Bluetooth subsystem. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Any comments ? -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 10, 2018 at 03:10:58PM +0200, Loic Poulain wrote: > Hi David, Andy, > > On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote: > > Current LED trigger, 'bt', is not known/used by any existing driver. > > Fix this by renaming it to 'bluetooth-power' trigger which is > > controlled by the Bluetooth subsystem. > > > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Any comments ? Hello Loic, Perhaps a Fixes-tag would be nice here? Kind regards, Niklas > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 10, 2018 at 04:33:08PM +0200, Niklas Cassel wrote: > On Tue, Jul 10, 2018 at 03:10:58PM +0200, Loic Poulain wrote: > > Hi David, Andy, > > > > On 11 June 2018 at 15:18, Loic Poulain <loic.poulain@linaro.org> wrote: > > > Current LED trigger, 'bt', is not known/used by any existing driver. > > > Fix this by renaming it to 'bluetooth-power' trigger which is > > > controlled by the Bluetooth subsystem. > > > > > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > > > --- > > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Any comments ? > > Hello Loic, > > Perhaps a Fixes-tag would be nice here? Agreed, can you put a Fixes tag on this? Andy -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi index 4c3dda5..16f6477 100644 --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi @@ -188,7 +188,7 @@ led@6 { label = "apq8016-sbc:blue:bt"; gpios = <&pm8916_mpps 3 GPIO_ACTIVE_HIGH>; - linux,default-trigger = "bt"; + linux,default-trigger = "bluetooth-power"; default-state = "off"; }; };
Current LED trigger, 'bt', is not known/used by any existing driver. Fix this by renaming it to 'bluetooth-power' trigger which is controlled by the Bluetooth subsystem. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)