From patchwork Tue Jan 22 06:33:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alok Chauhan X-Patchwork-Id: 10774895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A38EB13B5 for ; Tue, 22 Jan 2019 06:34:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9176B2AF5E for ; Tue, 22 Jan 2019 06:34:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F4672AF6D; Tue, 22 Jan 2019 06:34:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBB762AF65 for ; Tue, 22 Jan 2019 06:34:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727068AbfAVGeZ (ORCPT ); Tue, 22 Jan 2019 01:34:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:39384 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726174AbfAVGeZ (ORCPT ); Tue, 22 Jan 2019 01:34:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 595A66085C; Tue, 22 Jan 2019 06:34:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548138863; bh=at+FEdyRz0FwX5d+J9l/6gAU1xPYbUqvsAjyr/pNn5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U/dcoI34NMYzysuuUpBMhOAFCnsWChrP04JlgCVxFCxtCew5fWIyS5YTFBHpyZYF9 JRwZTw4++A5c4huYhxbLT1tHkdnDYi1t5M8bHb3Dqbs7glRkBgEApHp0u4x58tUlpY dZECCx7pwLGP8cGiqvcmsOY8dqLj2CqZivXE8WUQ= Received: from alokc-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: alokc@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0F666608EA; Tue, 22 Jan 2019 06:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548138861; bh=at+FEdyRz0FwX5d+J9l/6gAU1xPYbUqvsAjyr/pNn5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oC/NKwmFzfT/Pk9DRoA2bRjRNtC3oGhZdtS/tzUfq8OcnBJsgeP5WrLJOv/8tYLa2 BxfhOUcep2Y21/dt46sY4P/krJQc4l82kkjYh8rUYO4+qs8W9bMfqrtKSUM5EvaEqc wrvM6Rl4DM59HQbUG05okJwtoz523unuJiVgZ2WY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F666608EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=alokc@codeaurora.org From: Alok Chauhan To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, Andy Gross , David Brown , Stephen Boyd , Douglas Anderson , Bjorn Andersson , Karthikeyan Ramasubramanian , Alok Chauhan Cc: georgi.djakov@linaro.org Subject: [PATCH 2/6] soc: qcom: Add wrapper to support for Interconnect path Date: Tue, 22 Jan 2019 12:03:32 +0530 Message-Id: <1548138816-1149-3-git-send-email-alokc@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1548138816-1149-1-git-send-email-alokc@codeaurora.org> References: <1548138816-1149-1-git-send-email-alokc@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add the wrapper to support for interconnect path voting from GENI QUP. This wrapper provides the functionalities to individual Serial Engine device to get the interconnect path and to vote for bandwidth based on their need. This wrapper maintains bandwidth votes from each Serial Engine and send the aggregated vote from GENI QUP to interconnect framework. Signed-off-by: Alok Chauhan --- drivers/soc/qcom/qcom-geni-se.c | 129 ++++++++++++++++++++++++++++++++++++++++ include/linux/qcom-geni-se.h | 11 ++++ 2 files changed, 140 insertions(+) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index 6b8ef01..1d8dcb1 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -11,6 +11,7 @@ #include #include #include +#include /** * DOC: Overview @@ -84,11 +85,21 @@ * @dev: Device pointer of the QUP wrapper core * @base: Base address of this instance of QUP wrapper core * @ahb_clks: Handle to the primary & secondary AHB clocks + * @icc_path: Array of interconnect path handles + * @geni_wrapper_lock: Lock to protect the bus bandwidth request + * @cur_avg_bw: Current Bus Average BW request value from GENI QUP + * @cur_peak_bw: Current Bus Peak BW request value from GENI QUP + * @peak_bw_list_head: Sorted resource list based on peak bus BW */ struct geni_wrapper { struct device *dev; void __iomem *base; struct clk_bulk_data ahb_clks[NUM_AHB_CLKS]; + struct icc_path *icc_path[2]; + struct mutex geni_wrapper_lock; + u32 cur_avg_bw; + u32 cur_peak_bw; + struct list_head peak_bw_list_head; }; #define QUP_HW_VER_REG 0x4 @@ -440,6 +451,71 @@ static void geni_se_clks_off(struct geni_se *se) } /** + * geni_icc_update_bw() - Request to update bw vote on an interconnect path + * @se: Pointer to the concerned serial engine. + * @update: Flag to update bw vote. + * + * This function is used to request set bw vote on interconnect path handle. + */ +void geni_icc_update_bw(struct geni_se *se, bool update) +{ + struct geni_se *temp = NULL; + struct list_head *ins_list_head; + struct geni_wrapper *wrapper; + + mutex_lock(&se->wrapper->geni_wrapper_lock); + + wrapper = se->wrapper; + + if (update) { + wrapper->cur_avg_bw += se->avg_bw; + ins_list_head = &wrapper->peak_bw_list_head; + list_for_each_entry(temp, &wrapper->peak_bw_list_head, + peak_bw_list) { + if (temp->peak_bw < se->peak_bw) + break; + ins_list_head = &temp->peak_bw_list; + } + + list_add(&se->peak_bw_list, ins_list_head); + + if (ins_list_head == &wrapper->peak_bw_list_head) + wrapper->cur_peak_bw = se->peak_bw; + } else { + if (unlikely(list_empty(&se->peak_bw_list))) { + mutex_unlock(&wrapper->geni_wrapper_lock); + return; + } + + wrapper->cur_avg_bw -= se->avg_bw; + + list_del_init(&se->peak_bw_list); + temp = list_first_entry_or_null(&wrapper->peak_bw_list_head, + struct geni_se, peak_bw_list); + if (temp && temp->peak_bw != wrapper->cur_peak_bw) + wrapper->cur_peak_bw = temp->peak_bw; + else if (!temp && wrapper->cur_peak_bw) + wrapper->cur_peak_bw = 0; + } + + /* + * This bw vote is to enable internal QUP core clock as well as to + * enable path towards memory. + */ + icc_set_bw(wrapper->icc_path[0], wrapper->cur_avg_bw, + wrapper->cur_peak_bw); + + /* + * This is just register configuration path so doesn't need avg bw. + * Set only peak bw to enable this path. + */ + icc_set_bw(wrapper->icc_path[1], 0, wrapper->cur_peak_bw); + + mutex_unlock(&wrapper->geni_wrapper_lock); +} +EXPORT_SYMBOL(geni_icc_update_bw); + +/** * geni_se_resources_off() - Turn off resources associated with the serial * engine * @se: Pointer to the concerned serial engine. @@ -707,6 +783,47 @@ void geni_se_rx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len) } EXPORT_SYMBOL(geni_se_rx_dma_unprep); +/** + * geni_interconnect_init() - Request to get interconnect path handle + * @se: Pointer to the concerned serial engine. + * + * This function is used to get interconnect path handle. + */ +int geni_interconnect_init(struct geni_se *se) +{ + struct geni_wrapper *wrapper_rsc; + + if (unlikely(!se || !se->wrapper)) + return -EINVAL; + + wrapper_rsc = se->wrapper; + + if ((IS_ERR_OR_NULL(wrapper_rsc->icc_path[0]) || + IS_ERR_OR_NULL(wrapper_rsc->icc_path[1]))) { + + wrapper_rsc->icc_path[0] = of_icc_get(wrapper_rsc->dev, + "qup-memory"); + if (IS_ERR(wrapper_rsc->icc_path[0])) + return PTR_ERR(wrapper_rsc->icc_path[0]); + + wrapper_rsc->icc_path[1] = of_icc_get(wrapper_rsc->dev, + "qup-config"); + if (IS_ERR(wrapper_rsc->icc_path[1])) { + icc_put(wrapper_rsc->icc_path[0]); + wrapper_rsc->icc_path[0] = NULL; + return PTR_ERR(wrapper_rsc->icc_path[1]); + } + + INIT_LIST_HEAD(&wrapper_rsc->peak_bw_list_head); + mutex_init(&wrapper_rsc->geni_wrapper_lock); + } + + INIT_LIST_HEAD(&se->peak_bw_list); + + return 0; +} +EXPORT_SYMBOL(geni_interconnect_init); + static int geni_se_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; @@ -737,6 +854,17 @@ static int geni_se_probe(struct platform_device *pdev) return devm_of_platform_populate(dev); } +static int geni_se_remove(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct geni_wrapper *wrapper = dev_get_drvdata(dev); + + icc_put(wrapper->icc_path[0]); + icc_put(wrapper->icc_path[1]); + + return 0; +} + static const struct of_device_id geni_se_dt_match[] = { { .compatible = "qcom,geni-se-qup", }, {} @@ -749,6 +877,7 @@ static int geni_se_probe(struct platform_device *pdev) .of_match_table = geni_se_dt_match, }, .probe = geni_se_probe, + .remove = geni_se_remove, }; module_platform_driver(geni_se_driver); diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h index 3bcd67f..9bf03e9 100644 --- a/include/linux/qcom-geni-se.h +++ b/include/linux/qcom-geni-se.h @@ -33,6 +33,10 @@ enum geni_se_protocol_type { * @clk: Handle to the core serial engine clock * @num_clk_levels: Number of valid clock levels in clk_perf_tbl * @clk_perf_tbl: Table of clock frequency input to serial engine clock + * @avg_bw: Average bus bandwidth value for Serial Engine device + * @peak_bw: Peak bus bandwidth value for Serial Engine device + * @peak_bw_list: List Head of peak bus banwidth list for Serial Engine + * device */ struct geni_se { void __iomem *base; @@ -41,6 +45,9 @@ struct geni_se { struct clk *clk; unsigned int num_clk_levels; unsigned long *clk_perf_tbl; + u32 avg_bw; + u32 peak_bw; + struct list_head peak_bw_list; }; /* Common SE registers */ @@ -416,5 +423,9 @@ int geni_se_rx_dma_prep(struct geni_se *se, void *buf, size_t len, void geni_se_tx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len); void geni_se_rx_dma_unprep(struct geni_se *se, dma_addr_t iova, size_t len); + +int geni_interconnect_init(struct geni_se *se); + +void geni_icc_update_bw(struct geni_se *se, bool update); #endif #endif