| Message ID | 1553689723-21017-3-git-send-email-c-hbandi@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable Bluetooth functionality for WCN3998. | expand |
On Wed, Mar 27, 2019 at 05:58:43PM +0530, Harish Bandi wrote: > This patch enables regulators for the Qualcomm Bluetooth WCN3998 > controller. I commented on this on v3, but you didn't update it: No, it doesn't. The next version should probably say something like "Add compatible string for the Qualcomm WCN3998 Bluetooth controller". Thanks Matthias
Hi Matthias, On 2019-03-27 22:59, Matthias Kaehlcke wrote: > On Wed, Mar 27, 2019 at 05:58:43PM +0530, Harish Bandi wrote: >> This patch enables regulators for the Qualcomm Bluetooth WCN3998 >> controller. > > I commented on this on v3, but you didn't update it: > > No, it doesn't. > > The next version should probably say something like "Add compatible > string for the Qualcomm WCN3998 Bluetooth controller". > [Harish] - will take care in next version. > Thanks > > Matthias
Hi Rob, Could you please help to review DT bindings patch. On 2019-03-27 17:58, Harish Bandi wrote: > This patch enables regulators for the Qualcomm Bluetooth WCN3998 > controller. > > Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> > --- > Changes in V6: > - no changes > --- > Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > index 824c0e2..7ef6118 100644 > --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > @@ -11,20 +11,21 @@ Required properties: > - compatible: should contain one of the following: > * "qcom,qca6174-bt" > * "qcom,wcn3990-bt" > + * "qcom,wcn3998-bt" > > Optional properties for compatible string qcom,qca6174-bt: > > - enable-gpios: gpio specifier used to enable chip > - clocks: clock provided to the controller (SUSCLK_32KHZ) > > -Required properties for compatible string qcom,wcn3990-bt: > +Required properties for compatible string qcom,wcn399x-bt: > > - vddio-supply: VDD_IO supply regulator handle. > - vddxo-supply: VDD_XO supply regulator handle. > - vddrf-supply: VDD_RF supply regulator handle. > - vddch0-supply: VDD_CH0 supply regulator handle. > > -Optional properties for compatible string qcom,wcn3990-bt: > +Optional properties for compatible string qcom,wcn399x-bt: > > - max-speed: see > Documentation/devicetree/bindings/serial/slave-device.txt Thanks, Harish
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt index 824c0e2..7ef6118 100644 --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt @@ -11,20 +11,21 @@ Required properties: - compatible: should contain one of the following: * "qcom,qca6174-bt" * "qcom,wcn3990-bt" + * "qcom,wcn3998-bt" Optional properties for compatible string qcom,qca6174-bt: - enable-gpios: gpio specifier used to enable chip - clocks: clock provided to the controller (SUSCLK_32KHZ) -Required properties for compatible string qcom,wcn3990-bt: +Required properties for compatible string qcom,wcn399x-bt: - vddio-supply: VDD_IO supply regulator handle. - vddxo-supply: VDD_XO supply regulator handle. - vddrf-supply: VDD_RF supply regulator handle. - vddch0-supply: VDD_CH0 supply regulator handle. -Optional properties for compatible string qcom,wcn3990-bt: +Optional properties for compatible string qcom,wcn399x-bt: - max-speed: see Documentation/devicetree/bindings/serial/slave-device.txt
This patch enables regulators for the Qualcomm Bluetooth WCN3998 controller. Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org> --- Changes in V6: - no changes --- Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)