| Message ID | 1578486581-7540-3-git-send-email-sanm@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add QMP V3 USB3 PHY support for SC7180 | expand |
Quoting Sandeep Maheswaram (2020-01-08 04:29:40) > Remove global phy reset and do only usb phy reset in QMP phy. Yes that's what this patch does, but you left out the important part: Why? > > Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index c00c3d4..448ab88 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1072,9 +1072,8 @@ > <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>; > clock-names = "aux", "cfg_ahb", "ref", "com_aux"; > > - resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>, > - <&gcc GCC_USB3_PHY_PRIM_BCR>; > - reset-names = "phy", "common"; > + resets = <&gcc GCC_USB3_PHY_PRIM_BCR>; > + reset-names = "phy"; > We shouldn't need to modify the DT node for this. The reset still goes to this hardware block, so DT should reflect that. Instead, the driver shouldn't drive this reset on this SoC. > usb_1_ssphy: phy@88e9200 { > reg = <0 0x088e9200 0 0x128>,
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index c00c3d4..448ab88 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1072,9 +1072,8 @@ <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>; clock-names = "aux", "cfg_ahb", "ref", "com_aux"; - resets = <&gcc GCC_USB3_DP_PHY_PRIM_BCR>, - <&gcc GCC_USB3_PHY_PRIM_BCR>; - reset-names = "phy", "common"; + resets = <&gcc GCC_USB3_PHY_PRIM_BCR>; + reset-names = "phy"; usb_1_ssphy: phy@88e9200 { reg = <0 0x088e9200 0 0x128>,
Remove global phy reset and do only usb phy reset in QMP phy. Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)