diff mbox series

soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all()

Message ID 1579681417-1155-1-git-send-email-aneela@codeaurora.org (mailing list archive)
State Accepted
Commit f4d590caa66e3aaffc91c87e9ca366a02353f652
Headers show
Series soc: qcom: aoss: Use wake_up_all() instead of wake_up_interruptible_all() | expand

Commit Message

Arun Kumar Neelakantam Jan. 22, 2020, 8:23 a.m. UTC
During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
cannot be woken-up by wake_up_interruptible_all() function.

Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
TASK_INTERRUPTIBLE state tasks.

Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
 drivers/soc/qcom/qcom_aoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Andersson Feb. 12, 2020, 6:31 a.m. UTC | #1
On Wed 22 Jan 00:23 PST 2020, Arun Kumar Neelakantam wrote:

> During the probe the task is waiting in TASK_UNINTERRUPTIBLE state which
> cannot be woken-up by wake_up_interruptible_all() function.
> 
> Use wake_up_all() to wake-up both TASK_UNINTERRUPTIBLE and
> TASK_INTERRUPTIBLE state tasks.
> 
> Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>

Applied

Regards,
Bjorn

> ---
>  drivers/soc/qcom/qcom_aoss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> index 006ac40..fe79661 100644
> --- a/drivers/soc/qcom/qcom_aoss.c
> +++ b/drivers/soc/qcom/qcom_aoss.c
> @@ -200,7 +200,7 @@ static irqreturn_t qmp_intr(int irq, void *data)
>  {
>  	struct qmp *qmp = data;
>  
> -	wake_up_interruptible_all(&qmp->event);
> +	wake_up_all(&qmp->event);
>  
>  	return IRQ_HANDLED;
>  }
> -- 
> 1.9.1
diff mbox series

Patch

diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
index 006ac40..fe79661 100644
--- a/drivers/soc/qcom/qcom_aoss.c
+++ b/drivers/soc/qcom/qcom_aoss.c
@@ -200,7 +200,7 @@  static irqreturn_t qmp_intr(int irq, void *data)
 {
 	struct qmp *qmp = data;
 
-	wake_up_interruptible_all(&qmp->event);
+	wake_up_all(&qmp->event);
 
 	return IRQ_HANDLED;
 }