diff mbox series

[1/3] dt-bindings: phy: qcom,qmp: Add ipq8074 usb dt bindings

Message ID 1586543372-13969-2-git-send-email-sivaprak@codeaurora.org (mailing list archive)
State Superseded
Headers show
Series Enable USB support in IPQ8074 | expand

Commit Message

Sivaprakash Murugesan April 10, 2020, 6:29 p.m. UTC
Add ipq8074 qmp phy device compatible for usb super speed usb support.

Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
---
 Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bjorn Andersson April 10, 2020, 10:05 p.m. UTC | #1
On Fri 10 Apr 11:29 PDT 2020, Sivaprakash Murugesan wrote:

> Add ipq8074 qmp phy device compatible for usb super speed usb support.
> 
> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 18a8985..d60c845 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -18,6 +18,7 @@ properties:
>    compatible:
>      enum:
>        - qcom,ipq8074-qmp-pcie-phy
> +      - qcom,ipq8074-qmp-usb-phy

I believe you're missing a "3" here.

Regards,
Bjorn

>        - qcom,msm8996-qmp-pcie-phy
>        - qcom,msm8996-qmp-ufs-phy
>        - qcom,msm8996-qmp-usb3-phy
> @@ -166,6 +167,7 @@ allOf:
>          compatible:
>            contains:
>              enum:
> +              - qcom,ipq8074-qmp-usb3-phy
>                - qcom,msm8996-qmp-usb3-phy
>                - qcom,msm8998-qmp-pcie-phy
>                - qcom,msm8998-qmp-usb3-phy
> -- 
> 2.7.4
>
Sivaprakash Murugesan April 11, 2020, 12:45 a.m. UTC | #2
Hi Bjorn,

On 4/11/2020 3:35 AM, Bjorn Andersson wrote:
> On Fri 10 Apr 11:29 PDT 2020, Sivaprakash Murugesan wrote:
>
>> Add ipq8074 qmp phy device compatible for usb super speed usb support.
>>
>> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org>
>> ---
>>   Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
>> index 18a8985..d60c845 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
>> @@ -18,6 +18,7 @@ properties:
>>     compatible:
>>       enum:
>>         - qcom,ipq8074-qmp-pcie-phy
>> +      - qcom,ipq8074-qmp-usb-phy
> I believe you're missing a "3" here.
Yes. Will correct it in next patch set.
> Regards,
> Bjorn
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
index 18a8985..d60c845 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
@@ -18,6 +18,7 @@  properties:
   compatible:
     enum:
       - qcom,ipq8074-qmp-pcie-phy
+      - qcom,ipq8074-qmp-usb-phy
       - qcom,msm8996-qmp-pcie-phy
       - qcom,msm8996-qmp-ufs-phy
       - qcom,msm8996-qmp-usb3-phy
@@ -166,6 +167,7 @@  allOf:
         compatible:
           contains:
             enum:
+              - qcom,ipq8074-qmp-usb3-phy
               - qcom,msm8996-qmp-usb3-phy
               - qcom,msm8998-qmp-pcie-phy
               - qcom,msm8998-qmp-usb3-phy