| Message ID | 1588636467-23409-2-git-send-email-wcheng@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add SS/HS-USB changes for Qualcomm SM8150 chipset | expand |
On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote: > This binding shows the descriptions and properties for the > Synopsis Femto USB PHY V2 used on QCOM platforms. > > Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Stephen Boyd <sboyd@kernel.org> > --- > .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property See https://patchwork.ozlabs.org/patch/1283143 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On 5/5/2020 6:34 AM, Rob Herring wrote: > On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote: >> This binding shows the descriptions and properties for the >> Synopsis Femto USB PHY V2 used on QCOM platforms. >> >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Stephen Boyd <sboyd@kernel.org> >> --- >> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++ >> 1 file changed, 77 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property > > See https://patchwork.ozlabs.org/patch/1283143 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > Hi Rob, I updated the dt-schema version, and I can see the same error. Will fix and resubmit. I also realized that the dt_binding_check doesn't stop if errors are detected in the example DT checking phase, and that was probably why I missed this initially. I'll pass the DT_SCHEMA_FILES argument to my specific binding next time to help verify my file. Thanks again!
On 05-05-20, 12:38, Wesley Cheng wrote: > > > On 5/5/2020 6:34 AM, Rob Herring wrote: > > On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote: > >> This binding shows the descriptions and properties for the > >> Synopsis Femto USB PHY V2 used on QCOM platforms. > >> > >> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> > >> Reviewed-by: Rob Herring <robh@kernel.org> > >> Reviewed-by: Stephen Boyd <sboyd@kernel.org> > >> --- > >> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 77 ++++++++++++++++++++++ > >> 1 file changed, 77 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda-pll-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda18-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.example.dt.yaml: phy@88e2000: 'vdda33-supply' is a required property > > > > See https://patchwork.ozlabs.org/patch/1283143 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > > > > Hi Rob, > > I updated the dt-schema version, and I can see the same error. Will fix > and resubmit. I also realized that the dt_binding_check doesn't stop if No, pls submit the fix against already applied patches and also give credit to Rob by adding a "Reported-by: ..." > errors are detected in the example DT checking phase, and that was > probably why I missed this initially. I'll pass the DT_SCHEMA_FILES > argument to my specific binding next time to help verify my file. > Thanks again! > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml new file mode 100644 index 0000000..64d59c1 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/qcom,usb-snps-femto-v2.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Qualcomm Synopsys Femto High-Speed USB PHY V2 + +maintainers: + - Wesley Cheng <wcheng@codeaurora.org> + +description: | + Qualcomm High-Speed USB PHY + +properties: + compatible: + enum: + - qcom,usb-snps-hs-7nm-phy + - qcom,sm8150-usb-hs-phy + - qcom,usb-snps-femto-v2-phy + + reg: + maxItems: 1 + + "#phy-cells": + const: 0 + + clocks: + items: + - description: rpmhcc ref clock + + clock-names: + items: + - const: ref + + resets: + items: + - description: PHY core reset + + vdda-pll-supply: + description: phandle to the regulator VDD supply node. + + vdda18-supply: + description: phandle to the regulator 1.8V supply node. + + vdda33-supply: + description: phandle to the regulator 3.3V supply node. + +required: + - compatible + - reg + - "#phy-cells" + - clocks + - clock-names + - resets + - vdda-pll-supply + - vdda18-supply + - vdda33-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/clock/qcom,gcc-sm8150.h> + phy@88e2000 { + compatible = "qcom,sm8150-usb-hs-phy"; + reg = <0 0x088e2000 0 0x400>; + #phy-cells = <0>; + + clocks = <&rpmhcc RPMH_CXO_CLK>; + clock-names = "ref"; + + resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; + }; +... +