diff mbox series

[V6,3/3] dt-bindings: serial: Add binding for UART pin swap

Message ID 1588863647-17240-4-git-send-email-akashast@codeaurora.org (mailing list archive)
State Superseded
Headers show
Series Convert QUP bindings to YAML and add ICC, pin swap doc | expand

Commit Message

Akash Asthana May 7, 2020, 3 p.m. UTC
Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.

Signed-off-by: Akash Asthana <akashast@codeaurora.org>
---
 Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stephen Boyd May 14, 2020, 1:51 a.m. UTC | #1
Quoting Akash Asthana (2020-05-07 08:00:47)
> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
> 
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Rob Herring (Arm) May 15, 2020, 3:01 a.m. UTC | #2
On Thu, May 07, 2020 at 08:30:47PM +0530, Akash Asthana wrote:
> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
> 
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
> index 53204d9..e657dd6 100644
> --- a/Documentation/devicetree/bindings/serial/serial.yaml
> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
> @@ -67,6 +67,12 @@ properties:
>        (wired and enabled by pinmux configuration).  This depends on both the
>        UART hardware and the board wiring.
>  
> +  rx-tx-swap:
> +    description: RX and TX pins are swapped.
> +
> +  cts-rts-swap:
> +    description: CTS and RTS pins are swapped.

Need 'type: boolean' on both of these.

> +
>  if:
>    required:
>      - uart-has-rtscts
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
Akash Asthana May 18, 2020, 1:19 p.m. UTC | #3
Hi Rob,

On 5/15/2020 8:31 AM, Rob Herring wrote:
> On Thu, May 07, 2020 at 08:30:47PM +0530, Akash Asthana wrote:
>> Add documentation to support RX-TX & CTS-RTS GPIO pin swap in HW.
>>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>>   Documentation/devicetree/bindings/serial/serial.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
>> index 53204d9..e657dd6 100644
>> --- a/Documentation/devicetree/bindings/serial/serial.yaml
>> +++ b/Documentation/devicetree/bindings/serial/serial.yaml
>> @@ -67,6 +67,12 @@ properties:
>>         (wired and enabled by pinmux configuration).  This depends on both the
>>         UART hardware and the board wiring.
>>   
>> +  rx-tx-swap:
>> +    description: RX and TX pins are swapped.
>> +
>> +  cts-rts-swap:
>> +    description: CTS and RTS pins are swapped.
> Need 'type: boolean' on both of these.

okay, will correct in next version

Regards,

Akash

>
>> +
>>   if:
>>     required:
>>       - uart-has-rtscts
>> -- 
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/serial/serial.yaml b/Documentation/devicetree/bindings/serial/serial.yaml
index 53204d9..e657dd6 100644
--- a/Documentation/devicetree/bindings/serial/serial.yaml
+++ b/Documentation/devicetree/bindings/serial/serial.yaml
@@ -67,6 +67,12 @@  properties:
       (wired and enabled by pinmux configuration).  This depends on both the
       UART hardware and the board wiring.
 
+  rx-tx-swap:
+    description: RX and TX pins are swapped.
+
+  cts-rts-swap:
+    description: CTS and RTS pins are swapped.
+
 if:
   required:
     - uart-has-rtscts