| Message ID | 1589453659-27581-2-git-send-email-smasetty@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for GPU DDR BW scaling | expand |
Hi Sharat, On Thu, May 14, 2020 at 04:24:14PM +0530, Sharat Masetty wrote: > Subject: arm64: dts: qcom: sc7180: Add interconnect bindings for GPU > > This patch adds the interconnect bindings to the GPU node. This enables > the GPU->DDR path bandwidth voting. This patch doesn't add any bindings, it adds the interconnects/interconnect configuration for the GPU The order of the patches in this series is a bit odd. Typically you would start with the binding changes ("dt-bindings: drm/msm/gpu: Document gpu opp table" in this case), then the code needed to support these changes, and finally the DT bits for the specific devices/platforms making use of the new 'feature'. It doesn't really matter once the series has landed since the end result is exactly the same, however it's the logical order in which most reviewers read your patches, and typically also the order in which the patches land (especially when multiple trees are involved).
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index b46ee78..0ce9921 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1384,6 +1384,8 @@ operating-points-v2 = <&gpu_opp_table>; qcom,gmu = <&gmu>; + interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>; + gpu_opp_table: opp-table { compatible = "operating-points-v2";
This patch adds the interconnect bindings to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty <smasetty@codeaurora.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) -- 2.7.4