| Message ID | 1589946996-31264-1-git-send-email-pillair@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node | expand |
On 2020-05-20 09:26, Rakesh Pillai wrote: > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > Changes from v10: > - Corrected the position of wifi node, as per address > - Removed the wlan_fw_mem from reserved memory, since > its already added as reserved memory in board DT file. Reviewed-by: Sibi Sankar <sibis@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 +++++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++++++++++++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 4e9149d..38b102e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -389,6 +389,13 @@ > }; > }; > > +&wifi { > + status = "okay"; > + wifi-firmware { > + iommus = <&apps_smmu 0xc2 0x1>; > + }; > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qspi_clk { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 6b12c60..da79f8f 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2811,6 +2811,28 @@ > > #freq-domain-cells = <1>; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + reg = <0 0x18800000 0 0x800000>; > + reg-names = "membase"; > + iommus = <&apps_smmu 0xc0 0x1>; > + interrupts = > + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >, > + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >, > + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >, > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >, > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >, > + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >, > + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >, > + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >, > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >, > + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >, > + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>, > + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>; > + memory-region = <&wlan_mem>; > + status = "disabled"; > + }; > }; > > thermal-zones {
On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote: > > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> Reviewed-by: Evan Green <evgreen@chromium.org>
On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> wrote: > > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote: > > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > Reviewed-by: Evan Green <evgreen@chromium.org> Looks like this never landed anywhere. Is it blocked on something? -Evan
Hi Evan, All the dependent patches are already merged. Thanks, Rakesh Pillai. > -----Original Message----- > From: Evan Green <evgreen@chromium.org> > Sent: Thursday, June 18, 2020 4:15 AM > To: Rakesh Pillai <pillair@codeaurora.org>; Bjorn Andersson > <bjorn.andersson@linaro.org> > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@vger.kernel.org>; linux-arm Mailing List <linux-arm- > kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; linux- > arm-msm <linux-arm-msm@vger.kernel.org> > Subject: Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> > wrote: > > > > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> > wrote: > > > > > > Add device node for the ath10k SNOC platform driver probe > > > and add resources required for WCN3990 on sc7180 soc. > > > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > > > Reviewed-by: Evan Green <evgreen@chromium.org> > > Looks like this never landed anywhere. Is it blocked on something? > -Evan
On Wed 17 Jun 15:45 PDT 2020, Evan Green wrote: > On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> wrote: > > > > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> wrote: > > > > > > Add device node for the ath10k SNOC platform driver probe > > > and add resources required for WCN3990 on sc7180 soc. > > > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > > > Reviewed-by: Evan Green <evgreen@chromium.org> > > Looks like this never landed anywhere. Is it blocked on something? I remember waiting for some reviews, but I see those are in place. Then as I was applying this I saw that a v12 had shown up, with regulators. So, I applied v12. Thanks, Bjorn
> -----Original Message----- > From: Bjorn Andersson <bjorn.andersson@linaro.org> > Sent: Monday, June 22, 2020 12:36 AM > To: Evan Green <evgreen@chromium.org> > Cc: Rakesh Pillai <pillair@codeaurora.org>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-arm > Mailing List <linux-arm-kernel@lists.infradead.org>; LKML <linux- > kernel@vger.kernel.org>; linux-arm-msm <linux-arm- > msm@vger.kernel.org> > Subject: Re: [PATCH v11] arm64: dts: qcom: sc7180: Add WCN3990 WLAN > module device node > > On Wed 17 Jun 15:45 PDT 2020, Evan Green wrote: > > > On Thu, May 21, 2020 at 9:19 AM Evan Green <evgreen@chromium.org> > wrote: > > > > > > On Tue, May 19, 2020 at 8:57 PM Rakesh Pillai <pillair@codeaurora.org> > wrote: > > > > > > > > Add device node for the ath10k SNOC platform driver probe > > > > and add resources required for WCN3990 on sc7180 soc. > > > > > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > > > > > Reviewed-by: Evan Green <evgreen@chromium.org> > > > > Looks like this never landed anywhere. Is it blocked on something? > > I remember waiting for some reviews, but I see those are in place. Then > as I was applying this I saw that a v12 had shown up, with regulators. > > So, I applied v12. Thanks Bjorn. > > Thanks, > Bjorn
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 4e9149d..38b102e 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -389,6 +389,13 @@ }; }; +&wifi { + status = "okay"; + wifi-firmware { + iommus = <&apps_smmu 0xc2 0x1>; + }; +}; + /* PINCTRL - additions to nodes defined in sc7180.dtsi */ &qspi_clk { diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 6b12c60..da79f8f 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -2811,6 +2811,28 @@ #freq-domain-cells = <1>; }; + + wifi: wifi@18800000 { + compatible = "qcom,wcn3990-wifi"; + reg = <0 0x18800000 0 0x800000>; + reg-names = "membase"; + iommus = <&apps_smmu 0xc0 0x1>; + interrupts = + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >, + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >, + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >, + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >, + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >, + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >, + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >, + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >, + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >, + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >, + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>, + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>; + memory-region = <&wlan_mem>; + status = "disabled"; + }; }; thermal-zones {
Add device node for the ath10k SNOC platform driver probe and add resources required for WCN3990 on sc7180 soc. Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- Changes from v10: - Corrected the position of wifi node, as per address - Removed the wlan_fw_mem from reserved memory, since its already added as reserved memory in board DT file. --- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 7 +++++++ arch/arm64/boot/dts/qcom/sc7180.dtsi | 22 ++++++++++++++++++++++ 2 files changed, 29 insertions(+)