| Message ID | 1591440907-20021-2-git-send-email-sivaprak@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add APSS clock controller support for IPQ6018 | expand |
On Sat, 06 Jun 2020 16:25:04 +0530, Sivaprakash Murugesan wrote: > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> > --- > [V7] > * Addressed minor review comment from Rob > .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Quoting Sivaprakash Murugesan (2020-06-06 03:55:04) > cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 > pll found on ipq6018 devices. > > Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> > --- > [V7] > * Addressed minor review comment from Rob > .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > index 20d2638..3161fab 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml > @@ -15,6 +15,7 @@ description: > > properties: > compatible: > + const: qcom,ipq6018-a53pll > const: qcom,msm8916-a53pll > > reg: I'm getting this error when running dt binding check: ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "<unicode string>", line 18, column 5 found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll") in "<unicode string>", line 19, column 5
On 6/20/2020 6:06 AM, Stephen Boyd wrote: > Quoting Sivaprakash Murugesan (2020-06-06 03:55:04) >> cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 >> pll found on ipq6018 devices. >> >> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> >> --- >> [V7] >> * Addressed minor review comment from Rob >> .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> index 20d2638..3161fab 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> @@ -15,6 +15,7 @@ description: >> >> properties: >> compatible: >> + const: qcom,ipq6018-a53pll >> const: qcom,msm8916-a53pll >> >> reg: > I'm getting this error when running dt binding check: > > ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping > in "<unicode string>", line 18, column 5 > found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll") > in "<unicode string>", line 19, column 5 This error started coming after updating the dt-schema version. Guess I need to replace const with enum to get rid of this error. will address this.
diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml index 20d2638..3161fab 100644 --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml @@ -15,6 +15,7 @@ description: properties: compatible: + const: qcom,ipq6018-a53pll const: qcom,msm8916-a53pll reg: @@ -23,6 +24,14 @@ properties: '#clock-cells': const: 0 + clocks: + items: + - description: board XO clock + + clock-names: + items: + - const: xo + required: - compatible - reg @@ -38,3 +47,12 @@ examples: reg = <0xb016000 0x40>; #clock-cells = <0>; }; + #Example 2 - A53 PLL found on IPQ6018 devices + - | + a53pll_ipq: clock-controller@b116000 { + compatible = "qcom,ipq6018-a53pll"; + reg = <0x0b116000 0x40>; + #clock-cells = <0>; + clocks = <&xo>; + clock-names = "xo"; + };
cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 pll found on ipq6018 devices. Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> --- [V7] * Addressed minor review comment from Rob .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)