| Message ID | 1614963744-25962-2-git-send-email-loic.poulain@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] bus: mhi: core: Fix MHI runtime_pm behavior | expand |
On 2021-03-05 09:02 AM, Loic Poulain wrote: > Since M3 can be entered/exited quite a lot when used for runtime PM, > keep the mhi suspend/resume transitions quiet. > > Signed-off-by: Loic Poulain <loic.poulain@linaro.org> > --- > drivers/bus/mhi/core/pm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c > index edd7794..0cd6445 100644 > --- a/drivers/bus/mhi/core/pm.c > +++ b/drivers/bus/mhi/core/pm.c > @@ -858,7 +858,7 @@ int mhi_pm_suspend(struct mhi_controller > *mhi_cntrl) > return -EBUSY; > } > > - dev_info(dev, "Allowing M3 transition\n"); > + dev_dbg(dev, "Allowing M3 transition\n"); > new_state = mhi_tryset_pm_state(mhi_cntrl, MHI_PM_M3_ENTER); > if (new_state != MHI_PM_M3_ENTER) { > write_unlock_irq(&mhi_cntrl->pm_lock); > @@ -872,7 +872,7 @@ int mhi_pm_suspend(struct mhi_controller > *mhi_cntrl) > /* Set MHI to M3 and wait for completion */ > mhi_set_mhi_state(mhi_cntrl, MHI_STATE_M3); > write_unlock_irq(&mhi_cntrl->pm_lock); > - dev_info(dev, "Wait for M3 completion\n"); > + dev_dbg(dev, "Wait for M3 completion\n"); > > ret = wait_event_timeout(mhi_cntrl->state_event, > mhi_cntrl->dev_state == MHI_STATE_M3 || > @@ -906,7 +906,7 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl) > enum mhi_pm_state cur_state; > int ret; > > - dev_info(dev, "Entered with PM state: %s, MHI state: %s\n", > + dev_dbg(dev, "Entered with PM state: %s, MHI state: %s\n", > to_mhi_pm_state_str(mhi_cntrl->pm_state), > TO_MHI_STATE_STR(mhi_cntrl->dev_state)); Since we go from 4 chars (info) to 3 chars (dbg), there is need to adjust the two parameters here in the next two lines, right? If that's needed and is done, you can add my tag for: Reviewed-by: Bhaumik Bhatt <bbhatt@codeaurora.org> We can just push this patch as a standalone one not dependent on the 1/2 in this series. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c index edd7794..0cd6445 100644 --- a/drivers/bus/mhi/core/pm.c +++ b/drivers/bus/mhi/core/pm.c @@ -858,7 +858,7 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl) return -EBUSY; } - dev_info(dev, "Allowing M3 transition\n"); + dev_dbg(dev, "Allowing M3 transition\n"); new_state = mhi_tryset_pm_state(mhi_cntrl, MHI_PM_M3_ENTER); if (new_state != MHI_PM_M3_ENTER) { write_unlock_irq(&mhi_cntrl->pm_lock); @@ -872,7 +872,7 @@ int mhi_pm_suspend(struct mhi_controller *mhi_cntrl) /* Set MHI to M3 and wait for completion */ mhi_set_mhi_state(mhi_cntrl, MHI_STATE_M3); write_unlock_irq(&mhi_cntrl->pm_lock); - dev_info(dev, "Wait for M3 completion\n"); + dev_dbg(dev, "Wait for M3 completion\n"); ret = wait_event_timeout(mhi_cntrl->state_event, mhi_cntrl->dev_state == MHI_STATE_M3 || @@ -906,7 +906,7 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl) enum mhi_pm_state cur_state; int ret; - dev_info(dev, "Entered with PM state: %s, MHI state: %s\n", + dev_dbg(dev, "Entered with PM state: %s, MHI state: %s\n", to_mhi_pm_state_str(mhi_cntrl->pm_state), TO_MHI_STATE_STR(mhi_cntrl->dev_state));
Since M3 can be entered/exited quite a lot when used for runtime PM, keep the mhi suspend/resume transitions quiet. Signed-off-by: Loic Poulain <loic.poulain@linaro.org> --- drivers/bus/mhi/core/pm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)