diff mbox series

thermal: qcom: add missing put_device() call in init_common()

Message ID 1616465387-2973-1-git-send-email-dj0227@163.com (mailing list archive)
State Accepted
Commit f4136863e8899fa0554343201b78b9e197c78a78
Headers show
Series thermal: qcom: add missing put_device() call in init_common() | expand

Commit Message

Jian Dong March 23, 2021, 2:09 a.m. UTC 
From: Jian Dong <dongjian@yulong.com>

 Fixes coccicheck ERROR:

 drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device;
 call of_find_device_by_node on line 715, but without a corresponding
 object release within this function.

Signed-off-by: Jian Dong <dongjian@yulong.com>
---
 drivers/thermal/qcom/tsens.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

patchwork-bot+linux-arm-msm@kernel.org May 26, 2021, 7:03 p.m. UTC | #1 
Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Tue, 23 Mar 2021 10:09:47 +0800 you wrote:
> From: Jian Dong <dongjian@yulong.com>
> 
>  Fixes coccicheck ERROR:
> 
>  drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device;
>  call of_find_device_by_node on line 715, but without a corresponding
>  object release within this function.
> 
> [...]

Here is the summary with links:
  - thermal: qcom: add missing put_device() call in init_common()
    https://git.kernel.org/qcom/c/f4136863e889

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
diff mbox series

Patch

diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index d8ce3a6..3c4c051 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -755,8 +755,10 @@  int __init init_common(struct tsens_priv *priv)
 		for (i = VER_MAJOR; i <= VER_STEP; i++) {
 			priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map,
 							      priv->fields[i]);
-			if (IS_ERR(priv->rf[i]))
-				return PTR_ERR(priv->rf[i]);
+			if (IS_ERR(priv->rf[i])) {
+				ret = PTR_ERR(priv->rf[i]);
+				goto err_put_device;
+			}
 		}
 		ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor);
 		if (ret)