diff mbox series

[V3,5/5] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

Message ID 1620630064-16354-6-git-send-email-skakit@codeaurora.org (mailing list archive)
State Superseded
Headers show
Series Add support for PMK8350 PON_HLOS PMIC peripheral | expand

Commit Message

satya priya May 10, 2021, 7:01 a.m. UTC
Convert qcom PON binding from .txt to .yaml format.

The example has been removed in favour of full example being
available in the qcom,pm8941-pwrkey binding.

Signed-off-by: satya priya <skakit@codeaurora.org>
---
Changes in V2:
 - As per Rob's comments, converted the main PON binding and added in V2.

Changes in V3:
 - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
   used unevaluatedProperties = false. Added maxItems for reg.

 .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
 .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 49 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
 create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml

Comments

Rob Herring May 10, 2021, 4:25 p.m. UTC | #1
On Mon, 10 May 2021 12:31:04 +0530, satya priya wrote:
> Convert qcom PON binding from .txt to .yaml format.
> 
> The example has been removed in favour of full example being
> available in the qcom,pm8941-pwrkey binding.
> 
> Signed-off-by: satya priya <skakit@codeaurora.org>
> ---
> Changes in V2:
>  - As per Rob's comments, converted the main PON binding and added in V2.
> 
> Changes in V3:
>  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
>    used unevaluatedProperties = false. Added maxItems for reg.
> 
>  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
>  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
>  2 files changed, 44 insertions(+), 49 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Sebastian Reichel June 4, 2021, 11:09 a.m. UTC | #2
Hi,

On Mon, May 10, 2021 at 11:25:06AM -0500, Rob Herring wrote:
> On Mon, 10 May 2021 12:31:04 +0530, satya priya wrote:
> > Convert qcom PON binding from .txt to .yaml format.
> > 
> > The example has been removed in favour of full example being
> > available in the qcom,pm8941-pwrkey binding.
> > 
> > Signed-off-by: satya priya <skakit@codeaurora.org>
> > ---
> > Changes in V2:
> >  - As per Rob's comments, converted the main PON binding and added in V2.
> > 
> > Changes in V3:
> >  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
> >    used unevaluatedProperties = false. Added maxItems for reg.
> > 
> >  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
> >  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
> >  2 files changed, 44 insertions(+), 49 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
> >  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Acked-by: Sebastian Reichel <sre@kernel.org>

-- Sebastian
satya priya June 4, 2021, 11:42 a.m. UTC | #3
Hi,

On 2021-06-04 16:39, Sebastian Reichel wrote:
> Hi,
> 
> On Mon, May 10, 2021 at 11:25:06AM -0500, Rob Herring wrote:
>> On Mon, 10 May 2021 12:31:04 +0530, satya priya wrote:
>> > Convert qcom PON binding from .txt to .yaml format.
>> >
>> > The example has been removed in favour of full example being
>> > available in the qcom,pm8941-pwrkey binding.
>> >
>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>> > ---
>> > Changes in V2:
>> >  - As per Rob's comments, converted the main PON binding and added in V2.
>> >
>> > Changes in V3:
>> >  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
>> >    used unevaluatedProperties = false. Added maxItems for reg.
>> >
>> >  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
>> >  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
>> >  2 files changed, 44 insertions(+), 49 deletions(-)
>> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>> >  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
>> >
>> 
>> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> Acked-by: Sebastian Reichel <sre@kernel.org>
> 

There is a V4 for this.
https://lore.kernel.org/patchwork/patch/1425638/

> -- Sebastian
satya priya June 4, 2021, 11:45 a.m. UTC | #4
On 2021-06-04 17:12, skakit@codeaurora.org wrote:
> Hi,
> 
> On 2021-06-04 16:39, Sebastian Reichel wrote:
>> Hi,
>> 
>> On Mon, May 10, 2021 at 11:25:06AM -0500, Rob Herring wrote:
>>> On Mon, 10 May 2021 12:31:04 +0530, satya priya wrote:
>>> > Convert qcom PON binding from .txt to .yaml format.
>>> >
>>> > The example has been removed in favour of full example being
>>> > available in the qcom,pm8941-pwrkey binding.
>>> >
>>> > Signed-off-by: satya priya <skakit@codeaurora.org>
>>> > ---
>>> > Changes in V2:
>>> >  - As per Rob's comments, converted the main PON binding and added in V2.
>>> >
>>> > Changes in V3:
>>> >  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
>>> >    used unevaluatedProperties = false. Added maxItems for reg.
>>> >
>>> >  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
>>> >  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
>>> >  2 files changed, 44 insertions(+), 49 deletions(-)
>>> >  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
>>> >  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
>>> >
>>> 
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>> 
>> Acked-by: Sebastian Reichel <sre@kernel.org>
>> 
> 
> There is a V4 for this.
> https://lore.kernel.org/patchwork/patch/1425638/
> 
Seems like you already reviewed the V4.

Thanks,
Satya Priya
>> -- Sebastian
Sebastian Reichel June 4, 2021, 11:58 a.m. UTC | #5
Hi,

On Fri, Jun 04, 2021 at 05:15:17PM +0530, skakit@codeaurora.org wrote:
> On 2021-06-04 17:12, skakit@codeaurora.org wrote:
> > Hi,
> > 
> > On 2021-06-04 16:39, Sebastian Reichel wrote:
> > > Hi,
> > > 
> > > On Mon, May 10, 2021 at 11:25:06AM -0500, Rob Herring wrote:
> > > > On Mon, 10 May 2021 12:31:04 +0530, satya priya wrote:
> > > > > Convert qcom PON binding from .txt to .yaml format.
> > > > >
> > > > > The example has been removed in favour of full example being
> > > > > available in the qcom,pm8941-pwrkey binding.
> > > > >
> > > > > Signed-off-by: satya priya <skakit@codeaurora.org>
> > > > > ---
> > > > > Changes in V2:
> > > > >  - As per Rob's comments, converted the main PON binding and added in V2.
> > > > >
> > > > > Changes in V3:
> > > > >  - As per Sebastian's comments, added allOf to refer reboot-mode.yaml and
> > > > >    used unevaluatedProperties = false. Added maxItems for reg.
> > > > >
> > > > >  .../devicetree/bindings/power/reset/qcom,pon.txt   | 49 ----------------------
> > > > >  .../devicetree/bindings/power/reset/qcom,pon.yaml  | 44 +++++++++++++++++++
> > > > >  2 files changed, 44 insertions(+), 49 deletions(-)
> > > > >  delete mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.txt
> > > > >  create mode 100644 Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> > > > >
> > > > 
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > 
> > > Acked-by: Sebastian Reichel <sre@kernel.org>
> > > 
> > 
> > There is a V4 for this.
> > https://lore.kernel.org/patchwork/patch/1425638/
> > 
> Seems like you already reviewed the V4.

Ack, just ignore this :)

-- Sebastian
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt b/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
deleted file mode 100644
index 0c0dc3a..0000000
--- a/Documentation/devicetree/bindings/power/reset/qcom,pon.txt
+++ /dev/null
@@ -1,49 +0,0 @@ 
-Qualcomm PON Device
-
-The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
-and resin along with the Android reboot-mode.
-
-This DT node has pwrkey and resin as sub nodes.
-
-Required Properties:
--compatible: Must be one of:
-	"qcom,pm8916-pon"
-	"qcom,pms405-pon"
-	"qcom,pm8998-pon"
-
--reg: Specifies the physical address of the pon register
-
-Optional subnode:
--pwrkey: Specifies the subnode pwrkey and should follow the
- qcom,pm8941-pwrkey.txt description.
--resin: Specifies the subnode resin and should follow the
- qcom,pm8xxx-pwrkey.txt description.
-
-The rest of the properties should follow the generic reboot-mode description
-found in reboot-mode.txt
-
-Example:
-
-	pon@800 {
-		compatible = "qcom,pm8916-pon";
-
-		reg = <0x800>;
-		mode-bootloader = <0x2>;
-		mode-recovery = <0x1>;
-
-		pwrkey {
-			compatible = "qcom,pm8941-pwrkey";
-			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
-			linux,code = <KEY_POWER>;
-		};
-
-		resin {
-			compatible = "qcom,pm8941-resin";
-			interrupts = <0x0 0x8 1 IRQ_TYPE_EDGE_BOTH>;
-			debounce = <15625>;
-			bias-pull-up;
-			linux,code = <KEY_VOLUMEDOWN>;
-		};
-	};
diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
new file mode 100644
index 0000000..439f082
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
@@ -0,0 +1,44 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/reset/qcom,pon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm PON Device
+
+maintainers:
+  - Vinod Koul <vkoul@kernel.org>
+
+description: |
+  The Power On device for Qualcomm PM8xxx is MFD supporting pwrkey
+  and resin along with the Android reboot-mode.
+
+  This DT node has pwrkey and resin as sub nodes.
+
+allOf:
+  - $ref: reboot-mode.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,pm8916-pon
+      - qcom,pms405-pon
+      - qcom,pm8998-pon
+
+  reg:
+    maxItems: 1
+
+  pwrkey:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+  resin:
+    type: object
+    $ref: "../../input/qcom,pm8941-pwrkey.yaml#"
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+...