| Message ID | 1623309189-27943-1-git-send-email-sbhanu@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V1] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card | expand |
Hi Sajida, Thank you for the patch! On 10.06.21 10:13, Shaik Sajida Bhanu wrote: > Updated bus votes for eMMC and Sd card. The commit text should also give answer to the question "Why is this patch necessary?". Do we need a Fixes: tag? The subject could be improved too. Please check: https://www.kernel.org/doc/Documentation/process/submitting-patches.rst Thanks, Georgi > > Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 295844e..1fce39d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -726,15 +726,15 @@ > opp-100000000 { > opp-hz = /bits/ 64 <100000000>; > required-opps = <&rpmhpd_opp_low_svs>; > - opp-peak-kBps = <100000 100000>; > - opp-avg-kBps = <100000 50000>; > + opp-peak-kBps = <1800000 600000>; > + opp-avg-kBps = <100000 0>; > }; > > opp-384000000 { > opp-hz = /bits/ 64 <384000000>; > - required-opps = <&rpmhpd_opp_svs_l1>; > - opp-peak-kBps = <600000 900000>; > - opp-avg-kBps = <261438 300000>; > + required-opps = <&rpmhpd_opp_nom>; > + opp-peak-kBps = <5400000 1600000>; > + opp-avg-kBps = <390000 0>; > }; > }; > }; > @@ -2685,15 +2685,15 @@ > opp-100000000 { > opp-hz = /bits/ 64 <100000000>; > required-opps = <&rpmhpd_opp_low_svs>; > - opp-peak-kBps = <160000 100000>; > - opp-avg-kBps = <80000 50000>; > + opp-peak-kBps = <1800000 600000>; > + opp-avg-kBps = <100000 0>; > }; > > opp-202000000 { > opp-hz = /bits/ 64 <202000000>; > - required-opps = <&rpmhpd_opp_svs_l1>; > - opp-peak-kBps = <200000 120000>; > - opp-avg-kBps = <100000 60000>; > + required-opps = <&rpmhpd_opp_nom>; > + opp-peak-kBps = <5400000 1600000>; > + opp-avg-kBps = <200000 0>; > }; > }; > }; >
On 2021-06-10 13:04, Georgi Djakov wrote: > Hi Sajida, > > Thank you for the patch! > > On 10.06.21 10:13, Shaik Sajida Bhanu wrote: >> Updated bus votes for eMMC and Sd card. > > The commit text should also give answer to the question "Why is this > patch necessary?". Do we need a Fixes: tag? The subject could be > improved too. Please check: > https://www.kernel.org/doc/Documentation/process/submitting-patches.rst > > Thanks, > Georgi > Sure will update the commit message >> >> Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 295844e..1fce39d 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -726,15 +726,15 @@ >> opp-100000000 { >> opp-hz = /bits/ 64 <100000000>; >> required-opps = <&rpmhpd_opp_low_svs>; >> - opp-peak-kBps = <100000 100000>; >> - opp-avg-kBps = <100000 50000>; >> + opp-peak-kBps = <1800000 600000>; >> + opp-avg-kBps = <100000 0>; >> }; >> opp-384000000 { >> opp-hz = /bits/ 64 <384000000>; >> - required-opps = <&rpmhpd_opp_svs_l1>; >> - opp-peak-kBps = <600000 900000>; >> - opp-avg-kBps = <261438 300000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <5400000 1600000>; >> + opp-avg-kBps = <390000 0>; >> }; >> }; >> }; >> @@ -2685,15 +2685,15 @@ >> opp-100000000 { >> opp-hz = /bits/ 64 <100000000>; >> required-opps = <&rpmhpd_opp_low_svs>; >> - opp-peak-kBps = <160000 100000>; >> - opp-avg-kBps = <80000 50000>; >> + opp-peak-kBps = <1800000 600000>; >> + opp-avg-kBps = <100000 0>; >> }; >> opp-202000000 { >> opp-hz = /bits/ 64 <202000000>; >> - required-opps = <&rpmhpd_opp_svs_l1>; >> - opp-peak-kBps = <200000 120000>; >> - opp-avg-kBps = <100000 60000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <5400000 1600000>; >> + opp-avg-kBps = <200000 0>; >> }; >> }; >> }; >>
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index 295844e..1fce39d 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -726,15 +726,15 @@ opp-100000000 { opp-hz = /bits/ 64 <100000000>; required-opps = <&rpmhpd_opp_low_svs>; - opp-peak-kBps = <100000 100000>; - opp-avg-kBps = <100000 50000>; + opp-peak-kBps = <1800000 600000>; + opp-avg-kBps = <100000 0>; }; opp-384000000 { opp-hz = /bits/ 64 <384000000>; - required-opps = <&rpmhpd_opp_svs_l1>; - opp-peak-kBps = <600000 900000>; - opp-avg-kBps = <261438 300000>; + required-opps = <&rpmhpd_opp_nom>; + opp-peak-kBps = <5400000 1600000>; + opp-avg-kBps = <390000 0>; }; }; }; @@ -2685,15 +2685,15 @@ opp-100000000 { opp-hz = /bits/ 64 <100000000>; required-opps = <&rpmhpd_opp_low_svs>; - opp-peak-kBps = <160000 100000>; - opp-avg-kBps = <80000 50000>; + opp-peak-kBps = <1800000 600000>; + opp-avg-kBps = <100000 0>; }; opp-202000000 { opp-hz = /bits/ 64 <202000000>; - required-opps = <&rpmhpd_opp_svs_l1>; - opp-peak-kBps = <200000 120000>; - opp-avg-kBps = <100000 60000>; + required-opps = <&rpmhpd_opp_nom>; + opp-peak-kBps = <5400000 1600000>; + opp-avg-kBps = <200000 0>; }; }; };
Updated bus votes for eMMC and Sd card. Signed-off-by: Shaik Sajida Bhanu <sbhanu@codeaurora.org> --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)