| Message ID | 1624896105-26852-1-git-send-email-mansur@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [V2] venus: helper: do not set constrained parameters for UBWC | expand |
On 28/06/2021 17:01, Mansur Alisha Shaik wrote: > onstrained parameters are to override the default alignment for > a given color format. By default venus hardware has alignments as > 128x32, but NV12 was defined differently to meet various usecases. > Compressed NV12 has always been aligned as 128x32, hence not needed > to override the default alignment. > > Fixes: bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane > constraints to FW") > Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org> > > Changes in V2: > - Elaborated commit message as per comments by Bryan > --- > drivers/media/platform/qcom/venus/helpers.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c > index 1fe6d46..601ee3e 100644 > --- a/drivers/media/platform/qcom/venus/helpers.c > +++ b/drivers/media/platform/qcom/venus/helpers.c > @@ -1137,8 +1137,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst) > if (!IS_V6(inst->core)) > return 0; > > + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC) > + return 0; > + > pconstraint.buffer_type = HFI_BUFFER_OUTPUT2; > pconstraint.num_planes = 2; > + > pconstraint.plane_format[0].stride_multiples = 128; > pconstraint.plane_format[0].max_stride = 8192; > pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32; > Looks better to me on the commit log thanks. You've missed the "C" from "Constrained parameters" though, also I don't know if its my mail client or not but "Fixes: xxx ("thing fixed") should all be on the one line even if it exceeds the 75 character limit. --- bod
diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c index 1fe6d46..601ee3e 100644 --- a/drivers/media/platform/qcom/venus/helpers.c +++ b/drivers/media/platform/qcom/venus/helpers.c @@ -1137,8 +1137,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst) if (!IS_V6(inst->core)) return 0; + if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC) + return 0; + pconstraint.buffer_type = HFI_BUFFER_OUTPUT2; pconstraint.num_planes = 2; + pconstraint.plane_format[0].stride_multiples = 128; pconstraint.plane_format[0].max_stride = 8192; pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32;
onstrained parameters are to override the default alignment for a given color format. By default venus hardware has alignments as 128x32, but NV12 was defined differently to meet various usecases. Compressed NV12 has always been aligned as 128x32, hence not needed to override the default alignment. Fixes: bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane constraints to FW") Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org> Changes in V2: - Elaborated commit message as per comments by Bryan --- drivers/media/platform/qcom/venus/helpers.c | 4 ++++ 1 file changed, 4 insertions(+)