| Message ID | 1626395276-24171-3-git-send-email-bbhatt@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Fix serial number usage in MHI bus | expand |
On Thu, Jul 15, 2021 at 05:27:56PM -0700, Bhaumik Bhatt wrote: > In order to maintain consistency with the way OEM PK hash is > displayed and improve the current way, depict serial number in > upper case hexadecimals. > > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> Just a minor nit, other than that: Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Thanks, Mani > --- > drivers/bus/mhi/core/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index 8b4336e..d825a06 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev, > struct mhi_device *mhi_dev = to_mhi_device(dev); > struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; > > - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n", > + return snprintf(buf, PAGE_SIZE, "Serial Number: 0x%X\n", nit: please use "0x%x" > mhi_cntrl->serial_number); > } > static DEVICE_ATTR_RO(serial_number); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index 8b4336e..d825a06 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev, struct mhi_device *mhi_dev = to_mhi_device(dev); struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n", + return snprintf(buf, PAGE_SIZE, "Serial Number: 0x%X\n", mhi_cntrl->serial_number); } static DEVICE_ATTR_RO(serial_number);
In order to maintain consistency with the way OEM PK hash is displayed and improve the current way, depict serial number in upper case hexadecimals. Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org> --- drivers/bus/mhi/core/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)