| Message ID | 1630906083-32194-2-git-send-email-mkshah@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce SoC sleep stats driver | expand |
Quoting Maulik Shah (2021-09-05 22:27:59) > diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > new file mode 100644 > index 0000000..4161156 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings > + > +maintainers: > + - Maulik Shah <mkshah@codeaurora.org> > + - Lina Iyer <ilina@codeaurora.org> > + > +description: > + Always On Processor/Resource Power Manager maintains statistics of the SoC > + sleep modes involving powering down of the rails and oscillator clock. > + > + Statistics includes SoC sleep mode type, number of times low power mode were > + entered, time of last entry, time of last exit and accumulated sleep duration. > + > +properties: > + compatible: > + enum: > + - qcom,rpmh-sleep-stats > + - qcom,rpm-sleep-stats > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + # Example of rpmh sleep stats > + - | > + aop_msgram@c3f0048 { Node names should be generic and not have any underscores in them. I still think 'memory' is more appropriate here. I doubt anyone will confuse it for DDR. > + compatible = "qcom,rpmh-sleep-stats"; > + reg = <0x0c3f0048 0x400>; > + };
On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote: > From: Mahesh Sivasubramanian <msivasub@codeaurora.org> > > Add device binding documentation for Qualcomm Technologies, Inc. (QTI) > SoC sleep stats driver. The driver is used for displaying SoC sleep > statistic maintained by Always On Processor or Resource Power Manager. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> > Signed-off-by: Lina Iyer <ilina@codeaurora.org> > Signed-off-by: Maulik Shah <mkshah@codeaurora.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > --- > .../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > new file mode 100644 > index 0000000..4161156 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings > + > +maintainers: > + - Maulik Shah <mkshah@codeaurora.org> > + - Lina Iyer <ilina@codeaurora.org> Lina's address is no longer valid. > + > +description: > + Always On Processor/Resource Power Manager maintains statistics of the SoC > + sleep modes involving powering down of the rails and oscillator clock. > + > + Statistics includes SoC sleep mode type, number of times low power mode were > + entered, time of last entry, time of last exit and accumulated sleep duration. > + > +properties: > + compatible: > + enum: > + - qcom,rpmh-sleep-stats > + - qcom,rpm-sleep-stats > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + # Example of rpmh sleep stats > + - | > + aop_msgram@c3f0048 { > + compatible = "qcom,rpmh-sleep-stats"; > + reg = <0x0c3f0048 0x400>; As I tested this series I did find it quite odd that the start address of this block is $48 bytes into a page and still the length is an even $400. Is there any single platform where qcom,rpmh-sleep-stats doesn't start at an offset of $48 from the beginning of its msgram? Could we move this number to the driver? Regards, Bjorn > + }; > + # Example of rpm sleep stats > + - | > + rpm_msgram@4690000 { > + compatible = "qcom,rpm-sleep-stats"; > + reg = <0x04690000 0x400>; > + }; > +... > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
Hi, On 9/25/2021 4:53 AM, Bjorn Andersson wrote: > On Mon 06 Sep 00:27 CDT 2021, Maulik Shah wrote: > >> From: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> >> Add device binding documentation for Qualcomm Technologies, Inc. (QTI) >> SoC sleep stats driver. The driver is used for displaying SoC sleep >> statistic maintained by Always On Processor or Resource Power Manager. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org> >> Signed-off-by: Lina Iyer <ilina@codeaurora.org> >> Signed-off-by: Maulik Shah <mkshah@codeaurora.org> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> >> Reviewed-by: Stephen Boyd <swboyd@chromium.org> >> --- >> .../bindings/soc/qcom/soc-sleep-stats.yaml | 48 ++++++++++++++++++++++ >> 1 file changed, 48 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> new file mode 100644 >> index 0000000..4161156 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml >> @@ -0,0 +1,48 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings >> + >> +maintainers: >> + - Maulik Shah <mkshah@codeaurora.org> >> + - Lina Iyer <ilina@codeaurora.org> > > Lina's address is no longer valid. Removed in v10. > >> + >> +description: >> + Always On Processor/Resource Power Manager maintains statistics of the SoC >> + sleep modes involving powering down of the rails and oscillator clock. >> + >> + Statistics includes SoC sleep mode type, number of times low power mode were >> + entered, time of last entry, time of last exit and accumulated sleep duration. >> + >> +properties: >> + compatible: >> + enum: >> + - qcom,rpmh-sleep-stats >> + - qcom,rpm-sleep-stats >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + >> +additionalProperties: false >> + >> +examples: >> + # Example of rpmh sleep stats >> + - | >> + aop_msgram@c3f0048 { >> + compatible = "qcom,rpmh-sleep-stats"; >> + reg = <0x0c3f0048 0x400>; > > As I tested this series I did find it quite odd that the start address > of this block is $48 bytes into a page and still the length is an even > $400. > > Is there any single platform where qcom,rpmh-sleep-stats doesn't start > at an offset of $48 from the beginning of its msgram? Could we move this > number to the driver? > > Regards, > Bjorn Sure, i have moved 0x48 into driver in v10. Thanks, Maulik > >> + }; >> + # Example of rpm sleep stats >> + - | >> + rpm_msgram@4690000 { >> + compatible = "qcom,rpm-sleep-stats"; >> + reg = <0x04690000 0x400>; >> + }; >> +... >> -- >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member >> of Code Aurora Forum, hosted by The Linux Foundation >>
diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml new file mode 100644 index 0000000..4161156 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/qcom/soc-sleep-stats.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. (QTI) SoC sleep stats bindings + +maintainers: + - Maulik Shah <mkshah@codeaurora.org> + - Lina Iyer <ilina@codeaurora.org> + +description: + Always On Processor/Resource Power Manager maintains statistics of the SoC + sleep modes involving powering down of the rails and oscillator clock. + + Statistics includes SoC sleep mode type, number of times low power mode were + entered, time of last entry, time of last exit and accumulated sleep duration. + +properties: + compatible: + enum: + - qcom,rpmh-sleep-stats + - qcom,rpm-sleep-stats + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + # Example of rpmh sleep stats + - | + aop_msgram@c3f0048 { + compatible = "qcom,rpmh-sleep-stats"; + reg = <0x0c3f0048 0x400>; + }; + # Example of rpm sleep stats + - | + rpm_msgram@4690000 { + compatible = "qcom,rpm-sleep-stats"; + reg = <0x04690000 0x400>; + }; +...