Message ID | 1634640531-15813-3-git-send-email-skakit@codeaurora.org (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
Series | Add PM8350C PMIC PWM support for backlight | expand |
On Tue 19 Oct 03:48 PDT 2021, Satya Priya wrote: > From: satya priya <skakit@codeaurora.org> > > Add pm8350c compatible and lpg_data to the driver. > > Signed-off-by: satya priya <skakit@codeaurora.org> > Reviewed-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in V2: > - Added const for lpg_channel_data[] struct. > > drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index 45ef4ec..99235af 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = { > }, > }; > > +static const struct lpg_data pm8350c_pwm_data = { > + .pwm_9bit_mask = BIT(2), > + > + .num_channels = 1, No, this should be 4. The fact that you only care about the first channel in your product should be reflected in the dts, not in the driver. Thanks, Bjorn > + .channels = (const struct lpg_channel_data[]) { > + { .base = 0xeb00 }, > + }, > +}; > + > static const struct of_device_id lpg_of_table[] = { > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, > { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, > { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data }, > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >
diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c index 45ef4ec..99235af 100644 --- a/drivers/leds/rgb/leds-qcom-lpg.c +++ b/drivers/leds/rgb/leds-qcom-lpg.c @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = { }, }; +static const struct lpg_data pm8350c_pwm_data = { + .pwm_9bit_mask = BIT(2), + + .num_channels = 1, + .channels = (const struct lpg_channel_data[]) { + { .base = 0xeb00 }, + }, +}; + static const struct of_device_id lpg_of_table[] = { { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },