diff mbox series

[3/3] usb: dwc: host: Set the property usb-skip-phy-init

Message ID 1635272372-9982-4-git-send-email-quic_c_sanm@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Skip phy initialization for DWC3 USB Controllers | expand

Commit Message

Sandeep Maheswaram Oct. 26, 2021, 6:19 p.m. UTC
dwc3 manages PHY by own DRD driver, so skip the management by
HCD core.
During runtime suspend phy was not getting suspend because
runtime_usage value is 2.

Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
---
 drivers/usb/dwc3/host.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thinh Nguyen Oct. 26, 2021, 9:20 p.m. UTC | #1
Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  drivers/usb/dwc3/host.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index f29a264..5144513 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -107,6 +107,8 @@ int dwc3_host_init(struct dwc3 *dwc)
>  	if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
>  		props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
>  
> +	props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");

Increase props[] array size with this new change.

> +
>  	if (prop_idx) {
>  		ret = device_create_managed_software_node(&xhci->dev, props, NULL);
>  		if (ret) {
> 

Can we update the $subject prefix from "dwc" to "dwc3"?

Thanks,
Thinh
Greg KH Oct. 30, 2021, 8:57 a.m. UTC | #2
On Tue, Oct 26, 2021 at 11:49:32PM +0530, Sandeep Maheswaram wrote:
> dwc3 manages PHY by own DRD driver, so skip the management by
> HCD core.
> During runtime suspend phy was not getting suspend because
> runtime_usage value is 2.
> 
> Signed-off-by: Sandeep Maheswaram <quic_c_sanm@quicinc.com>
> ---
>  drivers/usb/dwc3/host.c | 2 ++
>  1 file changed, 2 insertions(+)

Subject line should have "dwc3" not "dwc", right?

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index f29a264..5144513 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -107,6 +107,8 @@  int dwc3_host_init(struct dwc3 *dwc)
 	if (DWC3_VER_IS_WITHIN(DWC3, ANY, 300A))
 		props[prop_idx++] = PROPERTY_ENTRY_BOOL("quirk-broken-port-ped");
 
+	props[prop_idx++] = PROPERTY_ENTRY_BOOL("usb-skip-phy-init");
+
 	if (prop_idx) {
 		ret = device_create_managed_software_node(&xhci->dev, props, NULL);
 		if (ret) {