| Message ID | 1637046458-20607-4-git-send-email-quic_sbillaka@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add support for eDP PHY on SC7280 platform | expand |
Quoting Sankeerth Billakanti (2021-11-15 23:07:38) > Some legacy eDP sinks may not support SSC. The support for SSC is > indicated through an opts flag from the controller driver. This > change will enable SSC only if the sink supports it. > > Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > --- I suppose as long as the existing user has already chosen to set the opts in the controller driver then this is fine. Reviewed-by: Stephen Boyd <swboyd@chromium.org>
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index 6d9404d..06ba609 100644 --- a/drivers/phy/qualcomm/phy-qcom-edp.c +++ b/drivers/phy/qualcomm/phy-qcom-edp.c @@ -335,9 +335,11 @@ static int qcom_edp_phy_power_on(struct phy *phy) writel(0x00, edp->tx0 + TXn_LANE_MODE_1); writel(0x00, edp->tx1 + TXn_LANE_MODE_1); - ret = qcom_edp_configure_ssc(edp); - if (ret) - return ret; + if (edp->dp_opts.ssc) { + ret = qcom_edp_configure_ssc(edp); + if (ret) + return ret; + } ret = qcom_edp_configure_pll(edp); if (ret)
Some legacy eDP sinks may not support SSC. The support for SSC is indicated through an opts flag from the controller driver. This change will enable SSC only if the sink supports it. Signed-off-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> --- drivers/phy/qualcomm/phy-qcom-edp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)